epicwhale / ninja Goto Github PK

Reverse Routing allows you to create links to named routes. When creating links just use the route's name and Ninja will automatically insert the correct URI. This allows you to change your routes at a later time and Ninja will update all of the relevant links site-wide.

Looking for good references of such an implementation.. CI, Laravel, Kohana?

Presently, page not found errors are being logged in production mode. This is not a problem, but undesirable behavior. Should be fix as early as possible.

Kohana has a file called install.php that exists in the root of the website and performs Environment Tests + Optional Tests. This is a completely independent file that helps check if a server is compatible with Ninja or not. We need this too as it will ensure that the developer is working & deploying on a fully compatible platform. See it here: http://kohanaframework.org/3.2/guide/kohana/install#installation

Refer to: https://github.com/kohana/kohana/blob/3.2/master/index.php for the simplistic code & layout they use. We will adapt the same and later on re-touch the design.

There might be some requirements we don't need to check while there would be some requirements which should add in addition to what Kohana does. Suggest such additions / deletions.

Presently, all controllers can be accessed publicly as long as they have an action which maps to the requested URL. This should not be the case if the controller is 'Abstract'. This way AbstractControllers can be placed which are inherited by other controllers without the risk of being exposed to public access.

We can do this by prefixing all Abstract controller classnames with the word 'Abstract'. This retains general naming convention found in libraries like Doctrine, etc too.

<?php
namespace Controller;

abstract class AbstractFoo extends \Ninja\Controller
{
    public function hello()
    {
        echo "yaa";
    }
}

Ideally in production mode, page not found's should not be logged as it can cause flooding of the file logging the error.

Presently error logs do not show the request URL under which the log entry appeared. Adding it to the log entry will allow re-creation of bugs much better.

\Ninja\Resource::getSessionNamespace(..) must be getZendSessionNamespace()

\Ninja\Resource::getDb() should be ::getDoctrineDBALConnection()

This is in principle with keeping everything verbose.