Comments (5)
kentcdodds
commented on May 27, 2024
Ah yeah, that'll need to be refactored a bit to separate the server-only utils from the UI utils.
from epic-stack.
itsmegood
commented on May 27, 2024
Kent i looked through and found that permission.ts is only called a single place in the client https://github.com/epicweb-dev/epic-stack/blob/main/app/routes/users%2B/%24username_%2B/notes.%24noteId.tsx#L112
If you like we can remove either that and pass something is isOwner (boolean) down from loader and remove the code entirely and then convert permission.ts to fully server side.
from epic-stack.
kentcdodds
commented on May 27, 2024
The utility is useful for people to use as they build out their site, so we should split them up into a .server file for the server stuff and a regular file for the UI stuff
from epic-stack.
gregleeper
commented on May 27, 2024
For me, I moved userHasPermission and userHasRole to the user.ts utility as it made just as much sense there. I moved the rest of the permissions.ts file to the permissions.server.ts file.
from epic-stack.
kentcdodds
commented on May 27, 2024
This has been resolved. Thanks everyone!
from epic-stack.
Related Issues (20)
- Add documentation to run app locally with Docker HOT 3
- issues when scaling up machines on fly HOT 10
- Makes sense to substitute Express for Fastify? HOT 3
- Create an account button shows error but should not HOT 3
- Vitest fails after Prisma migration HOT 1
- npm test:e2e:run fails nearly all the time HOT 4
- Rate limiting can be bypassed with a spoofed ip HOT 5
- dev-server long running command does not give back shell input correctly on fish shell HOT 3
- dev-server does not restarts when it crashes HOT 3
- `npm run validate` without having to stop the dev server
- Running Playwright (or the stack) in Docker HOT 1
- No relative import paths HOT 2
- Configuration for the possibility of using postgresql
- /swapon command failing when deploying to production HOT 2
- Tests failing on a fresh install due to SyntaxErrors HOT 2
- Adding tags/releases to the repository HOT 6
- Running Vitest locally can cause errors due to missing schema updates in test database HOT 3
- SENTRY_PROJECT missing from deploy.yml HOT 3
- Conflict on seeding production db HOT 1
- Remove `@remix-run/server-runtime` as a dependency HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from epic-stack.