Comments (5)
kentcdodds
commented on May 27, 2024
Nice find! I welcome a PR to switch our implementation to use the Fly-Client-Ip header!
from epic-stack.
nickjamesio
commented on May 27, 2024
I will def work on it!
from epic-stack.
andrecasal
commented on May 27, 2024
Great work Nick!
from epic-stack.
nickjamesio
commented on May 27, 2024
Been a busy week but I did get a chance to do some testing. It looks like Fly-Client-Ip can indeed work. One edge case though. If someone has a proxy in front of the app like Cloudflare, Fly-Client-Ip will contain the IP of Cloudflare, not the end user.
I did a quick search and it does not look like epic-stack requires the use of cloudflare. However, it can have unintended consequences if someone uses Cloudflare and is unaware. Do you have a recommendation on where to mention this or if it should be mentioned at all?
from epic-stack.
kentcdodds
commented on May 27, 2024
Hmmmm... It definitely should be mentioned. Can probably just do a code comment. People making changes is always going to affect the assumptions we make and we can't over-complicate the codebase for every possible change people make to the stack.
from epic-stack.
Related Issues (20)
- Add documentation to run app locally with Docker HOT 3
- issues when scaling up machines on fly HOT 10
- Makes sense to substitute Express for Fastify? HOT 3
- Create an account button shows error but should not HOT 3
- Vitest fails after Prisma migration HOT 1
- npm test:e2e:run fails nearly all the time HOT 4
- dev-server long running command does not give back shell input correctly on fish shell HOT 3
- dev-server does not restarts when it crashes HOT 3
- `npm run validate` without having to stop the dev server
- Running Playwright (or the stack) in Docker HOT 1
- No relative import paths HOT 2
- Configuration for the possibility of using postgresql
- /swapon command failing when deploying to production HOT 2
- Tests failing on a fresh install due to SyntaxErrors HOT 2
- Adding tags/releases to the repository HOT 6
- Running Vitest locally can cause errors due to missing schema updates in test database HOT 3
- SENTRY_PROJECT missing from deploy.yml HOT 3
- Conflict on seeding production db HOT 1
- Remove `@remix-run/server-runtime` as a dependency HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from epic-stack.