epam-deik-java-dev's People
Forkers
savitar97 krook1024-uni-archive davidhalasz raczandras gsg9hun nraccoon zsoltsch duszka-akos-attila dankozsolti drcsonka dbeni3 astoth czinkem xszbencex gyulaid bczovek fakodominik gtdiablo stoky123 bukovinszkimark ud-flori hajdubence tothferenc98 jancsosz csontosreka gabortodor nxoynie sidlacinagy klnyzzz33 hernyakpisti theignacz biankaanagy osztoszsombor6 pocsimate david240000 szuhi27 vgabor33 laszlosalanki szatmariboldizsar chapye ghjbku kobal123 vakics mankamolnar komlosidavid bercibaa btryx mezeimate mategordos vitkosbence speti-d kvcsmiki darkmiclos tpeterb halaszdd gorzsaszarvak kbence99 roszpapak zplussz35 morpheus97124 johancorn whisky92 lipeczpeti skriemorepam-deik-java-dev's Issues
Use only LTS Java version(s) for the applications
Could we please use only LTS Java version(s) to develop applications in this repository?
Java 12 (non-LTS) is used in the Money application, but the support period of the non-LTS versions is only 6 months, therefore it is not safe.
More information can be found on the page of Oracle Java SE Support Roadmap: https://www.oracle.com/java/technologies/java-se-support-roadmap.html
Make cucumber tests internal to ticket-service
Impacting final > ticket-service
Test sometimes fail even if the program is correct.
Context
The acceptance tests start the app as a process, and latch on to its input/output.
Because of this mechanism, the acceptance tests can fail due to long response time of the process,
or because the cucumber test runner clears the buffer before the command finishes its output.
The README mentions that you can overcome this by fiddling around with the constants, but the values must be set manually, depending on the running machine's capabilities, therefore it is error prone.
Process
mvn clean verify -P requirements-grade2
- verify ends
Expected result
Given any machine regardless of its possible performance, when the code is correct, then acceptance tests pass.
Current result
The tests can fail because of the bad general/IO performance of the running machine.
Possible Fixes
- integrate cucumber tests into
ticket-service
, to run the tests 'internally' without relying on processes (you'll be using SpringBoot anyways...)
Example
implementation of 'ticket-service' with 'internal' cucumber tests
Acceptance tests feature files have possible command typo
Impacting final > ticket-service-acceptance-tests
I rant into what seems to be a typo in the acceptance tests.
Maybe these are intentional, I just wanted to bring them to light.
Context
The command for creating an account is sign up
,
but some acceptance test scenarios use create account
instead.
In the README I wasn't able to find an explanation for this.
This issue only comes up if you run
grade4
orgrade5
tests.
Process
- Implement everything according to README
mvn clean verify -P requirements-grade4
- verification ends
Expected Result
The maven verify should pass.
Current Result
The maven verify fails, because there's no create account
command.
It seems to me that the following files and scenarios are impacted:
movies.feature
@grade4-requirement
Scenario: an authenticated, non-privileged user can list movies
...
And the user types the "create account sanyi asdQWE123" command
...
rooms.feature
@grade4-requirement
Scenario: an authenticated, non-privileged user can list rooms
...
And the user types the "create account sanyi asdQWE123" command
...
Possible Fixes
- Add
create account
key to the keyset of ShellCommand, and mention it in README - Fix the acceptance tests, and replace all occurrences of
create account
withsign up
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.