epam-deik-cooperation / epam-deik-java-dev Goto Github PK

Could we please use only LTS Java version(s) to develop applications in this repository?
Java 12 (non-LTS) is used in the Money application, but the support period of the non-LTS versions is only 6 months, therefore it is not safe.

More information can be found on the page of Oracle Java SE Support Roadmap: https://www.oracle.com/java/technologies/java-se-support-roadmap.html

Impacting final > ticket-service

Test sometimes fail even if the program is correct.

Context

The acceptance tests start the app as a process, and latch on to its input/output.
Because of this mechanism, the acceptance tests can fail due to long response time of the process,
or because the cucumber test runner clears the buffer before the command finishes its output.

The README mentions that you can overcome this by fiddling around with the constants, but the values must be set manually, depending on the running machine's capabilities, therefore it is error prone.

Process

1. mvn clean verify -P requirements-grade2
2. verify ends

Expected result

Given any machine regardless of its possible performance, when the code is correct, then acceptance tests pass.

Current result

The tests can fail because of the bad general/IO performance of the running machine.

Possible Fixes

• integrate cucumber tests into ticket-service, to run the tests 'internally' without relying on processes (you'll be using SpringBoot anyways...)

Example

implementation of 'ticket-service' with 'internal' cucumber tests

Impacting final > ticket-service-acceptance-tests

I rant into what seems to be a typo in the acceptance tests.
Maybe these are intentional, I just wanted to bring them to light.

Context

The command for creating an account is sign up,
but some acceptance test scenarios use create account instead.
In the README I wasn't able to find an explanation for this.

This issue only comes up if you run grade4 or grade5 tests.

Process

0. Implement everything according to README
1. mvn clean verify -P requirements-grade4
2. verification ends

Expected Result

The maven verify should pass.

Current Result

The maven verify fails, because there's no create account command.

It seems to me that the following files and scenarios are impacted:

movies.feature

@grade4-requirement
Scenario: an authenticated, non-privileged user can list movies
...
And the user types the "create account sanyi asdQWE123" command
...

rooms.feature

@grade4-requirement
Scenario: an authenticated, non-privileged user can list rooms
...
And the user types the "create account sanyi asdQWE123" command
...

Possible Fixes

• Add create account key to the keyset of ShellCommand, and mention it in README
• Fix the acceptance tests, and replace all occurrences of create account with sign up