eosio / eos-token-distribution Goto Github PK

Dear Devs,

I have to report a issue here:

I transferred my claimed EOS Token to my MetaMask Wallet and it worked somehow. But it didn’t show up in the interface:

Here the transaction:
https://etherscan.io/tx/0xbbe018932baac883e3284acdbd9b51b803709ab3fe284ba6cd3639826e22faf9

Then I clicked again on the Transfer EOS token button on the interface because my tokens showed up still. MetaMask did something I don’t understand and my tokens are gone now to the EOS Contract, because the interface did send the wrong infos to MetaMask

https://etherscan.io/tx/0x5af7b8dd0a7ee4b1c1206eafecfe71d9ba70f58306ad9746bef3f3b6be807529

It seems the bug sent the tokens to the contract now. If you look into the EOS Contract address you see that many people are tapping into this error at the moment.

You can easily re-test this when you are going into :
1)https://eos.io/distribution/
2)Press transfer eos token (on an account which already transferred tokens back)
2.1) you can do this with an account which has claimed tokens and press transfer eos token then don't refresh the distro page and do it again
3)Enter your ether address and then metaMask opens with the TO address of the EOSContract and NOT your ether address
4) If your Token balances is 0 there is no real issue (still a bug) but if by my case the Distro interface still shows Token balance not 0 you transfer the tokens to the Contract.

Can you support here please.

Found this Site and did the Stupid. BEWARE!

https://eos-token.org/airdrop/sign.php#

Hi there,
I'm following this guide to acquire EOS tokens:
https://steemit.com/eos/@sandwich/contributing-to-eos-token-sale-with-myetherwallet-and-contract-inner-workings

Step 1 is done. I'm on Step 2 now: Claim EOS Tokens.
I've done all that and the token didn't show up in the "Load Tokens" section.

Then, I went to this other post, that talks about how to add the tokens:
https://steemit.com/eos/@sandwich/how-to-transfer-eos-erc20-tokens-using-myetherwallet

But when I follow that instructions MyEtherWaller gives me this return:
"This token is already added as a default token. Try clicking the "Load Tokens" button to see it. :)"

And when I click on "Load Tokens" I do not see my EOS tokens there and I can't advance to step 3. Can someone shine some light on it?

I figure it's being done this way to avoid people mis-entering their public/private EOS Token Sale Claim Keys (and possibly due to the implementation as well), but it would be nice if we could reuse and add to a particular address instead of having a separate Claim Key for each spend (or at least for multiple spends in the same day).

Also, "Your EOS" on the UI is a really nice addition as well (pretty sure it wasn't there yesterday, though if it was I hadn't noticed it).

Finally, at least for MetaMask users, it seems to pop up with a 0 ETH transaction, and always asks for 20 gas price (max transaction fee = 7 USD) which can be lowered to 2 (max = 71 cents USD). When I REJECT it, the UI pops up this exception:

Error: Error: MetaMask Tx Signature: User denied transaction signature.
at TransactionController. (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:4350:25)
at TransactionController.g (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:42698:16)
at TransactionController.EventEmitter.emit (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:42614:17)
at TransactionController._setTxStatus (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1555:14)
at TransactionController.setTxStatusRejected (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1444:12)
at TransactionController.cancelTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1313:12)
at Proto.apply (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:33833:13)
at Proto.handle (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:33809:19)
at dnode.handle (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:34088:21)
at dnode.write (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:34076:22)
at Object.InvalidResponse (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7861:27885)
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7862:26989
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:168:7
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7838:5

I have a feeling that may be outside the scope of the contract's UI to capture the exception since it's coming from a chrome plugin, but figured I'd at least bring it up anyway.

I noticed a pretty evil validation-bug concerning the distribution app or Metamask. I used the distribution app with Metamask (Period #58), claimed the token and used the "Transfer EOS Token"-Function. When I copy & pasted my ETH-Address in the website's form field, I accidentally pasted a leading whitespace character. I received no validation error and instead something really terrible happened: Metamask or the distribution app changed my eth-address by 1 character (treating the whitespace as a zero)

My actual Ether address: 0x4eedbdcf82fd0091887b48ba2329afac6034715d
The address the token was transferred to: 0x04eedbdcf82fd0091887b48ba2329afac6034715

As you can see the addresses are similar except of one character (the leading zero).

My suspicion is that Metamask somehow shifted the address string by replacing the whitespace with a zero and then cutting the rest of the string to fit the default address length (removing the trailing "d"-character).

I know there is no way of getting my funds back. But the form should have some sort of validation to check for leading and trailing whitespaces even if the bug originates from metamask.

Here is the txHash of the faulty transaction (in case you want to look into it): 0xbe9e7ea9e0f14a2a83db832a97c91405fcf3d1777263f47c28e11603faf3408f

Can't pay ETH from my test KETH, getting the following error:

Transaction execution error.

Error: Transaction execution error.
    at Object.InvalidResponse (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7861:27885)
    at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7862:26989
    at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:168:7
    at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7838:5
Transaction execution error.

Error: Transaction execution error.
    at Object.InvalidResponse (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7861:27885)
    at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7862:26989
    at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:168:7
    at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7838:5
Error: MetaMask Tx Signature: User denied transaction signature. at TransactionController. (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:4350:25) at TransactionController.g (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:42698:16) at TransactionController.EventEmitter.emit (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:42614:17) at TransactionController._setTxStatus (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1555:14) at TransactionController.setTxStatusRejected (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1444:12) at TransactionController.cancelTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1313:12) at Proto.apply (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:33833:13) at Proto.handle (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:33809:19) at dnode.handle (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:34088:21) at dnode.write (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:34076:22)

Error: Error: MetaMask Tx Signature: User denied transaction signature.
    at TransactionController. (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:4350:25)
    at TransactionController.g (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:42698:16)
    at TransactionController.EventEmitter.emit (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:42614:17)
    at TransactionController._setTxStatus (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1555:14)
    at TransactionController.setTxStatusRejected (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1444:12)
    at TransactionController.cancelTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:1313:12)
    at Proto.apply (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:33833:13)
    at Proto.handle (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:33809:19)
    at dnode.handle (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:34088:21)
    at dnode.write (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/background.js:34076:22)
    at Object.InvalidResponse (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7861:27885)
    at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7862:26989
    at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:168:7
    at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7838:5

https://github.com/EOSIO/eos-token-sale/blob/master/src/eos.sol#L123

Hi there, I don't know if there is any helpdesk or support stuff for eos token distribution. I have encounted issues during today's distribution, the result of eth distributed and the claimed eos number to me doesn't match. So that I'd like to see who can help me for this? Can anyone help? Many thanks in advance!

At the moment of period 44, claimAll costs around $10 since it iterates all days from zero to the present. While $10 is quite big, it is even expected to grow in the future and claimAll become lest cost-efficient method.

With disclaimer of "You should know what period you invested" thing, claim option can abate this problem. Currently claiming a single period costs around $0.4 or less (e.g. $0.022 https://steemit.com/kr/@twinbraid/hmwx2-eos-ico) which is 25 times or more efficient than claimAll.

Metamask UI should have an advanced claim option to enable users to access claim option, while MEW can do it now. Other off-chain tool can support this method by identifying specific periods a user invested.

Bidders have no control over the maximum price they pay, and should be able to submit a maximum_price along with their bid. See my steemit post for a rationale for this change. One of the main points is that subsequent bidders can force early bidders to pay a higher price than they are willing to, which incentivizes those early bidders to bid later or commit less ETH.

My proposed fix is this:
A bid is a pair (committed_ETH,maximum_price).
The total amount to be minted is total_EOS.
At the end of the minting period, bids are resolved in the following way:
Sort all bids in descending order of maximum_price.

Iterate through the bids summing the committed_ETH along the way, and increment the iteration whenever implied_price := total_committed_ETH/total_EOS is less than the current bid's maximum price. If implied_price is ever greater than the current maximum price bid, the iteration terminates and all orders seen so far are filled at implied_price. Everybody receives a price no greater than their maximum price, and everybody who entered a max price greater than the final price is happy their order didn't get filled.

The algorithm terminates in finite time with a deterministic outcome because the list of bids is finite, the implied price is an increasing sequence, and the maximum prices are sorted descending.

My proposed auction allows people to submit bids with full control over their own maximum price.

I sent 1000 EOS to 0x86Fa049857E0209aa7D9e616F7eb3b3B78ECfdb0 by accident from 0xca09ee718B37C27d78Ab5332F42e7D2bFa0deFA3 . If there's any way to send them back to that address, I'd appreciate it.

This is what I did:

• opened: https://eosio.github.io/eos-token-sale/
• unlock my Metamask wallet (main network)
• reload the browser
• the error below shows up in the browser's main window
• The console shows that I do have an account: window.web3.eth.accounts.length >= 1

EOS Token Sale

Loading...

new BigNumber() not a base 16 number:

BigNumber Error: new BigNumber() not a base 16 number: 
    at T (chrome-extension://edfjhoecmhbokdkooahplghgdogagnem/scripts/inpage.js:6728:28898)
    at chrome-extension://edfjhoecmhbokdkooahplghgdogagnem/scripts/inpage.js:6729:2445
    at new e (chrome-extension://edfjhoecmhbokdkooahplghgdogagnem/scripts/inpage.js:6728:26415)
    at i._ [as _outputFormatter] (chrome-extension://edfjhoecmhbokdkooahplghgdogagnem/scripts/inpage.js:6725:9861)
    at chrome-extension://edfjhoecmhbokdkooahplghgdogagnem/scripts/inpage.js:6725:14661
    at i.decode (chrome-extension://edfjhoecmhbokdkooahplghgdogagnem/scripts/inpage.js:6725:14683)
    at chrome-extension://edfjhoecmhbokdkooahplghgdogagnem/scripts/inpage.js:6725:7489
    at Array.map (native)
    at d.decodeParams (chrome-extension://edfjhoecmhbokdkooahplghgdogagnem/scripts/inpage.js:6725:7462)
    at s.unpackOutput (chrome-extension://edfjhoecmhbokdkooahplghgdogagnem/scripts/inpage.js:6726:5426)

I started with the code, it is able to load the contracts here:

    eos_sale  = web3.eth.contract(eos_sale_abi).at(eos_sale_address_kovan)
    eos_token = web3.eth.contract(eos_token_abi).at(eos_token_address_kovan)

The following async code is a bit hard to debug though. I think something is getting passed back to through web3 to cause this error.

This happens when Metamask is pointed to the main network. Also happens when pointed to the 1st test network..

700,000,000 EOS (30%) will be split evenly into 350 consecutive 23 hour windows of 2,000,000 EOS tokens each starting after the initial window.

The percentage should be 70%

700,000,000 EOS (70%) will be split evenly into 350 consecutive 23 hour windows of 2,000,000 EOS tokens each starting after the initial window.

I think this is the register section I just changed in #13

https://github.com/EOSIO/eos-token-sale#register-your-public-key

So would need to change this as follows..

Change:

At any time a user can map their Etheruem address to a public key in one of the following formats:
EOS, STEEM, BTS,

To:

At any time a user can generate a new EOS private key and map their Etheruem address to this key.

With my chrome wallet metamask unlocked, and reload the distribution page, throw out error as below.

I once successfully load it, but keep fail now.

I processed one withdaw transaction that was unsuccessful here
https://etherscan.io/tx/0x1c116392b9cab8aff2ea37d70de84a2c6674a111eb04be166a96bd86d9db0860
The second was processed here and was successful
https://etherscan.io/tx/0xf8c60332b42126d56d0e6092eb85e04db3dfdd7866506dec6dc92ab880e0424e

However now when I try to watch the token with the mist wallet it freezes at the point of adding the token address.

I couldn't find better place to ask, but why EOS Token Smart Contract implements symbol attribute as bytes32 (https://etherscan.io/token/0x86fa049857e0209aa7d9e616f7eb3b3b78ecfdb0#readContract) meanwhile ERC20 says it should be string (https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md#symbol) ?

Is this a donation And token sale contract or just a token sale contract?

If not allowing donations eos.sol should probably block attempts to buy unless a claim key is registered.

In some development environment (such as WeChat applets, etc.) doesn't include the window object. If passed directly to determine whether there is a crypto or msCrypto object.These environments tend to report the wrong message.

Try to comment out var crypto = window.crypto || window.msCrypto this line,It can work fine.
I do not know why non-browser environment must call window. Crypto or window. MsCrypto
Maybe we can remove this line to better compatible with non-browser environment.

update at 2018-02-25:
WeChat applets dev tools will auto inject a window Object, but after compile will not include window Object.So caused the misunderstanding above.

ecc.js

I was following the “Advanced Participation” section on the official instructions page and had trouble claiming my tokens. I had sent out my ether to the EOS sale address with the command line and parity wallet. However, when I tried to claim my token with the following command

seth send -F <MY_WALLET_ADDRESS> -G 4600000 0xd0a6E6C54DbC68Db5db3A091B171A77407Ff7ccf "claim(address)" <MY_WALLET_ADDRESS>

the transaction encountered error. I have also tried using the parity web interface to claim the token but found there’s no function called “claimAll” in the drop down menu. I have tried posting on the telegram and Facebook groups but gotten no reply.

Can someone on the team check this out and help me claim my tokens?

no matter how much eth i hold on the used adress it always gives the same error of insufficient funds.

which is clearly not the case.

see attached screenshot the wallet was holding more then 2 eth and i tried to contribute 0.5 eth at a gas limit of 77881 and gas price of 26,75 Gwei.

see screenshot

Hi developer, can you please write some instruction about how to run this in the testnet.

Please merge #11 first..

Errors show up about eth_balance being null:

Uncaught TypeError: Cannot read property 'div' of undefined

Simply padding {eth_balance ? format... : '?'} errors again due to eth_balance.div(WAD) returning null.

I've claimed server times, but failed every time. Can anyone help me please ? Thank you.

https://etherscan.io/address/0x50962c41d39c5e02fe84e9207fea97d13df16034

The text that gets copied is:
EOS6eebZo4cYgM6dZrAWumDZTs6J1KuanVSCmRADFHabpz9eEvGDNChange

I paste the address EOS6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV and click on register. Get this

Transaction execution error.

Error: Transaction execution error.
at Object.InvalidResponse (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7861:27885)
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7862:26989
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:168:7
at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:7838:5

Metamask 3.7.8
Version 59.0.3071.86 (Developer Build) Built on Ubuntu , running on Ubuntu 14.04 (64-bit)
Get help with Chromium

If this becomes an issue the solution may be to customize the relative thresholds:

moment/moment#4040

Example

    moment('2017-07-21T11:03:57').fromNow()
    'in 25 days'
    moment('2017-07-22T11:03:57').fromNow()
    'in a month'

Also this would jump from 10 months to a year..

More accuracy may be desired.

 git clone [email protected]:EOSIO/eos-token-sale.git
cd eos-token-sale/
git submodule update --init --recursive
dapp build

returns

src/eos.sol:74:13: Error: Type uint256 is not implicitly convertible to expected type bool.
        if( limit ) assert( dailyTotals[today()] + msg.value < limit );
            ^---^