Move web socket upgrade config to route about gateway HOT 9 CLOSED

@arkodg @zetaab with the fix it now works very well. Thank you for fixing this The number of files touched though seems to be on the very high side.

from gateway.

@arkodg ideas how this can be configured? I am thinking that can be this enabled by default? Is it wrong to configure it everywhere by default https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/http/upgrades

if cannot be enabled by default, which is the correct place to configure that? BackendTrafficPolicy?

from gateway.

@zetaab we do enable web socket upgrades by default

from gateway.

@pitabwire do you have a GRPCRoute attached to the same listener 😄 ?

from gateway.

Yes @arkodg I have Grpc routes in there. Indeed removing them the websocket service works now. We however need them utilizing the same listener can they be made to coexist?

from gateway.

afaik upgrades are not allowed for gRPC, but since the filter chain is the same (since the hostname is same as well as port), there is no way to disallow for gRPC traffic, but allow for http/1.1 afaik

from gateway.

nvm, this is fixable, by moving the websocket upgrade config from hcm to route
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-msg-config-route-v3-routeaction

from gateway.

thanks for fixing the issue @zetaab !
@pitabwire can you confirm that the issue is fixed ?

from gateway.

@arkodg @zetaab with the fix it now works very well. Thank you for fixing this The number of files touched though seems to be on the very high side.

yeah, they are testdata files

from gateway.