Code Monkey home page Code Monkey logo

Comments (2)

arkodg avatar arkodg commented on June 12, 2024 1

thanks for finding this one :)
I'd vote for reset at the API level since it keeps all EG to Envoy docs 1:1 for this feature
https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/router_filter#x-envoy-retry-on
and imho disconnect and reset kinda mean the same thing
@envoyproxy/gateway-maintainers can you chime in as well

from gateway.

guydc avatar guydc commented on June 12, 2024 1

thanks for finding this one :) I'd vote for reset at the API level since it keeps all EG to Envoy docs 1:1 for this feature https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/router_filter#x-envoy-retry-on and imho disconnect and reset kinda mean the same thing @envoyproxy/gateway-maintainers can you chime in as well

Yea, I see your point about consistency here. I changed the interface as well in a new commit. Let's try to get it in before v1.0.0 to avoid breaking the API later.

from gateway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.