I got error missing argument: in Contract constructor
Does anybody know what is the problem?

Premium currently decays linearly. We need to write a function so decay exponentially with the formula:

P = SP ^ 0.5 ^ T, where P = Price, SP = Starting Price, T = Time since expiry.

We have a number of static calls to other contracts such as the registrar that fetch well known data like the base node or ENS contract address that we can remove.

There are also more sophisticated options we can take:

• We can ask the user to approve the controller to act on their behalf with the registry, which would mean it could register the domain directly to the eventual owner but still call setResolver on the registry, instead of the current solution which requires temporarily transferring ownership to the controller during the registration process.
• For registering wrapped domains, we could ask the user to authorise the controller on the wrapper, so it could do the same as the above.

There is only one (not many) token for each token id in Name Wrapper contract, why use ERC-1155 instead of ERC-721 for Name Wrapper?

ERC-721 is simpler than ERC-1155, and I think using ERC-721 is enough for Name Wrapper.

After cleaning the ENS TextChanged event log, I found that it is impossible to determine which ENS this Text belongs to based on the log.

Is there any solution to this problem?

Related event log link: https://etherscan.io/tx/0x5551e94d827a52eaf4a2da30c60fd5fecd2890fa95ae922fe5ebebe96855113c#eventlog

Does anybody know what is the problem?

in /ens-app/

ganache-cli -> ok
yarn run preTest -> ok
yarn start:test -> error:

/ens-app/node_modules/deepmerge/dist/cjs.js:67
	} cat
	^

SyntaxError: Missing catch or finally after try
    at new Script (node:vm:100:7)
    at createScript (node:vm:257:10)
    at Object.runInThisContext (node:vm:305:10)
    at wrapSafe (node:internal/modules/cjs/loader:1020:15)
    at Module._compile (node:internal/modules/cjs/loader:1069:27)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
error Command failed.
Exit code: 1
Command: /usr/local/bin/node
Arguments: scripts/serve.js start
Directory: /Users/one/vue3/ens/ens-app
Output:

info Visit https://yarnpkg.com/en/docs/cli/node for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.

... allowing us to ditch the separate bulk renewal contract.

https://github.com/ensdomains/ens-contracts/blame/b5938b1a2e0ef180d559c655bd69f5008f4b4a6e/contracts/subdomainregistrar/ForeverSubdomainRegistrar.sol#L17

After the ENS FusesSet event log has been cleaned, it is no longer possible to retrieve the current value of the fuse change from the log.

Is there any solution to this problem?

Related event log link: https://etherscan.io/tx/0xf0d11296e8954146a7e7e21ce2f17f120b72af134194412931bb4402487dcab4#eventlog

The TextChanged event contains the key as both indexedKey and key unindexed data. It is emitted here:
emit TextChanged(node, key, key);

Would it make sense to also emit the value, so that one can track and gather the set values from events

We should modify the controller to support wrapping domains at creation time. It may be possible to structure this so as to also reduce the number of redundant transfers requried to configure the domain.

Hello,

Could you please explain why don't we support 1-2 characters now? In theory, I think it's possible and I found it on the smart contracts. So, could you explain?

Thank you.

Hi,

New version available on npm is 0.0.12 has index.js which is exporting baseRegistrar and PriceOracle but there is not such contract exists. If person try to use this version, application never run.

One option for this would be to integrate a router such as the uniswap router, so users can pay in any currency.

In DNS services it is possible to use multiple TXT entries with the same key. This is useful to implement an array-like structure for text records. It would be very helpful if ens would also support multiple Text entries per key.

(Once the new reverse registrar has implemented trusted controllers.)

some of algorithm contracts are deployed successfully. But

ISSUE
The node version in .nvmrc does not work on Mac OS. Error ( package [email protected] requires node >= 14.16.0) is thrown while trying to install packages with yarn.
SOLUTION
I would suggest updating the node version in .nvmrc to v16.15.1.

Full cli trace:

ens-contracts ➤  yarn install
yarn install v1.22.19
warning ../../../../../package.json: No license field
[1/4] 🔍  Resolving packages...
warning Resolution field "[email protected]" is incompatible with requested version "js-sha3@^0.5.7"
warning Resolution field "[email protected]" is incompatible with requested version "js-sha3@^0.5.7"
warning Resolution field "[email protected]" is incompatible with requested version "[email protected]"
warning Resolution field "[email protected]" is incompatible with requested version "[email protected]"
warning Resolution field "[email protected]" is incompatible with requested version "js-sha3@^0.5.7"
warning Resolution field "[email protected]" is incompatible with requested version "js-sha3@^0.5.7"
[2/4] 🚚  Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=14.16". Got "14.15.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

I wrapped my domain to the wrapper, then extend the domain's expiry date on ens.domains, but the expiry date in the wrapper is not updated. When will the expiry date be updated? Or must I renew the domain on wrapper?

function _consumeCommitment(
        string memory name,
        uint256 duration,
        bytes32 commitment
    ) internal {
        // Require a valid commitment (is old enough and is committed)
        require(
            commitments[commitment] + minCommitmentAge <= block.timestamp,
            "ETHRegistrarController: Commitment is not valid"
        );

        // If the commitment is too old, or the name is registered, stop
        require(
            commitments[commitment] + maxCommitmentAge > block.timestamp,
            "ETHRegistrarController: Commitment has expired"
        );
.....

Apparently, the first require assertion can not check whether the commitment is committed or not because the solidity map ping supposes that every key of the mapping exists with the default zero value.
Luckily, the maxCommitmentAge in the second require assertion is small enough so that if a commitment is not committed it will always throw the error.
If other projects forked ens and initialized maxCommitmentAge with a very big value, then the _consumeCommitment validation is escaped.

Public resolver should return address of node owner from ENS contract if it's not already set.
That'll save users from one tx/gas, and users can change their addr anytime.

I'd send a PR but ENS isn't available in resolver base && I don't want to make a mess around. 🙏

     function addr(bytes32 node) virtual override public view returns (address payable) {
        bytes memory a = _addresses[node][COIN_TYPE_ETH];
        if(a.length == 0) {
            return payable(ENS.owner(node));
        }
        return bytesToAddress(a);
    }

I am working on a fork of ens-contracts and the goal is to support multiple TLDs like .eth, .btc, etc can this be done on the current version of contract and is there any guide to do so

How would i get batchgateway urls and change the ownership of resolver.eth to deploy the contracts as I am getting errors

I noticed that ownerOf and getData in INameWrapper are declared as "external" (without view). Why not change them to "external view"?

I was just checking the newish OffchainDNSResolver contract, and there seems to be an unhandled failure in the OffchainDNSResolver when a user includes an invalid resolver address as part of their DNS record.

As far as I understand, the root problem is in the way OffchainDNSResolver::parseAndResolve attempts to parse the user-provided value to an address.
Whatever value is passed in the nameOrAddress parameter, as long as it starts with 0x, it will be passed down to the HexUtils::hexToAddress function. Where it will attempt to cast it to an Ethereum address. Internally, this function never checks whether the length of the supplied data is longer than an address. It just casts it to a bytes32 value, and then to address.

As an example, the string 0x00FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF00 would be considered to be the address 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF00. This means that OffchainDNSResolver::parseRR would return a non-zero address (which is interpreted as a signal for a valid record found) and the name would try to be resolved calling the 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF00 account.

If the called account happens to be empty (most likely the case if the record was just set incorrectly due to a user's oversight), then execution is reverted with error "function returned an unexpected amount of data" instead of the more gracious CouldNotResolve(bytes) error. This is because the call to IERC165(dnsresolver).supportsInterface(...) is using the explicit cast to the IERC165 interface, which is always expecting a boolean in return - reverting otherwise.

Perhaps the code could be changed to fail earlier. Non-addresses shouldn't be silently parsed as addresses.

Once that's fixed, we'd be left with the scenario where the user sets a valid address in the record, but that address corresponds to a custom resolver that does not follow IERC165. If you want to support that case (which appears to be so, given this fallback-like staticcall), then instead of explicitly casting to IERC165 you might want to consider using the ERC165Checker lib or anything similar that does not revert, but instead allows you to explicitly handle errors when querying unsupported interfaces.

hello.

I am a junior developer interested in ens.
Also, I apologize for writing the email through a translator because I am not good at English.

While analyzing the ens contract, I am making issue because I have a question.

When using reverseRegistrar 's setName , is it intended to be able to change the primary name without checking ownership of Name ?

If it's not intended, I think it can cause confusion in reverse lookups. (Even if it's handled by the frontend.)

Links to related transaction hashes are noted below.
https://etherscan.io/tx/0xd7259c295158bdeff065b12587cba4283630754de6d9808e98605d6361f20fcd

In /test/resolvers/TestPublicResolver.js the interfaceId for IDNSZoneResolver is '0x5c98042b'

  assert.equal(await resolver.supportsInterface('0x5c98042b'), true) // IDNSZoneResolver

But in /deployments/mainnet/solcInputs, the interfaceId is '0x5c47637c'

DNS_ZONE_INTERFACE_ID = 0x5c47637c;

Also when checking if the resolver contract supports the interface the following addresses fail for both '0x5c98042b' and '0x5c47637c'

• '0x4976fb03C32e5B8cfe2b6cCB31c09Ba78EBaBa41'
• '0xdaaf96c344f63131acadd0ea35170e7892d3dfba'
• '0x226159d592e2b063810a10ebf6dcbada94ed68b8'
• '0x1da022710df5002339274aadee8d58218e9d6ab5'

https://github.com/ensdomains/ens-contracts/tree/master/contracts/wrapper#checking-if-a-name-is-wrapped

OwnedResolver currently has no tests. We could have tests to make sure

• Test that the owner can change records
• Test that no other account can change records

When registering a name, it should be possible to preconfigure any key at all.

This will require either deploying individual resolver proxies for each user, or doing access-control by checking the node on each nested call is one the caller controls.

Looks as if there's a problem with this hardhat-waffle package.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: @ensdomains/[email protected]
npm ERR! Found: @nomiclabs/[email protected]
npm ERR! node_modules/@nomiclabs/hardhat-ethers
npm ERR!   dev @nomiclabs/hardhat-ethers@"npm:hardhat-deploy-ethers@^0.3.0-beta.13" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @nomiclabs/hardhat-ethers@"^2.0.0" from @nomiclabs/[email protected]
npm ERR! node_modules/@nomiclabs/hardhat-waffle
npm ERR!   dev @nomiclabs/hardhat-waffle@"^2.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

It only took 4 years!

• ensdomains/ens-app#1535
• ensdomains/dnsregistrar#10
• ensdomains/dnssec-oracle#54

This is a single label decoder — string → do nothing, decode, or revert (invalid punycode)

https://goerli.etherscan.io/address/0xaf7f1fa8d5df0d9316394433e841321160408565#code

Hello, I tried to use ENSDeployer.sol in https://docs.ens.domains/deploying-ens-on-a-private-chain to deploy but got an error：
TypeError: Wrong argument count for function call: 2 arguments given but expected 4. --> contracts/ENSDeployer.sol:25:22: | 25 | publicResolver = new PublicResolver(ens, INameWrapper(address(0))); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Then I check this contract in your npm repo， the construct of PublicResolver is :
constructor( ENS _ens, INameWrapper wrapperAddress, address _trustedETHController, address _trustedReverseRegistrar )
I wish I could use ENSDeployer.sol to deploy ens .Txs

Here's an outline:

interface ENS {
    function resolver(bytes32 node) external view returns(address);
}

contract UniversalResolver {
    ENS ens;
    
    constructor(ENS _ens) {
        ens = _ens;
    }
    
    function multicall(bytes[] calldata inputs) external returns (bytes[] memory ret) {
        ret = new bytes[](inputs.length);
        for(uint256 i = 0; i < inputs.length; i++) {
            (, bytes memory result) = _resolve(inputs[i]);
            ret[i] = result;
        }
        return ret;
    }
    
    fallback (bytes calldata input) external returns (bytes memory _output) {
        (bool success, bytes memory result) = _resolve(input);
        if(success) {
            return result;
        } else {
            assembly {
                revert(add(result, 32), mload(result))
            }
        }
    }
    
    function _resolve(bytes memory input) internal returns (bool, bytes memory) {
        require(input.length >= 36, "Input too short");
        bytes32 node;
        assembly {
            node := calldataload(add(input, 36))
        }
        address resolver = ens.resolver(node);
        return resolver.call(input);
    }
}

We should deploy this using some kind of CALL2 deployment stub that ensures the same address on all chains - need to check if there is already one in widespread use. We can then give the contract a name such as universalresolver.ens.eth.

I set up env params before. I can not move forward.

Changes to the price oracle to add duration() so we can query for how long a domain can be registered for based on ether value.

This package depends on @ensdomains/ens-buffer which seems to accidentally depend on @nomiclabs/hardhat-truffle5: this should be a dev dependency but is installed as a normal dependency. As a result, a huge number of dependencies gets installed, totalling 200MB on disk.

I opened ensdomains/buffer#21 but I'm raising this here because this package is affected and it should be fixed asap.

• Reverse record auto set as a parameter
• Name wrapped automatically on registration
• Allow arbitrary records to be set on registration
• Registration event split between premium/base cost
• Remove refund and adjust registration to ether given
• Make all config variables immutable and compare gas cost