Code Monkey home page Code Monkey logo

gapvis's People

Contributors

enridaga avatar nrabinowitz avatar ponteineptique avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

gapvis's Issues

Improve README.md

It should include at least:

  • how to install/use it
  • specification of the data API to implement

"Map isn't screwed up" tests failing

Don't know why, this single test does not pass even if I can test it correctly on the live page:

    test.assertEval(function() { 
        return gv.app.currentView.slots['.right-panel'].slots['.top-slot'].markers[0].map.getZoom() > 0
    }, "Map isn't screwed up");

Hestia customizations

We need to pack a customized version for the hestia project.
Todo list:

  • Use Hestia Brand
  • Top links to point to the Hestia project
  • Remove the "published date" note
  • Remove the section "Book references" if empty on the place page
  • Place page, rename "Ch. (?):" to "Bk (?) Chapters:"

automatic map zoom to places

Is there an easy way of getting the map window to automatically zoom in on the places mentioned in the text in the "reading view"? At the moment, the automatic zoom is for the entire world, which is obviously irrelevant

Perseus section references

I was certain I'd seen a version of HestiaVis where the text chunks were linked to the appropriate Perseus sections. The scripting has clearly been adapted -- in Eric's version, the link is just to the Perseus text citation, but I can see that the current Perseus link includes both book and chapter. But now, in both the OU version and the version on your repo, we're back to all links leading to the first section of the first book in Perseus, which is not that useful. It would be much better to go directly to the same section -- and if this scripting was already done, not too difficult, right? Or am I misremembering?

final hestia touches: zoom buttons on the map in the reading view

I had comments from both high-school and college-level students this semester that they couldn't figure out how to deal with zooming in and out on the map without the aid of a +/- zoom button of the familiar sort. Double-left-clicking in and double-right-clicking out was not intuitive for them. Would it be possible to add zoom +/- buttons at one corner, even if it costs a little real estate on the map?

Prepare Dist

Actually the production build is placed in the root project.
It would be nice to have it in a separate folder, ready to be zipped and pushed as release

Make tests work (casper error....)

It may be a configuration issue, or it is due to incompatibilities with the new version of casper.js.

Message is:

run-tests:
[echo] Running tests
[exec] CasperError: casper.test property is only available using the casperjs test command
[exec] /Users/Shared/casperjs/modules/casper.js:172

Customize "View on Google Books" link

For example, in case of Hestia the link should be to Perseus (where we got the Herodotus text from), not to Google books (in this instance).

This means that we need it to be part of the customization.

Layout easily breaks on window resizing

When the user has a window smaller then the given fixed height, half of the UI is unreachable. At first sight, there is some fixed height + absolute positioning which is not really needed. Removing them and adjusting the related css properties should do the job.

final hestia touches: Flickr stream

I notice that the slim number of images that are coming in from the Flickr stream may be related to a narrow interpretation of the machine tags. In Argos (http://enridaga.github.io/gapvis/gap2/#book/1/place/336), for example, only 5 of 18 available images are coming in, because only those tagged with pleiades:place are pulled. But the set of Pleiades machine tags in use includes pleiades:depicts and pleiades:findspot and several others that you can find here: https://www.flickr.com/photos/tags/pleiades:*=570106. All of them use the same URI ID number. Could the search be changed from pleiades:place= to pleiades:*=? to capture all the available tagged images? Among other things, this would bring in objects that the Open Learn team seems to be very interested in.

Histogram: longer place names disappear under the map window on the left

While we're fixing the histogram, can we push it to the right if there's space? Right now several of the longer place names disappear under the map window on the left, but I see a lot of white space to the right of the numerical reference count along the right border.

A separate and even more minor issue: the link to "View on Perseus" (which we're updating to jump to the book/chapter, right?) currently reads "View on View on Perseus".

Upgrade to Bootstrap 3

The current code base relies on bootstrap 2.* as basic css framework, and has a dependency with the less sources. These do not compile with the last lessc (now 1.5.0) . It is quite hard to stay with bootstrap 2 for this reason.
In general I think it is a good idea to upgrade dependencies to the latest versions.

hestia migration: what do we do about token correction

@enridaga @ekansa: I found it really useful to have Eric's token-correction page, and I think there's more work to be done here (for example, to associate Olbia with elliptical spatial phrases like "city of the Borysthenites": http://gap2.alexandriaarchive.org/report/token-issues/117172). I can see that the Pleiades associations I updated are reflected in Enrico's version, which will be the one that moves to the production server. Is there a way to preserve the token-correction interface that Eric built, so that I can continue to use that? Right now the call-out for a site in Enrico's version takes the user directly to Eric's token page, but presumably we either want this behind a login or we want to kill the issue-reporting button and just maintain Eric's correction page (as long as it's feeding corrections back into the main tokenized text).

I'm going to cross-post this issue in Eric's repo as well. I don't understand the dynamics well enough to know how hard or how easy this is -- and if I haven't explained it well, please don't hesitate to ask for clarification.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.