enormego / cocoa-helpers Goto Github PK

Searching the allKeys array will have linear performance degradation with the size of the dictionary since it has to check each item in the array sequentially - checking if [dictionary objectForKey:key] == nil has constant time performance regardless of array size and would be a much better implementation.

./UIImage/UIImageHelper.m:103: error: 'ctx' undeclared (first use in this function)

After updating to the current revision, I got that error while compiling. I can't find the declaration of ctx in the project either. So perhaps this wasn't intended and should probably fixed.

There're a couple of occurrences where you use something like LocalizedString(@"foo...") which uses three dots. Since we're able to use UTF8 everywhere, it's better IMHO to use a ligature for that like … ( it's shortcut is Alt+; on the US layout).

It's a more cosmetic issue but, I think it looks slightly better.

There's an issue in UITableView/UITableViewHelper.m:36 with

UITableViewUpdatingView* view = [[UITableViewUpdatingView alloc] initWithFrame:CGRectMake((int)((self.frame.size.width-130.0f)/2), UPDATING_OFFSET_Y, 130.0f, 42.0f) title:title];

When you're not on an english system and the localized string is wider than »Updating...« (in german it's for example »Aktualisieren…«) the overlay view gets messed up. This because of the fixed width here of 130.0f.

I'm not an expert with using #define, but I had to import NSStringHelper into NSDateHelper in order to remove the warnings around finding the definition for LocalizedString.