Code Monkey home page Code Monkey logo

enhance-element's People

Contributors

konnorrogers avatar kristoferjoseph avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

enhance-element's Issues

Element styles are not hoisted + scoped/deduped

When rendering multiple instances of an SFC on the client via Enhance Element, the element's styles are not deduped or hoisted & scoped. Instead, each instance of the element is rendered with a duplicate <style> block, where the contained styles are not scoped to the element.

One option could be to simply strip the element's <style> block (if present), however this would preclude using Enhance Element for a strictly client side element with styles.

Another option could (maybe?) be to check for an existing style block and only strip it from the client instance(s) if one is present in the document head.

Further discussion likely required but wanted to flag this early! :)

Discussion re: an example of this + a link to a temporary fix can be found in the issue mentioned below.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.