engaging-computing / android Goto Github PK

Saved prefs should never be used to pass data from one activity to another activity in the library! Thats what intents are for! Code like this exists randomly throughout the isenseimports library and is causing problems with the new apps.

String fromWhere = extras.getString("from_where");
        if (fromWhere != null) {
            if (fromWhere.equals("manual")) {
                PROJ_PREFS_ID = "PROJID_MANUAL";
            } else if (fromWhere.equals("queue")) {
                PROJ_PREFS_ID = "PROJID_QUEUE";
            } else if (fromWhere.equals("welcome")) {
                PROJ_PREFS_ID = "PROJID_WELCOME";
            } else {
                PROJ_PREFS_ID = "PROJID";
            }

        } else {
            PROJ_PREFS_ID = "PROJID";
        }

Right now, you can boot up Motion, choose the GPS preset, record a data set, and upload it, and have no lat/lon data present.

E.g., look here: http://isenseproject.org/projects/13/data_sets/12258

This is broken, and Google doesn't even know how to zoom the map properly (in my Chrome at least).

May I suggest the following spec:

If the app is set up to record lat/lon, and there is nothing from the GPS available, that row should be discarded.

Then we won't get these buggy uploads.

All I want to do is record data for project 850 on dev. So why does the notification bar say "iSense DataWalk" when I begin recording data? That seems like a bug.

I realize I have played with the "Presets" menu option (I had no idea what these were, so maybe this bug is that this part isn't obvious as to what it does).

See attached...

For example, rSENSE-dev currently only has 912 or so projects. I entered 950 by accident, and it said the sensors were successfully enabled for this project and let me begin recording. Since the project doesn't exist however, the data doesn't upload successfully and the summary at the end of the QueueUploader session says "Not Found" (as it should).
Maybe Motion can implement some sort of error checking when we pull project fields down to ensure the project exists and we got fields successfully?

This is a post-release bug fix, so don't worry about it for now.

E.g., see http://isenseproject.org/projects/614/data_sets/8383

This is a live data set from a teacher who discovered iSENSE via the article in Science Teacher.

I would really like this fixed. Those points should not be recorded.

"I discovered today that you cannot type various special symbol characters (e.g. ! or ? ) into the password field of the Data Walk credential manager!

Would someone please look into this (Bobby)?

A teacher was trying to upload a dataset from Data Walk. I didn't know the contributor key, and all the teachers had made accounts, so I told them log in with their uname/pwd.

This teacher couldn't because his password included an exclamation-point, and the app won't let you type it!"

--Fred

based on today's conversation (Fred, Bobby, Jim, Tyler):

the big picture

• Car Ramp Physics gets renamed iSENSE Forces
• Canobie Lake app goes away (gets replaced by iSENSE Forces)
• Uploader keeps its name, but only does manual entry (loses ability to record and later upload data sets)
• remove feature to pick project by QR code from shared libraries. Users must key in project ID.

about iSENSE Forces

• get rid of feature to do linear acceleration (too confusing)
• gets UI improvements from current Data Walk
• functionality of Canobie Lake (choosing ride names) can be handled by either having user rename data sets after going on ride, or by pre-configuring app to send data to a ride-specific project beforehand.

about Uploader

• expects internet connectivity, because it will dynamically retrieve project info from server and post results one data at a time as used
• grabs fields from project and lets users manually enter data
• provides UI elements for manually entering data based on restrictions on those field; e.g.:
  ** numeric fields will pop up numeric keyboard
  ** text fields with constraints will provide pick-list / drop-down menu widget
• will get date/time and location info from device if specified in project
• Upload Button will enable only when data are provided for all fields (with buried menu option to turn this off in case necessary for certain projects)
• after each data set is uploaded, fields are cleared for next time

@ivanrudnicki finally you win :) I think we are all happy now

Right now if you try uploading data from Motion without being logged in, it directs you to a Contributor Key dialog. How about it directs you to a dialog that allows you to either login or enter a contributor key, then dispatches to the correct dialog from here?

This is a post-release enhancement, don't worry about it for now.

When I go to browse projects and select any project, in dev mode or not, the app crashes.

This is a bug that should be fixed in Pictures pre-release.

• After I switched to dev mode, I tried entering project 850 manually and by search. No matter which I do, when I hit OK to select that project, it says the sensors were registered for project 13
• When I created a new project in the app (ended up being ID 865), the ID did not appear in the "Enter Project ID" text field. I had to cancel the dialog. When I reopened it, 865 appeared there, but once again, this project "13" got magically selected

• Create project force crashed (maybe because I didn't enter units)
• If the fields in a card are just long enough to require scrolling with the Save/Add Data Point visible, but small enough to no longer need scrolling once those buttons disappear, the buttons are gone forever
• If the last textfield in a card is selected and we try to scroll up, the screen twitches
• Needs a new Dev switch now that the action bar no longer supports icons

Dialog themes tend to be more frowned upon now in the world of Android. Simply switch this to a full screen activity layout and refactor the UI to fit as necessary.

Text should read:

Reset iSENSE Motion to its default settings?

Motion doesn't ask for location updates until the user begins recording data - this is good.
However, once done recording, my Nexus 5 indicates it is still collecting location data. It should probably unregister this location listener when the user stops and reenable it when the user starts again to conserve battery.

This is a post-release enhancement, don't worry about it for now.

If you choose GPS, and then go back into the preset, it should still be set in GPS.

Looks like Motion only allows 15 or so characters in the first name. In the unlikely event people want to use a data set name instead of first name and try typing it here, we may want to allow more characters (e.g. 45 or so).

This a post-release fix, don't worry about it for now.

please remove it.

Also, for me it's displaying the same value as deg C

Because velocity is a vector, and we're recording a non-directional thing.

This would be when you create a project using the app: it should allow you to choose "Speed" as a field.

The icon on each card looks silly because they're being stretched out.

• Notification icon is White on L
• Button makes noise for Hold to Start, but not when it stops automatically
• There are different font sizes on the "Select a Project" dialog

When all the data is entered, the keyboard's "next" button should become a "done" button.

Landscape layout of Writer isn't really optimal. Should have, for example, dataset name/add data point/save controls on the left side of the screen taking up ~35% space, and have the data cards on the right side taking up the remaining 65% of the horizontal space.

This is a post-release enhancement, don't worry about it for now.

I used iS Motion to record a data set with 71 points.

Then I created a new project from the app - project 810, with all sensor fields.

Then I uploaded my data set to it. The app said it was successful. But when I go to the web, no data sets exist at my new project: http://isenseproject.org/projects/810

Argh.

When collecting the data, I had been attached to Project 13. Is that the problem?

"delete" is right next to "rename" in the data set manager dialog.

If you accidentally hit delete, boom, your data set is gone.

It should have a confirm dialog. "Are you sure? Yes, delete. No, cancel."

If I tap the notification in the notification bar while recording data, it starts a duplicate activity. Pressing back on that activity quits the new activity and returns me to the original. Overall, a new activity should not be started, but rather the old one resumed.

(formerly called Velocity)

Right now, if you preselect a project that includes Speed and Distance fields, Motion will record to them.

But, we want the app to record these data for the Generic Project, so that you can upload them to a project later.

Hi. There is a bit.ly link in a publication that points to:

https://play.google.com/store/apps/details?id=edu.uml.cs.isense.datawalk_v2

(the link is http://bit.ly/12tpJGn)

We need to have something at the destination URL on Play.

I suggest republishing the datawalk_v2 app, and updating the description of it so that the first bit of text gives a pointer to the Motion app.

It captures data using either GPS and/or accelerometer.

Suggestions so far are:

iSENSE Data
iSENSE Motion
iSENSE Recorder

@ivanrudnicki @bdonald25 @AlanRosenthal

I just tried it, data set at http://isenseproject.org/projects/13/data_sets/7446

None of the data points have Latitude.

Also, when using GPS, probably it shouldn't record a point unless it has both lat and lon.

Steps to reproduce:

1. Choose a project on rSENSE with a timestamp (I used 851).
2. Save a row of data.
3. Upload the data.
4. Note how iSENSE timestamp says something like 1 Jan 9 0:00:00 GMT

Screenshot:

When you start recording in iSENSE motion, a notification shows up in the recording bar. For some reason, it looks really bad. It might have t do with the scaling of the icon being used. Perhaps you need to make a small recording icon.

@ivanrudnicki @AlanRosenthal

First read #14.

Then Bobby proposed:

I believe Data Walk and CRP should be merged too. They are both currently capable
of recording the same fields with the new Data Field Manager. (the project determines
what fields are recorded) 

CRP
-Records for a set time
-Does not support recording with screen off

Data Walk
-Push to stop
-Records in Background

If I added an option for "push to stop" and the ability to record with the screen off to CRP,
they would be the same app. The project would just determine what the use case is.

CRP has a menu option for recording length. I would just add an option for "Push to Stop"
there and that would eliminate the need for a separate app.

Fred replied:

There is the issue of it being easy to use for one application or the other.

Which is a matter of pointing it at a GPS project or an acceleration project.

And possibly setting some data gathering params (duration; rate).

I could imagine something where the opening screen lets you choose from one two
preconfigured settings, which would set the other params appropriately?

What happens when you open the app and there's no internet connectivity --
can you still meaningfully record data?

Bobby replied:

I am adding the ability to select a project later, which will record data using all possible
sensors. That will cover both use cases.

The only params needed are the duration, rate, and project. Two preconfigured settings
is a good idea.

Fred replied:

“Make it so.”

After recording data with a project ID, you can't change the data to upload to a different project. If the original project number is incorrect or not a real project, then the data can't be uploaded and is stuck on the device. I noticed this using a Nexus 7. Also, at the iSENSE event at MIT a few weeks ago, various people encountered the same problem on their own devices.

Steps to reproduce:

1. Make a data set.
2. Open the upload dialog and deselect it.
3. Close the upload dialog.
4. Reopen the upload dialog and notice that it says 'deselect all' instead of 'select all' when no data sets are selected.

When you reach the end of the sensor display, either:

• it should wrap in a circle, so (e.g.) if you press right-arrow on Luminous Flux you'd get to Acceleration

or

• the right-arrow should be dimmed.

Similarly for left edge.

I'd prefer infinite circular wrap... or maybe, an animation where you realize that you've been brought back to the beginning / end.

I just D/L'ed the Data Walk app and opened it.

It's set to Project 5. This is a hurricane project.

We created a new project. It now should default to Project 569.

not "miliseconds"

in pop-up Rate menu

should be "ms"