enfogroup / sniffles-cdk Goto Github PK

The alarms are currently created using functions, replace it with Constructs

Expose the functions so the necessary access rights can be granted by the consumer

We should add constructs for adding the necessary statements to a KMS Key's resource policy or even constructs for defining these keys. Having to define them from scratch is quite annoying.

I think a dual approach of lazy lookup and documentation is needed here:

• Change code so it only performs a lookup if needed
• Mention under "Gotchas" that if the Key has not been defined then you get an error. Easy to fix by creating a Topic with built-in encryption and then deleting it

Attribute on the OpsGenieForwarder construct, if set should log the event and that it has forwarded it.

Currently the log subscription lambda runs every X minutes and aggressively tries to put a log subscription. I think we can be a bit smarter:

• Trigger the function whenever a new Log Group gets created and check if it matches the regular expressions
• Trigger the function whenever the SSM Parameter holding the regular expressions gets updated. This would rerun the logic on all groups
• Add some wait time in between the put attempts, it is far too easy to hit a 409 at the moment

If a user wants to reapply the subscriptions they would simply have to rerun the second function.

Without esbuild the bundling needs to be done using Docker. Add it as a peer dependency?

Almost 100 MB when inflated. Need to review config.