Bug for ESP8266 environment - noTone not called at end of sound about nonblockingrtttl HOT 6 CLOSED

I'd like contributor status. I'll submit a pull request shortly. Thanks, - James -------- Original message --------From: Antoine Beauchamp <[email protected]> Date: 12/31/18 10:23 AM (GMT-07:00) To: end2endzone/NonBlockingRTTTL <[email protected]> Cc: James Brown <[email protected]>, Author <[email protected]> Subject: Re: [end2endzone/NonBlockingRTTTL] Bug for ESP8266 environment -   noTone not called at end of sound (#6) I verified your proposed changes and I agree with all of them. I did not noticed the issue when I wrote the library for an arduino nano clone. That's a good catch. I am open to pull request. I like to give credit where credit is due. Would you like to be listed as a contributor? If so, submit a pull request. If you do not like to be a contributor, I can commit the proposed changes myself: Replace line 270 by: //issue #6: Bug for ESP8266 environment - noTone() not called at end of sound. //disable sound at the end of a normal playback. stop(); Insert at line 295: //issue #6: Bug for ESP8266 environment - noTone() not called at end of sound. //disable sound if one abort playback using the stop() command. noTone(pin); Waiting for your feedback. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/end2endzone/NonBlockingRTTTL","title":"end2endzone/NonBlockingRTTTL","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/end2endzone/NonBlockingRTTTL"}},"updates":{"snippets":[{"icon":"PERSON","message":"@end2endzone in #6: I verified your proposed changes and I agree with all of them. I did not noticed the issue when I wrote the library for an arduino nano clone. That's a good catch.\r\n\r\nI am open to pull request. I like to give credit where credit is due. Would you like to be listed as a contributor? If so, submit a pull request.\r\n\r\nIf you do not like to be a contributor, I can commit the proposed changes myself:\r\n\r\n1. Replace [line 270](https://github.com/end2endzone/NonBlockingRTTTL/blob/1.2.0/src/NonBlockingRtttl.cpp#L270) by:\r\n```cpp\r\n //issue #6: Bug for ESP8266 environment - noTone() not called at end of sound.\r\n //disable sound at the end of a normal playback.\r\n stop();\r\n```\r\n\r\n2. Insert at [line 295](https://github.com/end2endzone/NonBlockingRTTTL/blob/1.2.0/src/NonBlockingRtttl.cpp#L295):\r\n```cpp\r\n //issue #6: Bug for ESP8266 environment - noTone() not called at end of sound.\r\n //disable sound if one abort playback using the stop() command.\r\n noTone(pin);\r\n\r\n```\r\n\r\nWaiting for your feedback."}],"action":{"name":"View Issue","url":"#6 (comment)"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#6 (comment)", "url": "#6 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Actually non blocking is an issue because the "threads" I'm using are 'passive' rather than active. By that I mean that you have to specifically yield control. If your library were to 'hang' in a play call, it would also hang the rest of the system. Check out the protothreads information at http://dunkels.com/adam/pt/ if you are interested. Very light weight and no issues with interrupts changing your context out from under you. I'm only storing a couple of songs and they are short. I put in a 2K buffer in the alarm info structure, but that is really larger than the max I would ever expect. I could probably lower it to 1K or even 512 and be just fine. At this point I'm not nearly out of memory so it isn't a big issue. I've got 30K+ free and that's plenty for what I'm doing. The next thing I am working on is volume control. I've experimented with it in a hard-coded version (see the commented out code near the bottom of the setup routine) and it works. I just need to take control of the timer1 interrupt and handle that myself instead of using the generic waveform code. Thanks, - James

Links: 1. https://github.com/jbrown123 2. https://github.com/jbrown123/arduino-alarm-clock 3. https://github.com/end2endzone/AnyRtttl/blob/master/examples/ProgramMemoryRtttl/ProgramMemoryRtttl.ino 4. https://github.com/end2endzone/AnyRtttl/tree/2.2.0 5. #6 (comment) 6. https://github.com/notifications/unsubscribe-auth/AAm4KWpDr7YsImZni-WF4YlvwnHxxalxks5u_kdjgaJpZM4Zkr9a