Comments (2)
Hi.
Thank you for you interest in NonBlockingRTTTL.
You are right, the library is expecting notes in a4.
format as showed in the arkanoid melody from the examples with the note 16g.6
I can't remember where I took the specification for the RTTTL format. Looking at my original articles on my blog about AnyRtttl and NonBlockingRTTTL libraries, I only mentioned the Wikipedia article which refers to this specification. Looking at the specification, I do remember the awkward yellow background.
If I understand your proposition, you are suggesting to copy lines 212 to 217 to line 231. I see no problem with this and I think it would make the application "more robust" (in a way).
Its been a while since I have worked with my arduino. It must be lying on a shelve somewhere and quite dusty now. In other words, to test the change, I would have to rebuild my arduino setup to work on this. Since you proposed this change, I would be happy if you would create a pull request and contribute to the project. Is that something that is appealing to you? I know the change is relatively small and simple but like I said, I currently have no way to verify if the change is working as expected. If you do, please add a comment in the code that refers this issue so that people know why we are parsing the .
twice.
If you do not want to create a pull request, that is also fine. I can also commit the change myself but I would need your help to validate if the change is working as expected. Your call.
from nonblockingrtttl.
OK, I'll do some more testing and create a pull request.
from nonblockingrtttl.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nonblockingrtttl.