enaium / fabric-mod-noexpensive Goto Github PK

Not super critical, but when removing all compatibility entries (I only want to remove the max anvil repair cost) and then trying to confirm that with /noexpensive compatibility list, your server connection drops with %s. Server seems to be chugging along fine, so not really a big issue. Doesn't happen in Single Player.

Even after updating the mod to version 1.7.0, the game still crashes:

crash-2023-06-24_11.44.37-client.txt
latest.log

It will be unfortunate if you stop supporting updates to version 1.19.2, because it has many more mods than 1.19.4

IDK if there is a limit of a number of enchantments or sth, but there is a problem when I try to make an enchantment book with all the enchantments that are not incompatible, where the required level doesn't show up, the enchanted book shows up in the third spot in the anvil menu but it's not clickable. I also couldn't enchant anything with that book after I found this problem. The game version is 1.19

https://paste.gg/p/anonymous/23f10105ddb747b1b3fcf1275cb78b4b

Minecraft version: 1.16.4
Loader: Fabric

Charm-fabric-1.16.4-2.1.1-hotfix1 (latest fabric release as of 21/11/2020) is incompatible with NE-1.16.4-1.1.4 (No-Expensive).

          To pile on, 1.20 and 1.20.1 Fabric.

Mod on client and server.

No matter what the max level is set to, 0, 10000, and anywhere in between, the cost always shows as 39.

Originally posted by @BBloom81 in #16 (comment)

you cant even open the damn game with the mod installed for 1.17

the issue only occurs when I enable this mod.
The game works without it.

https://paste.ee/p/ySxYJ

I tried to put mending on my sharpness 4 knockback 2 unbreaking 1 sword but it still says to expensive.

it's kinda annoying

(pic: Protection + mending)

Fabric 1.20.1
Version: https://modrinth.com/mod/noexpensive/version/1.20.1-1.8.2

it removes the max limit for the enchant level of a book allowing to obtain things like Mending V, I couldn't find this described in the mod clearly so I'm going to assume it's an issue.

This repository's LICENSE file states that this code is under the MIT, yet AnvilScreenHandlerMixin.java has an All rights reserved. header.

I would like some clarification about whether this is under the MIT or if its All Rights Reserved

So I'm in this server with the mod installed, and we decided to remove it because we didn't like it anymore. The thing is, that once it was removed (with all of it's customs compatibilities), it removed ALL enchantments compatibilities from the game, meaning we couldn't enchant even vanilla combinations, like mending+unbreaking. I'd like to know if there's a way to solve this (apart from adding said vanilla compatibilities with the mod). Maybe some folder with the mods config that can be erased, idk.

Context / Issue :
When am trying to repair / combine something in the anvil that goes among the anvil vanilla limit, it shows "Too expensive" message.

It still shows the right message when hovering the item.

Is it considered as an issue ? It's my first time using the mod, am trying this in solo to put it on my server after.

NoExpensive 的配置文件按照规范 难道不应该在 .minecraft 的 config 文件夹内?
直接放在 .minecraft 文件夹内不显得凌乱?

Not working as intended on Fabric 1.16.

Will not work on client or server. Mod is confirmed to be running in server console.

Ability to add mending to infinity and multishot to piercing is working, but only on single player. On servers, it shows the item in anvil but when clicking to add the mending book, item disappears. Items are also still appearing as "too expensive".

Minecraft 1.16.5 can't start at all, so it doesn't have crashlog, only latest.log :
latest.log

Minecraft 1.19.2 can run, but I can't enter any world - it immediately crashes.
crash-2023-06-23_17.37.40-client.txt
latest.log

Everything is updated: Windows 10 (22H2), Adoptium Java 8 (8.0.372.7) for 1.16.5 and 17 (17.0.7.7) for 1.19.2 and of course all mods are updated too.

[12:00:57] [main/ERROR]: Failed to start the minecraft server
java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'noexpensive'!
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51) ~[fabric-loader-0.14.21.jar:?]
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33) ~[fabric-loader-0.14.21.jar:?]
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49) ~[fabric-loader-0.14.21.jar:?]
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35) ~[fabric-loader-0.14.21.jar:?]
at net.fabricmc.loader.impl.game.minecraft.Hooks.startServer(Hooks.java:62) ~[fabric-loader-0.14.21.jar:?]
at net.minecraft.server.Main.main(Main.java:112) ~[server-intermediary.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468) ~[fabric-loader-0.14.21.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.14.21.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotServer.main(KnotServer.java:23) ~[fabric-loader-0.14.21.jar:?]
at net.fabricmc.loader.impl.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:69) ~[fabric-loader-0.14.21.jar:?]
at net.fabricmc.loader.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:25) ~[fabric-loader-0.14.21.jar:?]
Caused by: java.lang.NoClassDefFoundError: net/minecraft/class_310
at cn.enaium.noexpensive.Config.(Config.java:21) ~[NE-1.20-1.6.0.jar:?]
at cn.enaium.noexpensive.NoExpensive.onInitialize(NoExpensive.java:50) ~[NE-1.20-1.6.0.jar:?]
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47) ~[fabric-loader-0.14.21.jar:?]
... 8 more
Caused by: java.lang.ClassNotFoundException: net.minecraft.class_310
at jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) ~[?:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:226) ~[fabric-loader-0.14.21.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112) ~[fabric-loader-0.14.21.jar:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
at cn.enaium.noexpensive.Config.(Config.java:21) ~[NE-1.20-1.6.0.jar:?]
at cn.enaium.noexpensive.NoExpensive.onInitialize(NoExpensive.java:50) ~[NE-1.20-1.6.0.jar:?]
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47) ~[fabric-loader-0.14.21.jar:?]
... 8 more

Couple of my players have informed us

"I found a bug where If you put enchanted golden apples in a grindstone then you get a golden apple and the enchanted apple back"

This extra golden apple can be eaten and does give all the effects. I am awaiting a clip from one of the players that I will post in here so you can see.

MC: 1.20.1
Fabric API: 0.90.7
NoExpensive: 1.9.0

In Curseforge, mod file says it's only compatible with 1.19-Snapshots, but 1.19 isn't listed as a compatible version as well (which it should if it is compatible with 1.19.
This is causing mod managers to think the mod is out of date/incompatible with the 1.19 game version and only work with snapshots and thus not work with it. Please fix!

Whenever I add an item to an anvil while using it my server or game immediately crashes.
Here is the crash report: https://mclo.gs/zRoLA3z
The only mods I have installed on the server are no expensive and fabric API.
Game version is 1.20.6

latest.log
@Mixin target net.minecraft.class_471 was not found noexpensive.mixins.json:AnvilScreenMixin from mod noexpensive

On the client connected to the server, the anvil always shows that the cost of any operation is the maximum cost set in the config, otherwise works as expected.

Edit: The mod is installed both client and server side.

I cannot use it in the server,it's doesn't wok.

The version uploaded to modrinth is not up to date.

My server crashes when i put the mod. It can be bc my server is a potato but i still want to submit that :)

An @Overwrite is really, really not needed in this case. After analyzing the code, I've found one and only one difference between yours and vanilla's:

Vanilla:

if (this.levelCost.get() >= 40 && !this.player.getAbilities().creativeMode) {
    itemStack2 = ItemStack.EMPTY;
}

NoExpensive:

if (this.levelCost.get() >= 40 && !this.player.getAbilities().creativeMode) {
    this.levelCost.set(39);
}

If this is the only change there is no reason to overwrite the entire method, as you can easily skip this condition by multiple ways: by redirecting levelCost.get to always return a value lower than 40, or modifying the constant to Integer.MAX_VALUE, or by redirecting player.getAbilities().creativeMode to always return true. If any of them are used the code inside the if statement won't even run, achieving the same goal.
Also in my opinion locking the cost again when the code above the check literally does the same thing is an odd thing to do. Just leave the code block blank. :tiny_potato:

Is this mod still compatible with 1.16.5? If so could you add the tag for it so that CurseForge client users can find and add the mod to their custom packs? :)

The wordings too expensive is no longer seen when placing my bow which is a good thing, but after I placed my mending book the end product comes in the third square for a split moment and goes and I am no longer able to take the bow with the mending applied. Please look into the issue.