emmasweeney / frances-hodgson-burnett_little-lord-fauntleroy Goto Github PK

In Mr Hobb's letter which starts "Yrs received and wd say things looks bad" , the valediction paragraph needs to be put into the footer so that it is correctly right-aligned.

I fear that all the back-and-forth between Vince, Alex and I in the forum thread may have confused you somewhat about letter styling. We're trying to get a definitive version in the online manual, but there are still a couple of changes I believe we need there.

Anyway, all of this is to (1) apologise for any confusion and (2) to suggest changes to your local.css.

You should take out the right-align for the signature class in local.css. It gets right-aligned by the footer already.

So it should just read:

.signature{
	font-variant: small-caps;
}

And you also need to add:

[epub|type~="z3998:postscript"]{
	margin-top: 1em;
	text-indent: 0;
	text-align: left;
}

LOTS of people forget to do this!

You need to add another dc:source line in content.opf to link to the page scans, so add this line below the gutenberg link:

<dc:source>https://books.google.com/books?id=kut_maWlSREC</dc:source>

There are a lot of instances of left-single-quotes where they should be right-single-quotes in dialect, where they indicate omitted letters (exactly as in "don’t"). For example: "ye see this ‘ere un" should be "ye see this ’ere un"

You'll find these if you do a search for this regular expression:

\s‘[a-z]

Lint complains as follows:

Manual Review: colophon.xhtml Required nbsp not found before <abbr class="time">

You just need to put a non-breaking space before the <abbr in this line of the colophon:

<b>January 1, 1900, 12:00 <abbr class="time eoc">a.m.</abbr></b><br/>

It looks as though you may have edited this line manually. You don't need to do that as the build process will update it.

There are some changes typogrify makes to do with em-dashes. Just run typogrify again and accept the changes it makes.

In chapter 11, the bootblack's sign would be better marked with <b>tags rather than <em>. It's not an emphasis in speech, and with our core CSS the <b> tag will get styled as small-caps, which matches the page scans better.

Generally, we try to make our short descriptions quite generic and not include the names of characters.

So a suggested rewrite might be:

"A poor young boy unexpectedly inherits a peerage and travels to England to live with his grandfather, an Earl."

There are a couple of instances where you should 'semanticate' the titles of publications, one in chapter-1, which should be:

<i epub:type="se:name.publication.newspaper">Illustrated London News</i>

and one in chapter 11, which should be:

<i epub:type="se:name.publication.magazine">Penny Story Gazette</i>

The long description currently includes unescaped <i> tags. Perhaps you added these after running clean (which escapes html tags in long description)?

Anyway, you'll need to replace each <i> and </i> with <i> and </i> respectively.