ember-cli-deploy / ember-cli-deploy-build Goto Github PK

View Code? Open in Web Editor NEW

21.0 21.0 23.0 2.19 MB

A Build Plugin for ember-cli-deploy

License: MIT License

JavaScript 88.12% HTML 11.55% Handlebars 0.33%

ember-cli-deploy-plugin

ember-cli-deploy-build's Introduction

Ember CLI Deploy

Simple, flexible deployment for your Ember CLI app

Installation

ember install ember-cli-deploy

Quick start

After installation, choose plugins matching your deployment environment, configure your deployment script appropriately and you're ready to start deploying.

In-depth documentation

Visit the Docs site

Contributing

Clone the repo and run npm install. To run tests,

npm test

ember-cli-deploy-build's People

Contributors

Stargazers

Watchers

ember-cli-deploy-build's Issues

Add the option of store environment.js info in separate file instead of meta

I like the possibility of modifying the configuration without having to recompile, but change the generated meta in index.html is a little tricky. Is it possible to save the information in another file instead of meta?

For example

// ember-cli-build.js
var app = new EmberApp({
  configLocation: ->"file", "meta" (storeConfigInMeta = true), "app" (storeConfigInMeta = false)
});

// index.html
<!DOCTYPE html>
   ...
   <script src="config.js" ></script>
   ...
</html>

Wrong app environment with ember-cli-dotenv

I'm using ember-cli-dotenv for writing my app settings for the different environments but when I run the deploy command, the build output uses always the .env-development settings file instead of reading from .env-production file.
If I run a build with the classic ember build command everything is fine.

DEPRECATION to fix: ember-cli/ext/promise

DEPRECATION: `ember-cli/ext/promise` is deprecated, use `rsvp` instead. Required here:
  Object.<anonymous> (\node_modules\ember-cli-deploy-build\index.js:4:15)

Is is possible to determine the `outputPath` in another addon?

I have an addon that uses the outputReady hook to do some file manipulation. Originally it was hardcoded to look for built files in the dist/ dir, but when its outputReady hook is invoked as part of an ember deploy process, the built files are actually in tmp/deploy-dist by default.
Is it possible for a downstream addon to find out what the outputPath that was passed to the builder (this happens here in ember-cli-deploy-build) was?
Ideally this would be a value that the addon could read from that would return dist/ if a normal ember build happened and tmp/deploy-dist (or whatever was passed in) if an ember deploy is building.
thanks!

change outputPath

I am new to this and am writing a deploy for CouchDB. In my setup hook I like to extend the ENV.build.outputPath with '/_attachments' like this:

outputPath = outputPath + path.sep + '_attachments';

How do I access the build outputPath?

How to re-use output file from ember build

Is it possible to skip the build with a flag? For example,

# build the app
ember build

# do other sutff

# deploy the app directly, no need to build again
ember deploy --skip-build

The use case is that I want to skip the redundant build in my CI/CD pipeline, but still keep the default build-and-deploy behavior in all other scenario.

Option not to swallow the `ember build` output

Not being able to see what's going on is frustrating at times.

include environment in default outputPath

We are testing concurrent deployments using threads. We are doing this locally, but I figured it might make sense as the default:

outputPath: `tmp/deploy-dist-${environment}`

I started making a PR, but since the environment is dynamic and the defaults are defined as static, I couldn't figure out how to get it to work, especially with the EMBER_CLI_DEPLOY_REUSE_BUILD section. Also, how would you detect if someone already customised the outputPath before appending the environment?

buildEnv vs deployTarget confusion

The log message at

https://github.com/ember-cli-deploy/ember-cli-deploy-build/blob/master/index.js#L33

should either say it's the deployTarget or should print out the build environment.

please refer to the Plugin Documentation. link goes to http://ember-cli-deploy.com/plugins/

The link does not link to a detailed plugin documentation.

Add willDeploy hook to validate config

Refer to the other plugins written in this org for examples

Broken with apps using ember-cli 1.13

The plugin is looking for Brocfile.js, but the app is using ember-cli-build.js. In general, it would be ideal if the plugin used the build mechanism in the app's version of ember-cli, not it's own. This may be only an issue with an npm link-ed setup only. I'll check tomorrow.

Generated source maps are binary files

When doing ember build --prod, the generated source maps (in dist/assets) are json files (as they should be).

However, the result from ember deploy, the generated source maps (in tmp/deploy-dist/assets) are binary files (which are unparsable by source map libraries).

I have no idea how to go about debugging. Any help would be appreciated.

Ensure dist directory is removed before each build

The issue occurs if you are using ember-cli-deploy-gzip.
If you run the build consequently - the second time if the fingerprint of a file didn't change the gzip plugin will run again over the already gzipped file and in turn it will double gzip that file which the browser can't decompress thus making the app break.

A solution would be to delete the dist folder before each build.

use deployTarget instead of configurable environment

Hi,
It is now mandatory to pass an environment to ember-cli-deploy since ember-cli-deploy/ember-cli-deploy@8f9b40d and the passed value is being put in context.deployTarget.
before making a pull request, I would like to know what you'd think of using context.deployTarget value instead of the environment config option.
cheers,
Vincent

.htaccess is not included in the distFiles

I'm not sure if this is intentional or a bug. To fix this, we just need to add dot: true to glob.sync options. The downside of this would be that other OS files (like .DS_Store) will also be included in the list of files. I can make a PR but I'd like to know your thoughts on this.

deploy command is invalid

I've just installed the addon in my ember project, but once I type "ember deploy" I get the error:

The specified command deploy is invalid. For available options, see ember help.

(Ember 2.2.0, ember-cli 1.13.13)

Change the default output path not working

I tried to change the default output path as follows and it didn't work, the add-on put all the stuff into tmp/deploy-dist:

#deploy.js

...
  if (deployTarget === 'development') {
    ENV.build.environment = 'development';
    ENV.build.outputPath = 'dist';
  }
....

What am doing wrong here ? Thank you.