embeddedt / modernfix Goto Github PK
View Code? Open in Web Editor NEWMinecraft 1.16 & 1.18+ bugfix/performance mod
Home Page: https://www.curseforge.com/minecraft/mc-mods/modernfix
License: Other
Minecraft 1.16 & 1.18+ bugfix/performance mod
Home Page: https://www.curseforge.com/minecraft/mc-mods/modernfix
License: Other
Hi, I'm developing a modpack (update, actually).
When adding your mod, it crashed on startup.
I singled out that this mod alone with Better Loading Screen is causing the crash. if I deactivate either, it works again, testing on also just having both installed together crashes on a fresh modpack. Here's the report on the other side.
shedaniel/BetterLoadingScreen#46
I have no idea what can cause this but if you need any additional info or test runs, let me know, I am also interested in fixing this issue asap.
If there are any additional mods you recommend in deactivating, please let me know as well. I might change the setup again, depending on what can be done about this issue. In doubt I will choose BLS over ModernFix.
Forgebackport "Prevent freeing custom payload packet buffer" from 1.18 and "Re-add fix to free buffer in custom payload packet" from 1.17 to potentially fix major memory leak that can crash on big modpack due to lack of memory after 3-6 hours of games caused by packetbuffer.release().
issues :
MinecraftForge/MinecraftForge#8573
EnigmaticaModpacks/Enigmatica6#4469
codes need to be backported :
Prevent release of custom payload packet buffer :
MinecraftForge/MinecraftForge#8181
Re-add patch to release buffer in custom payload packet
MinecraftForge/MinecraftForge#8042
crash-2023-03-07_14.05.30-client.txt
Java11
Win10
GPU:RX6600
Using ModernFix (any version for 1.18.2) alongside with the I Like Wood mod (latest 1.18.2 version) causes the barrels from this mod to render as a missing texture block:
So any ILW barrel placed on the ground turns into an emo block. I haven't noticed any other blocks behaving this way.
Disabling mixin.perf.modern_resourcepacks
in the modernfix-mixins.properties
file fixes the issue but makes the game launch slower.
Open barrels, however, always render as intended:
I tried to reproduce this bug in 1.19.2 but everything works fine (I can't update my modpack to this version tho).
I guess I really... Need the barrels...
With just modernfix and jei installed the jei menu shows but when installing swem it doesnt show at all.
Mods installed:
jei-1.16.5-7.7.1.153
modernfix-mc1.16.5-1.4.2
geckolib-forge-1.16.5-3.0.103
player-animation-lib-forge-0.3.5+1.16.5
swem-1.16.5-0.5.3.4
At present, there are two situations. The first is that the number of items disappears after entering the archive. The second is that a single item is not affected, and the items with numbers all become "S".
Of course, these are all display problems, in fact, the number of items has not changed. And the probability of encountering it is relatively small, but it is quite annoying because I have to restart the game.
To avoid confusing users when JEI does not appear, and also to be clear that JEI has been invasively modified.
Please tell me what this means and how to fix it?
mod version: modernfix-mc1.18.2-2.1.0
forge: 1.18.2-40.2.0
https://gist.github.com/P3rf3ctXZer0/3f1da2e84b71c33f6952179bbf757b62
using 1.6.0 Modern fix.
Drink Beer GitHub
Drink Beer JEI addon - Just Enough Keg Github
java version 11.0.15.1 by Oracle Corporation
forge version 36.2.39
test env: launched my game, create a new world, waited to log in, opened my inventory, and finally saw crash or not.
With ModernFix (crash):
latest.log: https://pastebin.ubuntu.com/p/Hkv3x3KjJn/
Main fatal part: https://pastebin.ubuntu.com/p/9tr9RgQNXD/
Without ModernFix (didn't crash):
latest.log: https://pastebin.ubuntu.com/p/M8J4KdjnCs/
I had already been to the end.Then I added this mod.
Then I ran 40,000 meters away to find a new stronghold.
But the ender eye points in the direction of the spawn point.
I ran 12,000 meters, which is still far from the stronghold.
I finally found it around X:-6000 Y:~ Z:3000.
It's strange that there is a stronghold every three kilometers on average.Anyway, the ender eye should not lead me there.
Then I created a new file.I threw the ender eye.Then the game crashed.
This seems to mean that there is something wrong with the generation of stronghold.
Benchmark map used: https://www.planetminecraft.com/project/minecraft-benchmark-v3/
With ModernFix:
Average FPS is ~190-220
Without ModernFiX:
Average FPS is ~220-240
Mod list
Mod version 1.10.1
game crashes when launching when mixin.perf.parallelize_model_loading.multipart and mixin.perf.parallelize_model_loading are enabled; seems like it might be related to the betterend mod
didn't see an existing issue that seemed like it related to this
I am not sure if this is of any help, but after trying the newest beta, I experience a repeatable crash when leaving the end (albeit only tested with the /execute in command)
I tried switching off the "rebuild_blockstate_cache_async" option but that does not change anything.
When I loaded the same save (it was crashing on entering the world) with ModernFix 1.6.0 Beta 2, the game worked again.
I do run a heavily modded game, but here is the log. You're doing godly work btw, I literally cannot stand booting up Minecraft without your mod anymore lol.
crash report :
crash-2023-02-14_01.47.18-client.txt
mods lists :
The game crashed whilst rendering overlay
Error: java.lang.IllegalAccessError: failed to access class net.minecraft.client.renderer.texture.Stitcher$Holder from class org.embeddedt.modernfix.textures.StbStitcher (net.minecraft.client.renderer.texture.Stitcher$Holder is in module [email protected] of loader 'TRANSFORMER' @7994a0d1; org.embeddedt.modernfix.textures.StbStitcher is in module [email protected] of loader 'TRANSFORMER' @7994a0d1)
---- Minecraft Crash Report ----
// You should try our sister game, Minceraft!
Time: 3/4/23, 3:27 PM
Description: Rendering overlay
java.lang.IllegalAccessError: failed to access class net.minecraft.client.renderer.texture.Stitcher$Holder from class org.embeddedt.modernfix.textures.StbStitcher (net.minecraft.client.renderer.texture.Stitcher$Holder is in module [email protected] of loader 'TRANSFORMER' @7994a0d1; org.embeddedt.modernfix.textures.StbStitcher is in module [email protected] of loader 'TRANSFORMER' @7994a0d1)
at org.embeddedt.modernfix.textures.StbStitcher.packRects(StbStitcher.java:142) ~[modernfix-mc1.18.2-2.0.0.jar%23278!/:2.0.0] {re:mixin,re:classloading}
at net.minecraft.client.renderer.texture.Stitcher.m_118193_(Stitcher.java:538) ~[client-1.18.2-20220404.173914-srg.jar%23413!/:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:modernfix.mixins.json:perf.faster_texture_stitching.StitcherMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.texture.TextureAtlas.m_118307_(TextureAtlas.java:132) ~[client-1.18.2-20220404.173914-srg.jar%23413!/:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:flywheel.mixins.json:atlas.AtlasDataMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.resources.TextureAtlasHolder.m_5944_(TextureAtlasHolder.java:37) ~[client-1.18.2-20220404.173914-srg.jar%23413!/:?] {re:classloading}
at net.minecraft.client.resources.TextureAtlasHolder.m_5944_(TextureAtlasHolder.java:13) ~[client-1.18.2-20220404.173914-srg.jar%23413!/:?] {re:classloading}
at net.minecraft.server.packs.resources.SimplePreparableReloadListener.m_10786_(SimplePreparableReloadListener.java:11) ~[client-1.18.2-20220404.173914-srg.jar%23413!/:?] {re:mixin,re:classloading}
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?] {}
at java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760) ~[?:?] {}
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}
at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}
at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {re:mixin,re:computing_frames}
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {re:mixin,re:computing_frames}
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {re:mixin}
-- Head --
Thread: Render thread
Stacktrace:
at net.minecraft.client.renderer.GameRenderer.m_109093_(GameRenderer.java:882) ~[client-1.18.2-20220404.173914-srg.jar%23413!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:immersive_aircraft.mixins.json:GameRendererMixin,pl:mixin:APP:beyond_earth.mixin.json:BobViewer,pl:mixin:APP:forge-mca.mixin.json:client.MixinGameRenderer,pl:mixin:APP:create.mixins.json:GameRendererMixin,pl:mixin:APP:create.mixins.json:accessor.GameRendererAccessor,pl:mixin:A,pl:runtimedistcleaner:A}
-- Overlay render details --
Details:
Overlay name: net.minecraft.client.gui.screens.LoadingOverlay
Stacktrace:
at net.minecraft.client.renderer.GameRenderer.m_109093_(GameRenderer.java:882) ~[client-1.18.2-20220404.173914-srg.jar%23413!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:immersive_aircraft.mixins.json:GameRendererMixin,pl:mixin:APP:beyond_earth.mixin.json:BobViewer,pl:mixin:APP:forge-mca.mixin.json:client.MixinGameRenderer,pl:mixin:APP:create.mixins.json:GameRendererMixin,pl:mixin:APP:create.mixins.json:accessor.GameRendererAccessor,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1046) ~[client-1.18.2-20220404.173914-srg.jar%23413!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:modernfix.mixins.json:core.MinecraftMixin,pl:mixin:APP:modernfix.mixins.json:feature.measure_time.MinecraftMixin,pl:mixin:APP:modernfix.mixins.json:bugfix.concurrency.MinecraftMixin,pl:mixin:APP:balm.mixins.json:MinecraftMixin,pl:mixin:APP:flywheel.mixins.json:PausedPartialTickAccessor,pl:mixin:APP:bookshelf.common.mixins.json:client.AccessorMinecraft,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:665) ~[client-1.18.2-20220404.173914-srg.jar%23413!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:modernfix.mixins.json:core.MinecraftMixin,pl:mixin:APP:modernfix.mixins.json:feature.measure_time.MinecraftMixin,pl:mixin:APP:modernfix.mixins.json:bugfix.concurrency.MinecraftMixin,pl:mixin:APP:balm.mixins.json:MinecraftMixin,pl:mixin:APP:flywheel.mixins.json:PausedPartialTickAccessor,pl:mixin:APP:bookshelf.common.mixins.json:client.AccessorMinecraft,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.main.Main.main(Main.java:205) ~[client-1.18.2-20220404.173914-srg.jar%23413!/:?] {re:classloading,re:mixin,pl:runtimedistcleaner:A,pl:mixin:A,pl:runtimedistcleaner:A}
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}
at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}
at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:31) ~[fmlloader-1.18.2-40.2.1.jar%2317!/:?] {}
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.1.3.jar%235!/:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.1.3.jar%235!/:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.1.3.jar%235!/:?] {}
at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.1.3.jar%235!/:?] {}
at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.1.3.jar%235!/:?] {}
at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.1.3.jar%235!/:?] {}
at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.1.3.jar%235!/:?] {}
at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:149) [bootstraplauncher-1.0.0.jar:?] {}
-- Last reload --
Details:
Reload number: 1
Reload reason: initial
Finished: No
Packs: Default
-- System Details --
Details:
Minecraft Version: 1.18.2
Minecraft Version ID: 1.18.2
Operating System: Windows 10 (amd64) version 10.0
Java Version: 17.0.1, Microsoft
Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft
Memory: 201973176 bytes (192 MiB) / 788529152 bytes (752 MiB) up to 23320330240 bytes (22240 MiB)
CPUs: 16
Processor Vendor: GenuineIntel
Processor Name: 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
Identifier: Intel64 Family 6 Model 141 Stepping 1
Microarchitecture: unknown
Frequency (GHz): 2.30
Number of physical packages: 1
Number of physical CPUs: 8
Number of logical CPUs: 16
Graphics card #0 name: Intel(R) UHD Graphics
Graphics card #0 vendor: Intel Corporation (0x8086)
Graphics card #0 VRAM (MB): 1024.00
Graphics card #0 deviceId: 0x9a60
Graphics card #0 versionInfo: DriverVersion=31.0.101.4146
Graphics card #1 name: NVIDIA GeForce RTX 3050 Ti Laptop GPU
Graphics card #1 vendor: NVIDIA (0x10de)
Graphics card #1 VRAM (MB): 4095.00
Graphics card #1 deviceId: 0x25a0
Graphics card #1 versionInfo: DriverVersion=31.0.15.3118
Memory slot #0 capacity (MB): 32768.00
Memory slot #0 clockSpeed (GHz): 3.20
Memory slot #0 type: DDR4
Memory slot #1 capacity (MB): 32768.00
Memory slot #1 clockSpeed (GHz): 3.20
Memory slot #1 type: DDR4
Virtual memory max (MB): 74965.52
Virtual memory used (MB): 18396.18
Swap memory total (MB): 9728.00
Swap memory used (MB): 52.70
JVM Flags: 5 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx22240m -Xms256m -XX:+UnlockExperimentalVMOptions
Launched Version: forge-40.2.1
Backend library: LWJGL version 3.2.2 SNAPSHOT
Backend API: NVIDIA GeForce RTX 3050 Ti Laptop GPU/PCIe/SSE2 GL version 3.2.0 NVIDIA 531.18, NVIDIA Corporation
Window size: 1920x1061
GL Caps: Using framebuffer using OpenGL 3.2
GL debug messages:
Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'forge'
Type: Client (map_client.txt)
Graphics mode: fancy
Resource Packs:
Current Language: English (US)
CPU: 16x 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
ModLauncher: 9.1.3+9.1.3+main.9b69c82a
ModLauncher launch target: forgeclient
ModLauncher naming: srg
ModLauncher services:
mixin PLUGINSERVICE
eventbus PLUGINSERVICE
slf4jfixer PLUGINSERVICE
object_holder_definalize PLUGINSERVICE
runtime_enum_extender PLUGINSERVICE
capability_token_subclass PLUGINSERVICE
accesstransformer PLUGINSERVICE
runtimedistcleaner PLUGINSERVICE
mixin TRANSFORMATIONSERVICE
fml TRANSFORMATIONSERVICE
FML Language Providers:
[email protected]
lowcodefml@null
javafml@null
Mod List:
client-1.18.2-20220404.173914-srg.jar |Minecraft |minecraft |1.18.2 |NONE |Manifest: a1:d4:5e:04:4f:d3:d6:e0:7b:37:97:cf:77:b0:de:ad:4a:47:ce:8c:96:49:5f:0a:cf:8c:ae:b2:6d:4b:8a:3f
forge-1.18.2-40.2.1-universal.jar |Forge |forge |40.2.1 |NONE |Manifest: 84:ce:76:e8:45:35:e4:0e:63:86:df:47:59:80:0f:67:6c:c1:5f:6e:5f:4d:b3:54:47:1a:9f:7f:ed:5e:f2:90
modernfix: 1.4.0
crash-2023-01-08_10.48.27-fml.txt
debug.log
latest.log
Minecraft v1.19.2
Forge v43.2.7
Modern Fix v3.2.1
After installing this mod on my server, loading new chunks causes the player to be kicked from the server and an error to print out in the log. It seems to have occurred with both ad astra and spelunkery mod structures, although the mods are probably not related to the issue.
[27Mar2023 00:32:06.446] [Worker-Main-4/ERROR] [ModernFix/]: Can't read structure
java.io.FileNotFoundException: ad_astra:structures/venus_bullet.nbt
at net.minecraft.server.packs.resources.ResourceProvider.m_215590_(ResourceProvider.java:20) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?]
at net.minecraft.server.packs.resources.ResourceProvider.m_215593_(ResourceProvider.java:20) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.server.packs.resources.ResourceProvider.m_215595_(ResourceProvider.java:24) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.m_230427_(StructureTemplateManager.java:533) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.m_230425_(StructureTemplateManager.java:102) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708) ~[?:?]
at net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.m_230407_(StructureTemplateManager.java:92) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.m_230359_(StructureTemplateManager.java:80) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at com.mojang.datafixers.util.Either$Left.map(Either.java:38) ~[datafixerupper-5.0.28.jar%2375!/:?]
at net.minecraft.world.level.levelgen.structure.pools.SinglePoolElement.m_227299_(SinglePoolElement.java:85) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.world.level.levelgen.structure.pools.SinglePoolElement.m_214015_(SinglePoolElement.java:118) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.world.level.levelgen.structure.pools.JigsawPlacement.m_227238_(JigsawPlacement.java:295) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.world.level.levelgen.structure.structures.JigsawStructure.m_214086_(JigsawStructure.java:86) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.world.level.levelgen.structure.Structure.m_226596_(Structure.java:84) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.world.level.chunk.ChunkGenerator.m_223104_(ChunkGenerator.java:638) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.world.level.chunk.ChunkGenerator.m_223066_(ChunkGenerator.java:591) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) ~[?:?]
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?]
at java.util.AbstractList$RandomAccessSpliterator.forEachRemaining(AbstractList.java:720) ~[?:?]
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) ~[?:?]
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?]
at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) ~[?:?]
at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) ~[?:?]
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596) ~[?:?]
at net.minecraft.world.level.chunk.ChunkGenerator.m_223164_(ChunkGenerator.java:573) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.world.level.chunk.ChunkStatus.m_223360_(ChunkStatus.java:59) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.world.level.chunk.ChunkStatus.m_223279_(ChunkStatus.java:292) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.server.level.ChunkMap.lambda$scheduleChunkGeneration$25(ChunkMap.java:621) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at com.mojang.datafixers.util.Either$Left.map(Either.java:38) ~[datafixerupper-5.0.28.jar%2375!/:?]
at net.minecraft.server.level.ChunkMap.lambda$scheduleChunkGeneration$27(ChunkMap.java:619) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1150) ~[?:?]
at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?]
at net.minecraft.server.level.ChunkTaskPriorityQueueSorter.m_143188_(ChunkTaskPriorityQueueSorter.java:62) ~[server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.util.thread.ProcessorMailbox.m_18759_(ProcessorMailbox.java:91) [server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.util.thread.ProcessorMailbox.m_18747_(ProcessorMailbox.java:146) [server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at net.minecraft.util.thread.ProcessorMailbox.run(ProcessorMailbox.java:102) [server-1.19.2-20220805.130853-srg.jar%23603!/:?]
at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395) [?:?]
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) [?:?]
at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1176) [?:?]
at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1647) [?:?]
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1614) [?:?]
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) [?:?]
I'm sorry to leave another bug issue, really hope this doesn't bother you. ><
I noticed a repeatable crash (any recent ModernFix version, including most recent compiled) when
I tried to add "tconstruct" as modid that bakes early, but that stopped the game from loading. "tconstruct:crafting_station" allowed me to boot but sadly didn't solve the problem.
Here's the crash log:
crash-2023-02-12_21.16.44-client.txt
And here is the entire log:
latest.log
I also wonder if you may have any idea about this crash I am experiencing...however it seems like this crash is happening between the mod "Spoiled" and "Macaw's Furniture" and probably doesn't have anything to do with ModernFix.
crash-2023-02-12_23.19.34-server.txt
Apologies once again
game version 1.16.5, mod version v1.11.1
The first time entering a world, after exiting the world and re-entering the same world, the game will always get stuck at 100% world loading and then crash when trying to close the game.
minecraft-exported-crash-info-2023-03-24T15-36-42.zip
Report by others, I'm just a helper to submit issue.
Answer me when you get a chance. Also after that please post this QA on front of page.
forge: 36.2.39
modernfix: 1.2.0
Faint Amaranth in Astral Sorcery:
Although they may not be useful, there are:
latest.log
debug.log
dimension: atum
related code
For the tree, it works well. But the terrain looks bad.
I have used the original mod Chunk Saving Fix a long time ago which do have this problem too, but this mod seemed to be at end of life, so I didn't report the problem to SuperCoder7979.
Fortunately, this strange terrain appears rarely, but it would be nice if you can fix it.
Description: Exception in server tick loop
java.lang.NoClassDefFoundError: org/apache/commons/codec/binary/Hex
at org.embeddedt.modernfix.structure.CachingStructureManager.readStructureTag(CachingStructureManager.java:46) ~[modernfix-mc1.19.2-3.0.2.jar%23785!/:3.0.2] {re:mixin,re:classloading}
at org.embeddedt.modernfix.structure.CachingStructureManager.readStructure(CachingStructureManager.java:29) ~[modernfix-mc1.19.2-3.0.2.jar%23785!/:3.0.2] {re:mixin,re:classloading}
at net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.m_230427_(StructureTemplateManager.java:533) ~[server-1.19.2-20220805.130853-srg.jar%23969!/:?] {re:mixin,re:classloading,pl:mixin:APP:modernfix.mixins.json:perf.cache_upgraded_structures.StructureManagerMixin,pl:mixin:APP:repurposed_structures.mixins.json:structures.StructureTemplateManagerAccessor,pl:mixin:A}
at net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.m_230425_(StructureTemplateManager.java:102) ~[server-1.19.2-20220805.130853-srg.jar%23969!/:?] {re:mixin,re:classloading,pl:mixin:APP:modernfix.mixins.json:perf.cache_upgraded_structures.StructureManagerMixin,pl:mixin:APP:repurposed_structures.mixins.json:structures.StructureTemplateManagerAccessor,pl:mixin:A}
at java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708) ~[?:?] {re:mixin}
at net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplateManager.m_230407_(StructureTemplateManager.java:92) ~[server-1.19.2-20220805.130853-srg.jar%23969!/:?] {re:mixin,re:classloading,pl:mixin:APP:modernfix.mixins.json:perf.cache_upgraded_structures.StructureManagerMixin,pl:mixin:APP:repurposed_structures.mixins.json:structures.StructureTemplateManagerAccessor,pl:mixin:A}
at com.telepathicgrunt.repurposedstructures.misc.pooladditions.PoolAdditionMerger.mergeIntoExistingPool(PoolAdditionMerger.java:103) ~[repurposed_structures_forge-6.3.11+1.19.2.jar%23854!/:6.3.11+1.19.2] {re:classloading}
at com.telepathicgrunt.repurposedstructures.misc.pooladditions.PoolAdditionMerger.lambda$parsePoolsAndBeginMerger$1(PoolAdditionMerger.java:72) ~[repurposed_structures_forge-6.3.11+1.19.2.jar%23854!/:6.3.11+1.19.2] {re:classloading}
at java.util.Optional.ifPresent(Optional.java:178) ~[?:?] {re:mixin}
at com.telepathicgrunt.repurposedstructures.misc.pooladditions.PoolAdditionMerger.parsePoolsAndBeginMerger(PoolAdditionMerger.java:72) ~[repurposed_structures_forge-6.3.11+1.19.2.jar%23854!/:6.3.11+1.19.2] {re:classloading}
at com.telepathicgrunt.repurposedstructures.misc.pooladditions.PoolAdditionMerger.mergeAdditionPools(PoolAdditionMerger.java:52) ~[repurposed_structures_forge-6.3.11+1.19.2.jar%23854!/:6.3.11+1.19.2] {re:classloading}
at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260) ~[eventbus-6.0.3.jar%2351!/:?] {}
at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252) ~[eventbus-6.0.3.jar%2351!/:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.3.jar%2351!/:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.3.jar%2351!/:?] {}
at net.minecraftforge.server.ServerLifecycleHooks.handleServerAboutToStart(ServerLifecycleHooks.java:92) ~[forge-1.19.2-43.2.6-universal.jar%23974!/:?] {re:classloading}
at net.minecraft.server.dedicated.DedicatedServer.m_7038_(DedicatedServer.java:163) ~[server-1.19.2-20220805.130853-srg.jar%23969!/:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:nochatreports.mixins.json:server.MixinDedicatedServer,pl:mixin:APP:blueprint.mixins.json:DedicatedServerMixin,pl:mixin:APP:tombstone.mixins.json:DedicatedServerMixin,pl:mixin:A}
at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:625) ~[server-1.19.2-20220805.130853-srg.jar%23969!/:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:kubejs-common.mixins.json:MinecraftServerMixin,pl:mixin:APP:kubejs-common.mixins.json:inject_resources.MinecraftServerMixin,pl:mixin:APP:infernal-expansion.mixins.json:common.MixinMinecraftServer,pl:mixin:APP:structure_gel.mixins.json:MinecraftServerMixin,pl:mixin:APP:ae2.mixins.json:spatial.MinecraftServerMixin,pl:mixin:APP:elementalcraft.mixins.json:MixinMinecraftServer,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin,pl:mixin:APP:byg.mixins.json:access.MinecraftServerAccess,pl:mixin:APP:byg.mixins.json:server.MixinMinecraftServer,pl:mixin:A}
at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:244) ~[server-1.19.2-20220805.130853-srg.jar%23969!/:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:kubejs-common.mixins.json:MinecraftServerMixin,pl:mixin:APP:kubejs-common.mixins.json:inject_resources.MinecraftServerMixin,pl:mixin:APP:infernal-expansion.mixins.json:common.MixinMinecraftServer,pl:mixin:APP:structure_gel.mixins.json:MinecraftServerMixin,pl:mixin:APP:ae2.mixins.json:spatial.MinecraftServerMixin,pl:mixin:APP:elementalcraft.mixins.json:MixinMinecraftServer,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin,pl:mixin:APP:byg.mixins.json:access.MinecraftServerAccess,pl:mixin:APP:byg.mixins.json:server.MixinMinecraftServer,pl:mixin:A}
at java.lang.Thread.run(Thread.java:833) [?:?] {re:mixin}
Caused by: java.lang.ClassNotFoundException: org.apache.commons.codec.binary.Hex
at jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) ~[?:?] {}
at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?] {}
at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:137) ~[securejarhandler-2.1.4.jar:?] {}
at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?] {}
at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:137) ~[securejarhandler-2.1.4.jar:?] {}
at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?] {}
... 20 more
forge: 36.2.39
modernfix: 1.3.0
Immersive Engineering: 5.1.0-148 (Lasest on Curseforge)
Immersive Petroleum: 3.4.0-13 (Lasest on Curseforge)
with modernfix:
debug.log - 1030KB
latest.log - 945KB
takes 25s to start
without:
debug.log - 86KB
latest.log - 12KB
takes 10s to start
Heya embeddedt!
Is there anyway you can disable mixin-injections/client start-up changes in the event it detects Lightspeed mod?
I really enjoy lightspeed and it's a fair-bit faster on my system compared to Modernfix. I'd love if you could please disable only your client-startup modifications in favor of Lightspeed mod's modifications. Thanks!
-- Head --
Thread: Render thread
Stacktrace:
at net.minecraft.util.ResourceLocation.(ResourceLocation.java:33) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:ftblibrary-common.mixins.json:ResourceLocationMixin,pl:mixin:APP:ferritecore.mrl.mixin.json:ResourceLocationAccess,pl:mixin:A}
at net.minecraft.util.ResourceLocation.(ResourceLocation.java:42) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:ftblibrary-common.mixins.json:ResourceLocationMixin,pl:mixin:APP:ferritecore.mrl.mixin.json:ResourceLocationAccess,pl:mixin:A}
at net.minecraftforge.fml.packs.ModFileResourcePack.mdd2c1f6$lambda$getResources$5$0(ModFileResourcePack.java:605) ~[forge:?] {re:mixin,re:classloading,pl:mixin:APP:modernfix.mixins.json:ModFileResourcePackMixin,pl:mixin:A}
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) ~[?:1.8.0_341] {}
at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) ~[?:1.8.0_341] {}
at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) ~[?:1.8.0_341] {}
at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) ~[?:1.8.0_341] {}
at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384) ~[?:1.8.0_341] {}
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) ~[?:1.8.0_341] {}
-- Overlay render details --
Details:
Overlay name: net.minecraft.client.gui.ResourceLoadProgressGui
Stacktrace:
at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:484) ~[?:?] {re:mixin,pl:accesstransformer:B,xf:fml:astralsorcery:reach_set_client_renderer,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:astralsorcery:reach_set_client_renderer,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:977) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:rubidium.mixins.json:features.gui.fast_fps_pie.MixinMinecraftClient,pl:mixin:APP:rubidium.mixins.json:features.options.MixinMinecraftClient,pl:mixin:APP:modernfix.mixins.json:MinecraftMixin,pl:mixin:APP:randompatches.mixins.json:client.MinecraftMixin,pl:mixin:APP:notenoughcrashes.mixins.json:client.MixinMinecraftClient,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:abnormals_core.mixins.json:client.MinecraftMixin,pl:mixin:APP:magnesium_extras.mixins.json:FrameCounter.FpsAccessorMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:rubidium.mixins.json:features.gui.fast_fps_pie.MixinMinecraftClient,pl:mixin:APP:rubidium.mixins.json:features.options.MixinMinecraftClient,pl:mixin:APP:modernfix.mixins.json:MinecraftMixin,pl:mixin:APP:randompatches.mixins.json:client.MinecraftMixin,pl:mixin:APP:notenoughcrashes.mixins.json:client.MixinMinecraftClient,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:architectury.mixins.json:MixinMinecraft,pl:mixin:APP:abnormals_core.mixins.json:client.MinecraftMixin,pl:mixin:APP:magnesium_extras.mixins.json:FrameCounter.FpsAccessorMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.main.Main.main(Main.java:184) ~[minecraft-1.16.5-client.jar:?] {re:classloading,re:mixin,pl:runtimedistcleaner:A,pl:mixin:A,pl:runtimedistcleaner:A}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_341] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_341] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_341] {}
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_341] {}
at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:37) ~[forge-1.16.5-36.2.39-launcher.jar:36.2] {}
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.1.3.jar:?] {re:classloading}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.1.3.jar:?] {re:classloading}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.1.3.jar:?] {re:classloading}
at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.1.3.jar:?] {re:classloading}
at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.1.3.jar:?] {re:classloading}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_341] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_341] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_341] {}
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_341] {}
at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:57) [ForgeWrapper-mmc2.jar:mmc2] {re:classloading}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_341] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_341] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_341] {}
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_341] {}
All the text doesn't show up when it loads, and no worlds seem to load either.
I saw this, but I just don't want to abandon this feature as my modpack always uses one trillion years to start jei when I enter my world.
Can I use "mixin.perf.async_jei=true" in modernfix-mixins.properties to override this?
Besides, I'm also a Modern UI user that can't leave it, but I have NEVER crashed with it (and with ModernFix since it first released at Jan 5, 2023) in my 300+ mods' modpack. My modpack don't have a need for strongholds and I have disabled them a long time ago so I can't tell anything with this. But A0000Xz is surely using a old version of Modern UI (here) and it must have bug(s). So I wonder if you could think about it again, should we really abandon "mixin.perf.async_jei" for an older version of Modern UI?
ModernFix 1.4.4 and below still worked with it, but using the new ModernFix 1.5.0 results in Dynamic Surroundings throwing a java.lang.ExceptionInInitializerError:null error. Not sure if this can be solved on your end, but it did work before. Would be a shame to not be able to use both at the same time, as I found that ModernFix speeds up my loading by a ton.
Bugreport attached
crash-2023-01-28_18.46.01-fml.txt
When I press esc to open the menu the game crashes, so perhaps something involving the UI? If it is just ModernFix and Essential it works but I believe a combination of mods involving ModernFix is causing the issue from when I was trying to disable mods. I am having trouble narrowing down the exact combination though. Is there a mixin I could disable that might fix the issue? I am using the 1.16 required arguments for Java 17 if that helps. Crash log https://paste.ee/p/cKncu Full Log https://paste.ee/p/jienX
Forge 36.2.39
1.16.5
1.10.1
Note: Conflict with Lightspeed. I am reporting this problem to the developers of both mods.
Description: Rendering overlay
net.minecraftforge.fml.ModLoadingException: AstikorCarts (astikorcarts) encountered an error during the enqueue_imc event phase
§7java.lang.IllegalStateException: Rendersystem called from wrong thread
Latest: https://pastebin.com/0GHZB1MF Spam hell was cut to max size
Crash Report: https://pastebin.com/ex8AvGih
Using the newest release for 1.18.2, forge loader 40.2.0
I found (in the source file) that some mixin rules, like "feature.reduce_loading_screen_freezes", are disabled by default. But meanwhile, I cannot know whether a option is enabled, disabled or varied through modernfix-mixins.properties. I think adding something like "= value" will be helpful.
EDIT: I checked the ModernFixEarlyConfig.java again, and find writer.write(key + "=" + value + "\n");
. Strangely, this code doesn't seem to be working.
EDIT_AGAIN: I regenerated those config files twice, but the options are still not shown.
modernfix: 1.9.0-2-g84ba47f
latest.log
Infinite freeze, no crash.
Tried using this mod for the first time in 1.19.2. Everything was going well up until I noticed that there's an issue in which every single entities, from mobs until block entities e.g chest are invisible, maybe you could investigate this bug?
Does this affect server latency? If so, is it possible to fix it?
[Worker-Main-14/ERROR] [ModernFix/]: Can't read structure java.io.FileNotFoundException: ctov:structures/village/mountain_alpine/deco/copper_golem.nbt
modernfix-mc1.19.2-3.2.1
能否兼容optifine
forge1.16.5
Minecraft completly breaks when using the mod, removing it completly fixes the issue. I am running FTB Academy 1.16 with a few performance mods (all of which should be compatible, at least they worked in 1.7 and prior). modlist
I am using modernfix 1.9, updated from 1.7
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.