embarkstudios / blender-tools Goto Github PK

Describe the bug
After running the "auto-update" option when a new version is released, Blender may crash after the addon has been updated.

To Reproduce
Steps to reproduce the behavior:

1. Install an older release of the Embark Addon (e.g. 1.6.0)
2. Click on Embark -> Check for Updates...
3. Click Update when prompted that a newer version is available
4. Blender may crash after the notification is dismissed

Expected behavior
Blender does not crash, and the Addon is updated and reloaded.

Device:

• OS: Windows 10
• Blender Version: 2.82

Describe the bug
Attempting to export collections does not create files in the correct place, without any error. If there are files produced, I do not know where.

To Reproduce
Steps to reproduce the behavior:

1. Install plugin
2. Set project directory to a directory above the current file
3. make an export collection and try to export it

Expected behavior
an fix file is produced at the chosen path

Screenshots

Device:

• OS: macOS Catalina
• Blender 2.82

Additional context
Is this due to the backslash at the beginning of the file path? I don't know why thats there but it must be escaping something, and I cant delete it, the plugin puts it back

Is your feature request related to a problem? Please describe.
When working on addon development, it would be useful to cleanly reload the entire Embark Addon module and add-on without restarting Blender.
This would also be useful if it can be used for reloading the add-on after an update.

Describe the solution you'd like
Using importlib seems like a common approach to reload the module and its submodules. The reload order is important, though, since imports may try to bring in objects from submodules that haven't been reloaded yet.

Describe alternatives you've considered
The obvious alternative is just telling people to always restart Blender, but this isn't great for iteration when developing, or the user experience when updating.
However, if we want to hot-reload, it must be reliable!
We are currently in a somewhat unstable middle-ground, where the addon may fail to reload after certain types of updates, and then the user needs to restart Blender anyway.

Additional context
There is a commented-out section in the reload_addon() method defined i then utils submodule - during testing this was causing Blender crashes. It may need to move somewhere else (e.g. main module initialization).
There is also the bpy.ops.script.reload() operator from Blender, but this does not fully reload the entire add-on module, only the top-level init.py.

Describe the bug
Skeleton/armatures won't get exported with FBX.

To Reproduce
Steps to reproduce the behavior:

1. Create a skeletal mesh export collection with an armature
2. Export it
3. It won't have a skeleton

Expected behavior
Export should contain the skeleton.

Device:

• OS: Windows 10
• Blender Version: 2.91

Additional context
I suspect the export settings is at fault:

def export_fbx(filepath):
    """Export an FBX with standardized settings."""
    return bpy.ops.export_scene.fbx(
        filepath=filepath,
        check_existing=False,
        use_selection=True,
        global_scale=1.0,
        apply_unit_scale=True,
        apply_scale_options='FBX_SCALE_NONE',
        bake_space_transform=True,
        object_types={'EMPTY', 'MESH', 'OTHER'}, # <-- Shouldn't this contain 'ARMATURE' as well?
        use_armature_deform_only=True,
        mesh_smooth_type='FACE',
        add_leaf_bones=False,
        embed_textures=False,
        axis_forward='-Z',
        axis_up='Y',
    )

I'll have a fix for this in my fork if this is in fact a bug.

Describe the bug
A clear and concise description of what the bug is.

After installing the addon, when I try to click and Enable v1.7.0 of the addon, I receive the following error:

Traceback (most recent call last):
File "C:\Program Files\Blender Foundation\Blender 2.90\2.90\scripts\modules\addon_utils.py", line 382, in enable
mod.register()
File "C:\Users\evans\AppData\Roaming\Blender Foundation\Blender\2.90\scripts\addons\blender-tools-main_init_.py", line 37, in register
register_recursive(REGISTER_CLASSES)
File "C:\Users\evans\AppData\Roaming\Blender Foundation\Blender\2.90\scripts\addons\blender-tools-main\utils_init_.py", line 60, in register_recursive
register_recursive(obj.REGISTER_CLASSES)
File "C:\Users\evans\AppData\Roaming\Blender Foundation\Blender\2.90\scripts\addons\blender-tools-main\utils_init_.py", line 56, in register_recursive
bpy.utils.register_class(obj)
ValueError: register_class(...): already registered as a subclass 'EmbarkAddonPreferences'

To Reproduce
Steps to reproduce the behavior:

1. Go to Addons
2. Click Install, and select from disk the latest 1.7.0 zip file of the Embark Addon
3. Click Enable checkbox for addon
4. See error

Expected behavior
Addon to install with no error message.

Screenshots

Device:

• Windows 10
• Blender Version 2.90.1

Additional context
n/a