Code Monkey home page Code Monkey logo

Comments (9)

peterbecich avatar peterbecich commented on June 12, 2024 4

Thanks @jcazevedo , I have solved it temporarily by adding

(require 'treemacs-extensions)

to init.el

from lsp-metals.

jcazevedo avatar jcazevedo commented on June 12, 2024 2

The old API is there, just not loaded by default. Requiring treemacs-extensions explicitly seems to fix this for the time being. I opened #85 proposing that.

from lsp-metals.

PRESFIL avatar PRESFIL commented on June 12, 2024 2

#85 merged.

from lsp-metals.

erickisos avatar erickisos commented on June 12, 2024 1

I recently did a fresh install of doomemacs again but realized that I was facing this issue.
I am not sure if it's just related to scala/metals, maybe I can do a quick search on all the lsp/extensions of doom-emacs to know which ones are working with this deprecated API.

Just came here to know what do you think? Should we check if there are any other plugins being affected?

from lsp-metals.

eamonnsullivan avatar eamonnsullivan commented on June 12, 2024

The issue goes away if I roll back treemacs to commit 76807be. So what I think might be happening is that lsp-metals is using a symbol that has been removed, just in the last couple of days.

This suits as a workaround -- I'll just pin treemacs to an older commit. But it might be a good heads up for the next release.

from lsp-metals.

eamonnsullivan avatar eamonnsullivan commented on June 12, 2024

Probably related issue on treemacs here.

from lsp-metals.

eamonnsullivan avatar eamonnsullivan commented on June 12, 2024

Final note on this, it looks like treemacs-define-leaf-node-type is the intended replacement for this obsolete macro, but the arguments are different enough that I couldn't come up with a patch without knowing a lot more about how this is being used.

from lsp-metals.

peterbecich avatar peterbecich commented on June 12, 2024

Could we do what this comment describes to solve this?

;;
;; We can possibly remove the leaf node definition and
;; replace lsp-metals-treeview--state to return treemacs-metals-node-closed-state
;;
(treemacs-define-leaf-node metals-leaf 'dynamic-icon
:ret-action #'lsp-metals-treeview--exec-node-action
:mouse1-action (lambda (&rest args)
(interactive)
(lsp-metals-treeview--exec-node-action args)))

from lsp-metals.

Kazark avatar Kazark commented on June 12, 2024

I got bit by this too.

from lsp-metals.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.