Eager macro-expansion failure about lsp-metals HOT 7 OPEN

I met the same error and I'm also on Emacs 29. It seems some upstream changes broke some function in lsp-metals-treeview.el.

@thoradam Which commit of Emacs 29 are you using (and has this problem)? And which commit is good? I could do a git bisect to find which commit is responsible for this problem.

from lsp-metals.

@VitalyAnkh I installed Emacs from the Homebrew emacs-plus formula:

    "tap": "d12frosted/emacs-plus",
    "tap_git_head": "4b34ed7402a4f3e1f212b2c6fa0851f4b59e247c",

Unfortunately this is my first time using Emacs with lsp-metals so I don't have a working commit for reference.

from lsp-metals.

Treeview is broken after breaking the change in treemacs. It should be disabled until this is fixed.

from lsp-metals.

what is the status of this? what is the recommended work around until fixed (one which lets you continue to use metals)?

from lsp-metals.

This patch for the treemacs package works for me:

diff --git a/src/elisp/treemacs-treelib.el b/src/elisp/treemacs-treelib.el
index d30c8c6..9825fbf 100644
--- a/src/elisp/treemacs-treelib.el
+++ b/src/elisp/treemacs-treelib.el
@@ -1018,7 +1018,7 @@ ARG: Prefix Arg"
    :post-close-action
    (treemacs-on-collapse (treemacs-button-get btn :path))))
 
-(cl-defmacro treemacs-initialize
+(cl-defmacro treemacs-initialize-ext
     (extension
      &key
      (with-expand-depth 0)

It seems that lsp-metals wants to call the other treemacs-initialize so renaming this one to something else fixes the issues at least for lsp-metals.

from lsp-metals.

Does it stop work completely? For me lsp-metals works fine after this error happens.

from lsp-metals.

It stopped working in the latest Emacs (snapshot) due to the commit emacs-mirror/emacs@80cf13a

eager expansions is now error not warning.

Related issue: emacs-lsp/lsp-mode#3738

from lsp-metals.