emacs-ess / ess-stata-mode Goto Github PK

in a conditional or for loop inside braces { } , do not automatically indent as they used to

Commands are duplicated in the output. Setting comint-process-echoes to t, or changing ess-eval-visibly seems to have no effect.

In an XFCE-terminal, Stata doesn't duplicate output. In an Emacs shell, it does, but it responds to comint-process-echoes. In ESS it duplicates but does not respond to comint-process-echoes.

Since updating to the latest ess version from MELPA (20210331.804), sending a line of code from a .do file to the iESS buffer causes it to hang. If I copy and paste a line, or manually type in a command, it seems to run fine.

Comments starting with "^// " correctly cause font-lock-comment-face to be applied, but it doesn't terminate at EOL. That is, comment-face continues until it hits " */" (or to EOB).

I had trouble rendering font colors in .do files.

Turns out the problem was ess-stata-lang.el, which defines font-lock-reference-face, which has been marked obsolete for awhile. When I replaced font-lock-reference-face with font-lock-constant-face, things started working again.

ess-synchronize-dirs causes an error because (ess-command ess-getpwd-command) fails. That fails because Stata echoes the command in the *ess-get-words* buffer used by ess-command.

Two possibilities:
1: remove ess-synchronize-dirs from ess-idle-timer-functions and do without the functionality
2: edit ess-command to check comint-process-echoes and behave accordingly.

Option 1 is easy. Option 2 is better but more difficult, as the existing code seems to be written without taking the possibility of echoed input into account.

inferior-ess-prompt doesn't work in for-loops, where the prompt takes this form:

forvalues x=1/2 {
  2. 

Changing ess-stata-mode.el from

(inferior-ess-prompt           . "\\([.:>] \\|--more--\\)")

to

(inferior-ess-prompt           .  "\\( *[0-9]*[.:>] \\|--more--\\)")

resolves the problem (but I haven't tested much for unintended consequences).