Code Monkey home page Code Monkey logo

teckle's Introduction

Jenkins Status Lines of Code

Logo

>> Downloads << Reviving old ideas since 2017.

This mod is open source and under a permissive license. All Elytra mods are, and as such, can be included in any modpack on any platform without prior permission. We appreciate hearing about people using our mods, but you do not need to ask to use them. See the LICENSE file for more details.

teckle's People

Contributors

acgaming avatar coderbot16 avatar darkevilmac avatar falkreon avatar unascribed avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

teckle's Issues

Implement restriction tubes

Restriction tube are tube which act like regular tubes except object routing considers them as an infinite length.

Restriction tubes can be colored as regular tubes.

Transposer doesn't pull

Using Minecraft 1.12.2, Forge 14.22.0.2463, Teckle 1.12-5.378-SNAPSHOT.

When activating a transposer, it doesn't pull an "OH SHIT TECKLE BROKE" message appears in the log. The item might or might not get removed from the attached inventory.

Log: https://hastebin.com/ejabicapuw.md

Alloy smelter only smelts 7.9-ish items from one piece of coal

Issue Description:

Smelting items in the alloy furnace with coal only processes 7 full items, and doesn't complete the 8th. It never burns more coal until you place in more processable items, and thus the 8th item will never complete without adding a 9th or further item.

How to reproduce:

Place stack of coal in fuel slot
Place enough items for 8 recipe runs in input slots (for example, 8xSand -> 8xGlass)
Only 7 glass are produced, the 8th sand is consumed but the progress stops short of producing the 8th glass
Place another sand in the input, and the 8th glass will output almost immediately

Affected Versions (Do not use "latest"):

  • Teckle: 0.6.470
  • Forge: 14.23.5.2768
  • Minecraft: 1.12.2

Game freezes if you load the world while items are being pulled out

Using Minecraft 1.12.1, Teckle version git-3e6dac6, Forge 14.22.0.2452

Crash log: https://gist.github.com/MRebhan/a01f55d45e9dc8d56245765b5ad4f39b

This might actually be my Sortron block causing it as I was using it to continuously pull out items. I doubt it though, since the stacktrace doesn't show my mod at all.

EDIT: Looks like this is indeed caused by my mod, I don't know by what though. It doesn't happen with the sorting machine. Do you have an idea?

EDIT2: It does happen with the sorting machine too. Same stack trace.

Item tubes are not compatible with ProjectRed frames

Issue Description:

Trying to move a ProjectRed frame with an adjacent Teckle item tube results in an exception printed.

This appears to be 2 issues in one:

  1. TileNetworkMember#getCapability seems like it crashes because The One Probe is not installed? Or for some reason, TileNetworkMember$ProbeCapabilityis not getting emitted into the generated JAR file.
  2. TileNetworkMember or any associated tile does not support IRelocationAPI.FRAME_CAPABILITY / IFrame

What happens:

Exception dumped to crash log

What you expected to happen:

Item tube is moved along with the frame

How to reproduce:

Recreate the following setup (in image) and then flip the lever:
2018-12-16_12 49 10

Affected Versions (Do not use "latest"):

  • Teckle: 573b85d (bleeding edge w/ CraftTweaker support)
  • Forge: 14.23.5.2768
  • Minecraft: 1.12.2

Crash report, if relevent

Non-fatal exception printed to log:
https://gist.github.com/coderbot16/ef1b6083c25051979806718060445901

Teckle Block breaker causes server crash

Issue Description:

What happens:

It crashes on load until i remove teckle

What you expected to happen:

It to load

How to reproduce:

Load the Server? Crash

Affected Versions (Do not use "latest"):

  • Teckle: Teckle-1.12-0.6.471
  • Forge: 2847
  • Minecraft: 1.12.2

Crash report, if relevent

https://pastebin.com/sUC58UiR

Alpha 3x10e-4 jar doesn't start

It crashes on line 62 because the json files are somehow not in the jar

net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Teckle (teckle)
Caused by: java.lang.ExceptionInInitializerError
	at com.elytradev.teckle.client.proxy.ClientProxy.registerRenderers(ClientProxy.java:36)
	at com.elytradev.teckle.common.TeckleMod.onPreInit(TeckleMod.java:54)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraftforge.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:641)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
	at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
	at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
	at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
	at com.google.common.eventbus.EventBus.post(EventBus.java:275)
	at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:252)
	at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:230)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
	at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
	at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
	at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
	at com.google.common.eventbus.EventBus.post(EventBus.java:275)
	at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:147)
	at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:647)
	at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:276)
	at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:440)
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:352)
	at net.minecraft.client.main.Main.main(SourceFile:124)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:236)
	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:297)
	at org.multimc.EntryPoint.listen(EntryPoint.java:162)
	at org.multimc.EntryPoint.main(EntryPoint.java:53)
Caused by: java.lang.NullPointerException
	at java.io.Reader.<init>(Reader.java:78)
	at java.io.InputStreamReader.<init>(InputStreamReader.java:113)
	at org.apache.commons.io.IOUtils.copy(IOUtils.java:1906)
	at org.apache.commons.io.IOUtils.toString(IOUtils.java:778)
	at org.apache.commons.io.IOUtils.toString(IOUtils.java:759)
	at com.elytradev.teckle.repack.concrete.resgen.ConcreteResourcePack.<clinit>(ConcreteResourcePack.java:62)
	... 46 more

Tubes wont transport items to chest from charset storage chest mod

Issue Description:

as described in title

What happens:

i had tube (including transposer setup) connected to macerator from ic2 to a chest from charset. nothing was coming out. I swapped out the tubes from teckle with the pipes from quark oddities and the items came out as expected

What you expected to happen:

i expected the tube with transposer to pull out item and transport it to the chest from charset

How to reproduce:

as stated above.

Affected Versions (Do not use "latest"):

  • Teckle: Teckle-1.12-0.6.470
  • Forge:14.23.4.2759
  • Minecraft:1.12.2

Crash report, if relevent

[pastebin/gist link here]

Transposer/Block Breaker doesn't pick up items from fluid

Issue Description:

Transposer/Block Breaker doesn't pick up items contained in fluid, which it should.

How to reproduce:

Throw items into a fluid stream pointed into the collection hitbox of a transposer/block breaker, and the block doesn't pick the items up, even with a redstone signal.

2018-10-23_23 58 42

2018-10-24_00 04 55

The above tests have been tried on both a Block Breaker and a Transposer and they both operate the same way.

Affected Versions (Do not use "latest"):

  • Teckle: 0.6.470
  • Forge: 14.23.5.2768
  • Minecraft: 1.12.2

Transposer wont transfer due to dropping items

Issue Description:

When you drop a item in the transposer with tubes connected to a chest it jams up. Breaking the chest drop the item.

Keep note when a transposer is right on the chest it still gum up.

What you expected to happen:

I expect it to transfer to the chest

How to reproduce:

Install the mod
Set up piping
Drop item into transposer

Affected Versions (Do not use "latest"):

  • Teckle: .470 [Reproduced with older builds]
  • Forge: .2770 [Reproduced with older forges]
  • Minecraft: 1.12.2

Crash report, if relevent

null

Teckle ripping holes in the fabric of spacetime

java.util.concurrent.ExecutionException: java.lang.NullPointerException
        at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_131]
        at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_131]
        at net.minecraft.util.Util.func_181617_a(SourceFile:47) [h.class:?]
        at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1046) [bes.class:?]
        at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:372) [bes.class:?]
        at net.minecraft.client.main.Main.main(SourceFile:124) [Main.class:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_131]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_131]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_131]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_131]
        at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
        at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
Caused by: java.lang.NullPointerException
        at com.elytradev.teckle.common.worldnetwork.common.WorldNetworkDatabase.getSavedDatabase(WorldNetworkDatabase.java:134) ~[WorldNetworkDatabase.class:?]
        at com.elytradev.teckle.common.worldnetwork.common.WorldNetworkDatabase.getNetworkDB(WorldNetworkDatabase.java:122) ~[WorldNetworkDatabase.class:?]
        at com.elytradev.teckle.common.tile.TileItemTube.func_145839_a(TileItemTube.java:179) ~[TileItemTube.class:?]
        at net.minecraft.tileentity.TileEntity.handleUpdateTag(TileEntity.java:331) ~[asc.class:?]
        at net.minecraft.client.network.NetHandlerPlayClient.func_147263_a(NetHandlerPlayClient.java:745) ~[bno.class:?]
        at net.minecraft.network.play.server.SPacketChunkData.func_148833_a(SourceFile:96) ~[gw.class:?]
        at net.minecraft.network.play.server.SPacketChunkData.func_148833_a(SourceFile:18) ~[gw.class:?]
        at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) ~[fo$1.class:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_131]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_131]
        at net.minecraft.util.Util.func_181617_a(SourceFile:46) ~[h.class:?]
        ... 9 more

image

(This is interrupting the initial chunk load tile entity reading, and breaking everything. pls fix)

Ideas

Things to add: Crafting utilities, like a crafting table with a built in chest, and a device to craft things in an assembly line fashion.

Chisel Recipe Conflict

As of Teckel Version 1.12-1.338, the Preciso Blade recipe conflicts with the Iron Chisel recipe from... well, Chisel. I've got no idea if this has since been fixed (Running it on a server, haven't got time for the mod updates yet today)

In either case, probably something you should know. Apologies if this has been fixed already.

Decouple Tiles from Network Tiles

Now that serialization stores all node data it makes sense to remove any references to tile entities during initial serialization. Tile entities can still reference the nodes on loading but a some changes need to be made.

  • Setup a forge registry for network tiles/types of nodes so they can be instantiated without a direct reference to an unloaded tile entity.
  • Network tiles will need their own serialization and deserialization code
  • Probably something else I can't think of

Transposer & Block Breaker "grabbing items from world" hitbox doesn't reach front of block

Issue Description:

Throwing items in front of transposer/block breaker only picks up ones that are farther than ~0.5 blocks from the block and less than ~1.5 blocks from the block.

What happens:

Items are picked up only if they don't hit the face of the transposer/block breaker.

What you expected to happen:

Items are picked up if they hit the face of the transposer/block breaker.

How to reproduce:

Throw items in front of transposer/block breaker at varying distances, note which ones are immediately picked up and which ones aren't.

In the following image, note that any items thrown between the two visible piles will be immediately picked up.

2018-10-23_23 52 11

Note that it also appears to be offset 0.5 blocks in the -x direction

2018-10-24_00 02 06

The above tests have been tried on both the Transposer and the Block Breaker, they operate the same way.

Affected Versions (Do not use "latest"):

  • Teckle: 0.6.470
  • Forge: 14.23.5.2768
  • Minecraft: 1.12.2

Crash on world load containing sorting machine

Hi,

I've had this issue where every time I would place a sorting machine into my world and reload that world, the game would crash. I would be able to load back into the world, but my sorting machines would reset and upon quitting the world and reloading, the crash would occur again. I have my sorting machines set up in this manner: https://i.imgur.com/SCMo1Gw.png. This doesn't occur when the machines are set up so one machine into several different colours, but i would like a large variety of items in one chest at once.

I am playing on Minecraft 1.12.2 and using Teckle verion 1.12-5.394. Here is an example of a crash log due to this bug: https://gist.github.com/Wupp/5a6b49962b28e35483b135bb3218ca1f

Null comparison doesn't make sense

This comparison is bogus, since NBTTagCompound#getUniqueId never returns null. You should compare to UUID(0, 0) instead.

This comparison might be in all other network tile entities, haven't checked.

Any Teckle Machine crashes you on a LAN World ONLY

Issue Description:

I put 3 copper, 1 tin inside the alloy smelter and it kicks the people who joined when it starts running. Breaking the block fixes it, and then can rejoin.

Another example is the transposer when given a redstone signal crashes the other player

Affected Versions (Do not use "latest"):

  • Teckle: Teckle-1.12-0.6.470.jar
  • Forge: 2770
  • Minecraft: 1.12.2

2 Server friendly suggestions

Feature description.

First suggestion make it so the beam quarry doesn't dump items on the ground when the internal buffer fills up.

Feature functionality

The quarry would stop at it's current digging location and wait for room in the inventory. While just using the tubes is the best solution for item output making it just dump items into the world would be a lag hazard.

Does this feature involve mod compatability, if so, which mods

no

Feature description.

Second suggestion would be to add in the relay. Something a hopper or another mod's systems could dump items into which in turn get ejected into the tubes.

Feature functionality

Single block that accepts items and ejects them into the connected tubes.

An important reason to have this would be to not require redstone pulses to import items into the tubes. Sorting machine, item filter and transposer all need redstone pulses to import items. A few of these will be fine. Hundreds will be massive lag.

Does this feature involve mod compatability, if so, which mods

Vanilla: hoppers
Thermal expansion: ducts
integrated dynamics: tunnels
Something other mods will interact with like a chest inventory.

Transposer and Filters fail to push items but still consume the item

Every time a transposer or item filter tries to suck up items from one inventory and push them out into another inventory or tube, it throws a NullPointerException and just deletes that item.

[17:50:39] [Server thread/ERROR] [teckle]: ****************OH SHIT TECKLE BROKE*******************
[17:50:39] [Server thread/ERROR] [teckle]: Caught NPE in tryPush!, com.elytradev.teckle.common.tile.TileTransposer@3d6dc165
[17:50:39] [Server thread/ERROR] [teckle]: Exception follows, java.lang.NullPointerException
[17:50:39] [Server thread/ERROR] [teckle]: Here's some useful debug info, NTile com.elytradev.teckle.common.tile.networktiles.NetworkTileTransposer@1e8fe863 node WorldNetworkNode{position=BlockPos{x=527, y=4, z=74}, capabilityFace=null} network WorldNetwork{nodeCount=6, travellerCount=0, worldID=0}
[17:50:39] [Server thread/ERROR] [teckle]: ****************OH SHIT TECKLE BROKE*******************

So items will be sucked up correctly from the inventory on the input side, but will never emerge from the output side.

I was able to reproduce this error with a modlist containing only:
Minecraft 1.12.1
the latest Forge, 14.22.0.2467
the latest Teckle, 5.378
the latest IndustrialCraft, 2-2.8.16-ex112 (to provide the necessary ores)
and JEI.

Trying to remove IC2 caused the game to fail to load due to Teckle not being able to find critical ores, so I could not absolutely confirm that the problem was due to Teckle alone.

Make Teckle use Vanilla Materials?

I don't really see much reason for this mod to require its own world generation, or any kind of materials beyond what's available in vanilla. At very least, it would be nice to make it not require Substratum, so that we can modtweak it ourselves to use vanilla materials without needing to add bloat to a modpack...

Alloy Smelter making Brass has a weird OreDict

Issue Description:

Making brass works with alot of metals coppers and tin, except project reds.

What happens:

It doesnt make brass

What you expected to happen:

it makes brass

How to reproduce:

install project red, put their copper and tin in.

Affected Versions (Do not use "latest"):

  • Teckle: latest ( the fancy one)
  • Forge: 2770
  • Minecraft: 1.12.2

Current repo description painfully ironic

Currently, the repo description includes the phrase "A tech mod that actually updates." I suggest removing this sentence until if and when development resumes, as it is currently painfully untrue.

Redstonesignal on tubes

Feature description.

image
Like in RP you should be able to transport a redstone signal over the tubes

Does this feature involve mod compatability, if so, which mods

No other mods needed

Filter does not work with single item

Issue Description:

If I put a single item in the filter, a whole stack of such item will be extracted instead of one.

Affected Versions (Do not use "latest"):

  • Teckle: 0.6

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.