Code Monkey home page Code Monkey logo

Comments (8)

josevalim avatar josevalim commented on July 17, 2024 1

Ping me once you patched both and I can do it. :)

from ex_doc.

josevalim avatar josevalim commented on July 17, 2024 1

makeup_erlang is out, i don't have permission for makeup_html, i will ask.

from ex_doc.

josevalim avatar josevalim commented on July 17, 2024

We don't need to release a new ex_doc, because if users do mix deps.update, they will get the latest versions of its deps. So nothing to be done here but PRs to remove the warnings from makeup_* are welcome. :)

from ex_doc.

paulo-ferraz-oliveira avatar paulo-ferraz-oliveira commented on July 17, 2024

they will get the latest versions of its deps

This is interesting to know. I'm still learning the ins and outs of mix 😄 Thanks, @josevalim.

from ex_doc.

paulo-ferraz-oliveira avatar paulo-ferraz-oliveira commented on July 17, 2024

Sorry for coming back to this :(, but I still have these compilation warnings from ex_doc:

==> makeup_erlang
Compiling 3 files (.ex)
warning: Application.get_env/3 is discouraged in the module body, use Application.compile_env/3 instead
  lib/makeup/lexers/erlang_lexer.ex:250: Makeup.Lexers.ErlangLexer

==> makeup_html
Compiling 5 files (.ex)
warning: Application.get_env/3 is discouraged in the module body, use Application.compile_env/3 instead
  lib/makeup/lexers/html_lexer.ex:135: Makeup.Lexers.HTMLLexer

(which are not found in the dependencies themselves)

Are they not because doing mix deps.update makeup_erlang/html has no effect in mix.lock (ni ex_doc or elsewhere)? (because the latest makeup_* have not been tagged/released?)

Edit: ... which, e.g., would be the same that's happening from stream_data:

==> makeup_erlang
Compiling 3 files (.ex)
warning: Application.get_env/3 is discouraged in the module body, use Application.compile_env/3 instead
  lib/makeup/lexers/erlang_lexer.ex:250: Makeup.Lexers.ErlangLexer

from ex_doc.

josevalim avatar josevalim commented on July 17, 2024

makeup_erlang/makeup_html have to be released with fixes first. But it is entirely up to them, ExDoc doesn't play a role. :)

from ex_doc.

paulo-ferraz-oliveira avatar paulo-ferraz-oliveira commented on July 17, 2024

Understood, and as expected. Shall I request releases (no pressure, though), or do maintainers usually get around to those?

from ex_doc.

paulo-ferraz-oliveira avatar paulo-ferraz-oliveira commented on July 17, 2024

makeup_html was already patched and merged.
makeup_erlang was not patched because it wasn't required, but it could do with a release :)

Thanks.

from ex_doc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.