Comments (8)
@josevalim mmm I disagree here, because:
I was looking at PartitionSupervisor in Elixir, for example, and had to scroll through functions to know that all the functions were added in Elixir 1.14, which made me realize the whole module was added in Elixir 1.14
I think this is a pretty big DX deal. Considering this feature is visually a really tiny addition, are we sure we want to let it go? 😬
from ex_doc.
We typically don't automatically add sentences. If that's a concern, then Elixir can add it directly to its docs. I would personally wait, there is no reason to rush and churn.
from ex_doc.
I would like implementing this, but I'm not sure how this should look like :/
I did some experimentation locally but couldn't find a way that looks nice
- maybe adding it on the right, but there's no background as opposed to the functions
- maybe adding in a box below, similar to the deprecation message
from ex_doc.
I will go ahead and say no on this one because, we would still need to propagate it, as someone can still be linked directly to the function, so I am not that sure the additional information and clutter is worth it, given we propagate and refer to it on all entries too. :)
from ex_doc.
I think it would be a nice addition and it looks good in this particular case. Here's a mockup:
But it can get really busy:
so yeah not sure.
from ex_doc.
What about something like "This module is available since v..." as the first sentence of the module doc, styled slightly different?
from ex_doc.
Our goal is to move the search bar into the main page and, when we do so, we might move the cog icon, making it more or less cluttered, but I think right now is not the time for this. We can reevaluate in the future.
from ex_doc.
@josevalim maybe we can out a solution for this and then re-evaluate when we do the changes you just mentioned? Like, we go with the sentence at the start of the moduledoc to get the feature and info to users, and then re-evaluate. 🙃
from ex_doc.
Related Issues (20)
- Add syntax highlighting for JavaScript/TypeScript HOT 3
- links for otp apps' (gen_tcp/ssl) types use old format HOT 4
- Bullet list not displayed correctly HOT 4
- Better integrate Erlang/Elixir
- Mobile: Search bar is too sensitive to page scroll HOT 2
- Warn about docs for out-of-date versions HOT 1
- Odd Gradient with mobile breakpoint in light mode HOT 1
- feature request: Link to Anchor callback/function auto-links like with Modules and Extra pages
- Possible error when deprecating binaries path for assets HOT 4
- Failure to render links for specs when using Elixir 1.17 or later HOT 1
- No support for debug_info keys? HOT 1
- Search page shows no results even though autocomplete finds them HOT 1
- Signs in integer literals trigger warning HOT 3
- More explicit warning when type not visible because module is not visible HOT 2
- Fail to generate docs due to earmark_parser_string_lexer not available HOT 2
- Remove support for application/erlang+html HOT 4
- Screen reader text obscures search HOT 10
- No information on how to run locally HOT 2
- Admonition blockquotes should be converted to divs HOT 1
- Sidebar missing until mermaidjs finishes loading HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ex_doc.