electron-react-boilerplate / eslint-config-erb Goto Github PK

Any reason why we didnt have this in ERB already?

got this error after upgrade eslint to 8.33.0,please check if there's error in index.js

 'airbnb/hooks',
    ^^^^^^^^^^^^^^

SyntaxError: Unexpected string
    at internalCompileFunction (node:internal/vm:74:18)
    at wrapSafe (node:internal/modules/cjs/loader:1141:20)
    at Module._compile (node:internal/modules/cjs/loader:1182:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
    at Module.load (node:internal/modules/cjs/loader:1081:32)
    at Module._load (node:internal/modules/cjs/loader:922:12)
    at Module.require (node:internal/modules/cjs/loader:1105:19)
    at module.exports [as default] (D:\workspace\electron-react-boilerplate\node_modules\import-fresh\index.js:32:59)
    at loadJSConfigFile (D:\workspace\electron-react-boilerplate\node_modules\@eslint\eslintrc\dist\eslintrc.cjs:2562:47)
    at loadConfigFile (D:\workspace\electron-react-boilerplate\node_modules\@eslint\eslintrc\dist\eslintrc.cjs:2646:20)
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Would appreciate an update to these peer dependencies to remove these warnings if one is at the latest release for each of these packages:

warning " > [email protected]" has incorrect peer dependency "eslint-config-airbnb-typescript@^8.0.2".
warning " > [email protected]" has incorrect peer dependency "eslint-config-prettier@^6.11.0".
warning " > [email protected]" has incorrect peer dependency "eslint-import-resolver-webpack@^0.12.2".
warning " > [email protected]" has incorrect peer dependency "eslint-plugin-jest@^23.13.2".
warning " > [email protected]" has incorrect peer dependency "[email protected]".
warning " > [email protected]" has incorrect peer dependency "react@^16.13.1".

• module for index.js
• module for typescript.js

This repo should be split into two npm packages: eslint-config-erb-javascript and eslint-config-erb-typescript. We need to refactor this project into these two packages

Hi! This upgrade between the two patch versions breaks all imports in the webpack config files in the .erb/configs folder from https://github.com/electron-react-boilerplate/electron-react-boilerplate/tree/main/.erb/configs.

My config files reflect the changes from the latest main from the erb repository. Do you have any idea why a patch could be breaking the imports?

Thanks!

Steps to reproduce:

1. Clone ERB electron-react-boilerplate repo. https://github.com/electron-react-boilerplate/electron-react-boilerplate
2. npm install
3. Upgrade typescript version to latest (4.5.0 or higher)
4. npm run lint

Error Information

PS C:\Projects\electron-builder-test> npm run lint

lint
cross-env NODE_ENV=development eslint . --ext .js,.jsx,.ts,.tsx

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.5.0

YOUR TYPESCRIPT VERSION: 4.5.5

Please only submit bug reports when using the officially supported version.

=============

Problematic Package Location

Looking for the outdated @typescript-eslint/typescript-estree shows that it is within the eslint-config-erb package.

Suggested Solution

Please release a new version of eslint-config-erb with the updated dependencies. Looking at the master branch, it looks like the dependency upgrade work was already done in d1434db.

Hi @amilajack , can you tell me why you are using babel-eslint as dependency?

Please bump the peerDependencies (in the package.json) to stay in sync with the main project electron-react-boilerplate.

E.g. from the package.json in electron-react-boilerplate

"eslint-plugin-jsx-a11y": "6.3.1",

Decorators are not being parsed by flow parser (prettier/prettier#4126), I'm using the boilerplate but I had to modify this configuration (adding babylon parser to prettier) to make eslint work. Am I missing something?

If we use require.resolve, we can extend a config without making it a peerDependency. It doesn't work for plugins though, so we'd need to keep eslint-config-airbnb's peerDependencies.

If it does more, then it should list what that is