electrode-ios / elhybridweb Goto Github PK

Tapping something and holding doesn't do anything (this is correct), but the control also doesn't highlight like it might on iOS. Investigate ignoring tap delay and removing the double-tap gesture from the view entirely.

You tap something, get a white screen (undesirable, its best to see content), the web view is hidden at this point, then shows briefly with the old page, and then the new page flashes on.

I think it would be best to implement this as additional parameters to updatePageState()

Sometimes it is nice to inspect data from JSContext and have that get out to the xcode console.

Example:

NativeBridge.view.setOnAppear(function(backPressed) {
  // view appeared
})

and

NativeBridge.view.setOnDisappear(function() {
  // view disappeared
})

After the “See more stores” seems like sometimes I get just white screen with a nav bar and other times I get back to the checkout but the tab bar has reappeared.
This is on “Done” button tap from the modal after picking a store.

screen shot UIImageView should be gone after re-appearing

A web view requesting a user's location via JavaScript will prompt the user for permission every time the location is requested.

It would be convenient to use the native OS's location so that permission is only requested once and passed into the webview via a js callback.

I propose a fix of either:

1. Updating setButtons() to remove all navigation bar buttons when passed a null or empty array value as the buttons parameter.

or

2. Adding a removeButtons() method that removes all navigation bar buttons.

The web view will not be visible after a navigation.animateForward() call until NativeBridge.view.show() is called.

ex: NativeBridge.navigation.animateForward({tabBarHidden: true})

I believe it is cleaner to use explicit methods instead of relying on index semantics of an array to specify left/right buttons (0/1 index)

The trailing end of the scroll animation stops abruptly.

NativeBridge.tabBar.hide() will hide the tab bar and NativeBridge.tabBar.show() will show it.