elastic / workplace-search-node Goto Github PK

Other than the unit/integration test, use a linter drastically improve the code and helps catch errors in advance, it also makes easier review community pull request :)

I would recommend standardjs, but any linter would work :)

I noticed that the client has no search function. It could for example look like this:
client.search(contentSourceKey, query, options)

Is there a reason it is missing? Will it be implemented in future versions?

The request module went in maintenance mode, therefore it would be better to move to an actively maintained module.
Given that you support a pure promise API and you don't need to support callbacks, I would recommend got, it offers the same features with a native promise API.

Lockfiles are very useful when working with big applications, but are not published on npm.
Which means that your users, you, and your CI, might use different versions of dependencies if you use lockfiles.

As a rule of thumb, I would suggest to always avoid the use of lockfiles on modules that will be published on npm in the future :)