ekmett / ansi-wl-pprint Goto Github PK

The upper bound on ansi-terminal for < 0.8 is causing build issues.

Any reason why there should be an upper bound at all? Or at least, can it be relaxed again?

The current version is 2 years old, and some useful changes were made in the past. I’d like to depend on some of these changes, in particular the exposure of the internals of the Doc type that I recently introduced, in another library. I don’t have maintenance permission on Hackage though, so this goes to the maintainers: New Hackage release please!

Although the ansi-wl-pprint package is marked as 'deprecated' on Hackage, it is still a dependency of optparse-applicative and I am hoping it is still maintained.

ansi-terminal-1.0 was released today. I will raise a pull request.

I just revised https://hackage.haskell.org/package/ansi-wl-pprint-0.6.8/revisions/ because

Configuring ansi-wl-pprint-0.6.8...
Preprocessing library for ansi-wl-pprint-0.6.8..
Building library for ansi-wl-pprint-0.6.8..
[1 of 2] Compiling Text.PrettyPrint.ANSI.Leijen.Internal ( Text/PrettyPrint/ANSI/Leijen/Internal.hs, dist/build/Text/PrettyPrint/ANSI/Leijen/Internal.o )
[2 of 2] Compiling Text.PrettyPrint.ANSI.Leijen ( Text/PrettyPrint/ANSI/Leijen.hs, dist/build/Text/PrettyPrint/ANSI/Leijen.o )

Text/PrettyPrint/ANSI/Leijen.hs:169:10:
    The fixity signature for `<>' lacks an accompanying binding
      (You cannot give a fixity signature for an imported value)
cabal: Failed to build ansi-wl-pprint-0.6.8

And in fact, Travis CI only tests back to GHC 7.4.2

#14 increased the upper version bound of ansi-terminal; @TomMD requested a new release in a code comment.

@hvr, before I do it – revision or patch level bump? :-)

Since the <$> from Data.Functor is now in Prelude, renaming <$> to something else would be helpful. One might also rename <$$> to match.

Something like <#> and <##>, maybe?

in the haddock of Text.PrettyPrint.ANSI.Leijen

https://hackage.haskell.org/package/prettyprinter

See #18

ansi-wl-pprint may or may not receive (timely) updates.

The docs say that putDoc and displayIO wrap with line length of 80 characters, but it doesn't seem to be doing that for me. The following doesn't wrap at all:

putDoc "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur."

There is an orphan in Trifecta, but I don't see any reason why it cannot be here.

Happy to do a PR (for both, ansi-wl-pprint, and trifecta).

The link in the README is no longer accessible (http://batterseapower.github.com/ansi-wl-pprint)

Now that prettyprinter is out and relatively stable, perhaps it would be best to direct would-be users of ansi-wl-pprint to that library instead, since at least IMO it represents a more modern approach. AFAICT this wouldn't break anyone's code; it would just discourage newbies from using ansi-wl-pprint.

Tagging @quchen in case he intends to make breaking changes to prettyprinter and in case there are any issues with prettyprinter that prevent it from being a full-featured replacement for ansi-wl-pprint.

(also, I think this should go without saying, but I'm not trying to shit on ansi-wl-pprint or any of the work its maintainers have done, I think it is a relatively well-engineered library that has served the Haskell ecosystem well)