eikonomega / django-notification-system Goto Github PK

View Code? Open in Web Editor NEW

14.0 14.0 9.0 1.24 MB

Want to send notifications from your Django app? Start here.

License: MIT License

Python 100.00%

django-notification-system's People

Contributors

Stargazers

Watchers

Forkers

lifacciolo barseghyanartur secureonelabs ghaffari-nia crcresearch zackchofficial leifdenby chris-tn phutoan31299

django-notification-system's Issues

Add installation instructions to documentation.

Make sure that `setup.cfg` is ready prior to initial PyPi release.

Add MessageBird Email backend

It would be great to have a MessageBird Email backend.

Make code align with Post-Install instructions...

NOTIFICATION_SYSTEM_TARGETS={
  "twilioSMS": {
    "accountSID": "Your Twilio SID",
    "authToken": "Your Twilio Token",
    "sender": "Your Twilio Number"
  }
}

I think that some of the model names could be clearer and would like to propose the following changes.

Target -> NotificationTarget
OptOut -> NotificationOptOut
UserTarget -> UserInNotificationTarget

Assignees:
Labels: enhancement

Add links to docs.

Find all the places where the docs reference @branks42.
Add links requested.
Thank you!

Assignees: @branks42
Labels: documentation

How to provide Email Templates?

I have not yet managed to include an email template via the extra dict.

I am creating a Notification object like this:

User = get_user_model()
user = User.objects.get(first_name="Eggs", last_name="Benedict")

someval = 'something'

create_notification(
        user=user,
        title='Email Title Text',
        extra={
            "someval": "someval",
            "template_name": "eggs_email_template.html"
        }
    )

The template HTML file is in the correct directory (also tried some random possibilities).
If I specify only the template_name, it does not throw an error, but it also does not create a notification. If I specify other context values in the extra dict , I get the following error:

render() got an unexpected keyword argument 'someval'

Could you please provide an example of how to include templates?

Find a way to install requirements during pip install of our package.

Add MessageBird Whatapp backend

It would be great to have a MessageBird Whatsapp backend.

Setup Github action to automatically run unit tests on all pull requests.

Rename `UserHasNoTargets` exception to `UserHasNoTargetRecords`

This brings it in line with new model names.

Assignees:
Labels: good citizen

Support sending notifications to multiple targets at once

Thanks for the package. It would be great to have an option to send a single notification to multiple targets at once (to email and expo, for instance).

Problems with newer versions of exponent_server_sdk (>=1.0.0)

I recently noticed an error on a fresh installation of my django application:
cannot import name 'PushResponseError' from 'exponent_server_sdk' (/app/.heroku/python/lib/python3.8/site-packages/exponent_server_sdk/__init__.py)

After a little research I found out that the exponent_server_sdk package has undergone some changes regarding the PushResponse class. I am not really familiar with this SDK and Expo but as far as I can see, the class got renamed to PushTicket in 1.0.2 and returns a message ID since 1.0.0. In my case I got exponent_server_sdk 2.0.0 installed and am now facing an ImportError because django-notification-system still uses the old class name.

Due to the changes in setup.py, this leads to an error when version 1.0.0 or newer of exponent_server_sdk gets installed.

Problem with MySQL

When using MySQL as database, django-notification-system cannot be installed, this is the error:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "/usr/local/lib/python3.9/site-packages/django/db/backends/mysql/base.py", line 73, in execute
    return self.cursor.execute(query, args)
  File "/usr/local/lib/python3.9/site-packages/MySQLdb/cursors.py", line 206, in execute
    res = self._query(query)
  File "/usr/local/lib/python3.9/site-packages/MySQLdb/cursors.py", line 319, in _query
    db.query(q)
  File "/usr/local/lib/python3.9/site-packages/MySQLdb/connections.py", line 259, in query
    _mysql.connection.query(self, query)
MySQLdb._exceptions.OperationalError: (3152, "JSON column 'extra' supports indexing only via generated columns on a specified JSON path.")

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/src/manage.py", line 22, in <module>
    main()
  File "/src/manage.py", line 18, in main
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/__init__.py", line 401, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python3.9/site-packages/django/core/management/__init__.py", line 395, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 330, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 371, in execute
    output = self.handle(*args, **options)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 85, in wrapped
    res = handle_func(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/commands/migrate.py", line 243, in handle
    post_migrate_state = executor.migrate(
  File "/usr/local/lib/python3.9/site-packages/django/db/migrations/executor.py", line 117, in migrate
    state = self._migrate_all_forwards(state, plan, full_plan, fake=fake, fake_initial=fake_initial)
  File "/usr/local/lib/python3.9/site-packages/django/db/migrations/executor.py", line 147, in _migrate_all_forwards
    state = self.apply_migration(state, migration, fake=fake, fake_initial=fake_initial)
  File "/usr/local/lib/python3.9/site-packages/django/db/migrations/executor.py", line 227, in apply_migration
    state = migration.apply(state, schema_editor)
  File "/usr/local/lib/python3.9/site-packages/django/db/migrations/migration.py", line 124, in apply
    operation.database_forwards(self.app_label, schema_editor, old_state, project_state)
  File "/usr/local/lib/python3.9/site-packages/django/db/migrations/operations/models.py", line 508, in database_forwards
    alter_together(
  File "/usr/local/lib/python3.9/site-packages/django/db/backends/base/schema.py", line 384, in alter_unique_together
    self.execute(self._create_unique_sql(model, columns))
  File "/usr/local/lib/python3.9/site-packages/django/db/backends/base/schema.py", line 142, in execute
    cursor.execute(sql, params)
  File "/usr/local/lib/python3.9/site-packages/django/db/backends/utils.py", line 98, in execute
    return super().execute(sql, params)
  File "/usr/local/lib/python3.9/site-packages/sentry_sdk/integrations/django/__init__.py", line 500, in execute
    return real_execute(self, sql, params)
  File "/usr/local/lib/python3.9/site-packages/django/db/backends/utils.py", line 66, in execute
    return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
  File "/usr/local/lib/python3.9/site-packages/django/db/backends/utils.py", line 75, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/usr/local/lib/python3.9/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "/usr/local/lib/python3.9/site-packages/django/db/utils.py", line 90, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/usr/local/lib/python3.9/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "/usr/local/lib/python3.9/site-packages/django/db/backends/mysql/base.py", line 73, in execute
    return self.cursor.execute(query, args)
  File "/usr/local/lib/python3.9/site-packages/MySQLdb/cursors.py", line 206, in execute
    res = self._query(query)
  File "/usr/local/lib/python3.9/site-packages/MySQLdb/cursors.py", line 319, in _query
    db.query(q)
  File "/usr/local/lib/python3.9/site-packages/MySQLdb/connections.py", line 259, in query
    _mysql.connection.query(self, query)
django.db.utils.OperationalError: (3152, "JSON column 'extra' supports indexing only via generated columns on a specified JSON path.")
  Applying django_notification_system.0001_initial...DEBUG 2021-11-09 13:58:32,053 selector_events 7 140571335104320 Using selector: EpollSelector

This happens because extra field is JSON and MySQL does not support unique on JSON fields, #33 solves this problem.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.