git pull errors with fatal: Could not read from remote repository. for a bunch of different connection errors, sometimes preceded with a line that specifies the cause of the error.

Https remotes will use this message:

fatal: unable to access 'https://github.com/eighty4/sse/': Could not resolve host: github.com

Workspace.Sync should report these errors correctly.

Ssh connectivity error:

ssh: connect to host github.com port 22: Undefined error: 0
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Ssh auth error with host:

[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Repository not found:

ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights

git.Pull currently handles error messages for both rebase and merge resolution strategies, handling a user's global and repository specific preferences. Conflict resolution isn't possible for a non-interactive interface so it makes more sense to use git pull --ff-only. --ff-only would simplify error handling (numerous different error messages would be uniformly replaced with "unable to fast forward"), side effect handling (from not entering a rebase) and reduce test scenarios.

maestro git has an unhandled error scenario when performing git pull on a repo tracking a delete branch on remote.

1. git checkout -b branch-name
2. git push -u origin branch-name
3. delete branch from remote
4. git pull

Your configuration specifies to merge with the ref 'refs/heads/branch-name'
from the remote, but no such ref was fetched.

Could also be reproduced by manually changing the branch.[branch-name].merge config entry pointing to a ref that does not exist:

1. git clone [email protected]:eighty4/maestro
2. git config branch.main.merge something-bogus

Maestro should read a yaml config file from the program's cwd on startup and include any repo records at $.workspace.repositories with the call to git.NewWorkspace. Workspace.Sync should git clone repositories that are not present within the workspace or do a git pull for already cloned projects.

Repositories can be configured with their name, path and git url. Path must be an ancestor path of the program's cwd (../foo is not permitted).

workspace:
  repositories:
    - name: fomo
      path: fomo
      git:
        url: [email protected]:eighty4/fomo
    - name: picking
      path: picking
      git:
        url: [email protected]:eighty4/picking

Only git url is required. Name and path are optional and will use the default behavior of git clone, using the repository name for an omitted name or path. In this example the repository would be named fomo and would be cloned into ./fomo:

workspace:
  repositories:
    - git:
        url: [email protected]:eighty4/fomo

A repository's path can be any nested directory structure within the program's cwd. In this scenario, an omitted name will default to the path value. These repositories in this example will have names plaid/trousers and plaid/banking:

workspace:
  repositories:
    - path: plaid/trousers
      git:
        url: [email protected]:eighty4/trousers
    - path: plaid/banking
      git:
        url: [email protected]:eighty4/banking

Workspace.Sync should catch and report these git clone errors.

Clone with a redirect to a not git url

git clone yahoo.com
Cloning into '/private/var/folders/r6/0hg_xym96qbgc8m049hxjrxr0000gn/T/maestro-test3436126983'...
fatal: unable to update url base from redirection:
  asked for: https://yahoo.com/info/refs?service=git-upload-pack
   redirect: https://www.yahoo.com/

Clone with not found response

git clone https://github.com/adgaljsdgalksjdgaslkdgj
Cloning into 'asdgsadgasdgasgasdg'...
remote: Not Found
fatal: repository 'https://github.com/asdgsadgasdgasgasdg/' not found

Clone with an http auth failure

git clone https://github.com/eighty4/asddgasjdgasdg
Cloning into 'asddgasjdgasdg'...
Username for 'https://github.com': asdf
Password for 'https://[email protected]':
remote: Support for password authentication was removed on August 13, 2021.
remote: Please see https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls for information on currently recommended modes of authentication.
fatal: Authentication failed for 'https://github.com/eighty4/asddgasjdgasdg/'

Maestro currently spawns a subprocess for each git clone and git pull operation. Linux and darwin performance holds up with subprocesses while Windows is drastically slower with this method.

The libgit2/git2go project provides go bindings for libgit2 and would greatly improve performance for syncing git repos.

While performance gains would be most noticable on Windows, it will probably be more difficult to build libgit2 and openssl on Windows vs Unix based platforms. One platform can be migrated at a time by substituting the subprocess implementations with the libgit2 binding-based implementations when building with go build for a specific platform.