eggdropsoap / binnie Goto Github PK

Before commit 61d2f3e, binnie.core.liquid.AlcoholEffect.makedrunk() was being passed a hardcoded 2.1f for "strength" (at binnie/extratrees/items/ItemDrink.java, line 143) regardless of the alcohol item used. After 61d2f3e, alcohol fluids' ABV are passed instead, which range from 0.05f to 0.8f. The code in makedrunk() was tuned for that strength of 2.1f, which is the current equivalent 210% ABV. Passing fluid ABVs now instead means the time and amplifiers for potion effects used to represent drunkenness are too brief to cause visible effects in most cases, varying from 1s for beer, with a max of 4s for neutral grain spirit (the minimum for the Nausea filter to briefly appear).

The code in makedrunk() can be roughly rescaled for the ABVs now passed in by multiplying ABV by 100 to get effective strength, before plugging strength into the existing potion effect time calculations in AlocholEffect.makedrunk(). This results in a time range for effects from 11s (ABV 0.05) to 45s (ABV 0.8).