eerussianguy / better-foliage Goto Github PK

Falling leaf particle of all TFC trees are grayscale, also Fruit Trees are missing particles completely.

Would it be possible to add support for Enhanced Farming? It appears all trees use the default oak leaves with the exception of the olive tree which uses acacia leaves. I was thinking you'd be able to use the stock oak and acacia 'fluff' without the need of any additional assets.

Please could you consider doing compatibility for these two popular mods that add leave types.

Thanks

Hello! So I saw that this mod says it's compatible with Biomes o plenty but when I install it along with bop the textures are not working. Only the vanilla trees seem to work.

Why doesnt the added short grass cover all grass blocks and why dont they wave when shaders are enabled?

As of version: betterfoliage-3.0.3.jar,

Biomesoplenty and quark leaves are not working. They appear normal.
Only vanilla leaves are working fine

Using the default resource pack, only other mods are optifine, biomes o plenty, and BSL shaders. Is there a reason why falling leaves particles are missing textures?

Encountered this issue on 1.18.2

Seems to be creating a better foliage grass when no grass is present or should be created.

Hi,

Some mods (like abundance and Biomes o plenty) implemented an "overlay" system for textures of their block, for the leaves block in particular, which give the possibility to get the leaves texture tinted in function of the biomes, and, have over this, an other texture which doesn't change in function of the biome.

Exemple:

Abundance:budding_redbud_leaves
Abundance:flowering_redbud_leaves
Biomesoplenty:flowering_oak_leaves

your mod doesn't seem to be able to handle this kind of texture overlay.

Could you please add support for Fabric 1.18.1?

Crash.txt

It's nice to see somebody took the job to update this mod to modern versions of MC but you missed one of the best features of the original mod, the ROUND tree logs... the nice part of that being done through code in a mod instead of a resource pack is that it doesn't matter if the log is from Vanilla MC or from a different mod like BOP, or The Twilght Forest, if it is a mod which makes the logs round, it would work for ANY log of any type of wood.

Please consider implementing that feature as well.

Thanks.-

Mod Loader

Forge

Minecraft Version

1.18.1

Mod versions

Botania 1.18.1-429
Better Foliage v3.0.2

Modloader version

Forge 39.1.2

Modpack info

Briar Patch 2 - v3.03
https://www.curseforge.com/minecraft/modpacks/briar-patch-2

The latest.log file

https://gist.github.com/jarquafelmu/f3dc11fc6367638723f3099c852c1189

Issue description

I placed a floating Solegnolia flower to prevent certain dropped items from being picked up with the ring of magnets. As soon as it tried to render, I crashed.

This is on a dedicated server and when I attempted to rejoin the server I instantly crashed again because the flower it still there.

Steps to reproduce

1. Install both Botania and Better Foliage Reborn
2. Make creative world
3. Place floating Solegnolia flower
4. ???
5. Crash

Referenced in botania's issue tracker at VazkiiMods/Botania#4030

Hey, whenever i try to load v4.0.6, I instantly get this error as it tries to load up, and it leads me to a screen in Miencraft saying "Better Foilage has failed to load properly". Here is my error log: https://mclo.gs/jzRlfdI

Minecraft Version: 1.19.3
Forge version: 44.1.0

Description:
When using Rubidium, tree leaves blocks that are affected by the Better Foliage Renewed mod appear too dark at some angles, leading to poor visual effects, This issue is also very noticeable when looking at leaves from far away. See screenshots below for examples.
I get it that some of the protruding "leaves" should be affected by shadows (like the ones on the bottom), but the rest of the leaves look weird with Rubidium enabled and don't blend with the leaf blocks themselves.

Screenshots:

Without Rubidium

With Rubidium

forge version 40.1.74
tfc v2.1.3-beta
better foliage renewed version 3.1.2
oculus version 1.2.5a

Description:
mc crashes on a java.lang.IllegalArgumentException: Vertex element out of bounds: 6 for tesselating a falling block entity, when Terrafirmacraft, Better Foliage Renewed and Oculus are installed. Crash does not occur, when BFR is not installed.

The tall grass texture looks very streched. I would prefer just using the upper part of the normal tall grass texture instead of streching the texture.

in config leaves are enabled

The leaves are fluffy but the grass doesnt show up

When testing this mod (version 4.0.6) on its own, I noticed the grass it generated has much darker lighting than default grass, making it stand out and not blend as nicely as it could.

A way to disable certain things Example disable grass spawning or make it so water destroys the grass?

Hey,
we are using the modversion 5.0.2 for the gameversion 1.20.1
the extra grass doesnt disappear by detroying the grassblock beneath

hope for some help here :)

Version 1.18.2, latest forge, latest build of both mods

please make the mod work with dynamic trees! thanks

Issue Description:
None of the leaves blocks from BYG mod get affected by Better Foliage. Please make the mod compatible with BYG.

Mod Info:
Forge 43.1.43
Better Foliage 4.0.6
BYG 2.0.0.13

Souls are rising out of quartz block variants as well as soul sand and soul dirt

Setting the leaves = false in the mod config does not disable the leaves effects provided by the mod.

Please could you consider doing compatibility for this popular mod that add leave types.

Thanks

-- Head --
Thread: main
Stacktrace:
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:787) ~[arclight-forge-1.16-1.0.18.jar:arclight-1.16.5-1.0.18-32d233f] {re:mixin}
-- MOD betterfoliage --
Details:
Mod File: [更好的树叶]betterfoliage-1.1.1.jar
Failure message: Better Foliage (betterfoliage) encountered an error during the common_setup event phase
java.lang.NullPointerException: Cannot set config value without assigned Config object present
Mod Version: 1.1.1
Mod Issue URL: https://github.com/eerussianguy/Better-Foliage/issues
Exception message: java.lang.NullPointerException: Cannot set config value without assigned Config object present
Stacktrace:
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:787) ~[arclight-forge-1.16-1.0.18.jar:arclight-1.16.5-1.0.18-32d233f] {re:mixin}
at net.minecraftforge.common.ForgeConfigSpec$ConfigValue.set(ForgeConfigSpec.java:854) ~[forge:?] {re:classloading}
at com.eerussianguy.betterfoliage.BetterFoliage.commonSetup(BetterFoliage.java:48) ~[betterfoliage:1.1.1] {re:classloading}
at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:247) ~[eventbus-4.0.0.jar:?] {}
at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:239) ~[eventbus-4.0.0.jar:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) ~[eventbus-4.0.0.jar:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) ~[eventbus-4.0.0.jar:?] {}
at net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:120) ~[forge:36.1] {re:classloading}
at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:121) ~[forge:?] {re:classloading}
at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1736) ~[?:?] {}
at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1728) ~[?:?] {}
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290) ~[?:?] {}
at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020) ~[?:?] {}
at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656) ~[?:?] {}
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594) ~[?:?] {}
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183) ~[?:?] {}

Please could you consider doing compatibility for these popular mods that add leave types.

Thanks

Minecraft Version: 1.20.1
Forge version: 47.2.17

Upon installation of this mod in curseforge app with forge 41.0.16 the game crashes before even showing the normal loading screen. The game crashes with exit code 1. The error is this error here:

Upon disabling the mod the game loads normally.

Only this mod is loaded
here's the latest.log https://mclo.gs/3cQTZsi

Minecraft version: 1.20.1
Forge version: 47.0.35

Issue:
The leaves aren't as bushy as they used to be in previous versions and appear to still be very blocky. It seems the lighting for the grass is also a bit different and looks out of place.

1.19.2

1.12.2

I noticed that the lighting of the grass looks weird while using shaders.If you add properties for the plants like 1.16.5 version,it will be a great progress in term of visuals.

On version 1.20.1 the leaves from Bop are not affected