edwardhotchkiss / short Goto Github PK

Hi,

I haven' t been able to get this to work.
None of the methods in ShortURL return.

Any ideas?

npm shows the older 2.5.2 version, could you please update the package on npm so that using the newer 2.6.0 version is easy

I would really love to have a feature to update the data or URL corresponding to a given hash. the reason being that I don't want to fiddle with the mongo database used by mongoose directly.

I intend to implement it for myself, and would definitely love to push it upstream as well,

The api could be

short.update(hash,{
  URL: '',
  data: ''
}

of course, the URL and data are optional(one might not want to update both), and the new keys in data will add to the existing keys if not present, and update the existing key if the key is already present.

Let me know what you think and if you have any api preferences for this feature

Hi There,

Currently, the latest version of short is 2.6.0. It contains a transitive dependency mongodb of version 2.0.34 which has high-risk security vulnerabilities. These vulnerabilities of mongodb are fixed at version >= 3.1.13. Can we get the updated vulnerabilities free version of the short package?

-- [email protected]
  -- [email protected]
    -- [email protected]

The homepage link on nodemodules and npm are broken/out of date

Whats the use of taking a URL as an argument when it is not used in the function here https://github.com/edwardhotchkiss/short/blob/master/lib/short.js#L15 ?

Whats the guarantee that "hasher" will always return a unique hash?

Thanks for the helpful library. I'm using short in an app that generates a short URL for the same long URL a few times per long URL. It would be cool if the short URL was the same each time. Obviously I can keep it around, so not a big deal, but it seems like this would be a feature.

Specifying a hash with a URL that already exists has no effect.

Steps to reproduce

1. Instantiate step with a mongo connection
2. Call the generate method and specify a URL to create a short URL document
3. After the document is saved, create a second short URL document with the hash specified yet using the same URL

Expected behavior

A new document should be created using the provided hash

Actual behavior

The first document is returned with the first auto-generated hash. The specified hash has no effect.

Steps to reproduce:

1. Create a new short instance with a DB connection
2. Call short.generate and specify a hash
3. Inspect the created document

Expected behavior:

• Hash of saved document should match the hash specified in the document creation
• If the hash was a duplicate, an error should be raise

Actual behavior: a random hash is generated

Gist: https://gist.github.com/matmar10/6659ce1d67df8f79eda4

It seems change #26 had no effect.

Hello there,

I would like to ask if there is a way to automatically delete a record once the specified time is achieved (e.g. expiration is 1 minute [60000ms])? Thank you