edwardhdlu / edwardhdlu.github.io Goto Github PK

on mobile devices, the resulting page when any project/tile is clicked doesn't scroll. just thought you might want to know

Hey, I was just checking out your site and I noticed that the contact links don't work:

[Error] Refused to display 'https://github.com/edwardhdlu' in a frame because it set 'X-Frame-Options' to 'deny'.
[Error] Refused to display 'https://github.com/edwardhdlu' in a frame because it set 'X-Frame-Options' to 'deny'.
[Error] Refused to display 'https://github.com/edwardhdlu' in a frame because it set 'X-Frame-Options' to 'deny'.
[Error] Refused to display 'https://www.facebook.com/eddywerdy' in a frame because it set 'X-Frame-Options' to 'DENY'.
[Error] Refused to display 'https://github.com/edwardhdlu' in a frame because it set 'X-Frame-Options' to 'deny'.

Was browsing through your code, came up with two solutions (too lazy to fork and do a PR, so have this instead):

a) remove font-size declaration from #header a, since automatically the font size is 16px by default in all browsers.

b) target #title-link style specifically with #header a#title-link.

something to think about because we all know !important is way too cringe to use