Code Monkey home page Code Monkey logo

edrn.bmdb's People

Contributors

nutjob4life avatar

Watchers

 avatar  avatar  avatar  avatar

edrn.bmdb's Issues

There should be a "referencesStudy" predicate

The RDF generation for organ-specific information for a biomarker doesn't include the study.

The FHCRC_ID column of the study data should be used to make a <bmdb:referencesStudy> predicate whose rdf:resource is http://edrn.nci.nih.gov/data/protocols/{PROTOCOL-ID}.

Barrett's Esophagus subject URI is incorrect

BMDB RDF says that for biomarker http://edrn.jpl.nasa.gov/bmdb/biomarkers/view/53 the AssociatedDataset predicate is https://edrn-labcas.jpl.nasa.gov/labcas-ui/c/index.html?collection_id=Barretts_Esophagus_Methylation_Profile_Dataset.

However, the actual subject URI is https://edrn-labcas.jpl.nasa.gov/labcas-ui/c/index.html?collection_id=Barrett's_Esophagus_Methylation_Profile_Dataset.

RDF server loses database connection

After a while, queries into the RDF service for the Focus Bio Marker Data Base (BMDB) fail and emit this in the logs:

focusbmdb-rdf    |   File "/app/src/edrn/bmdb/server.py", line 50, in __call__
focusbmdb-rdf    |     cursor.execute('SELECT COUNT(*) FROM `biomarkers`')
focusbmdb-rdf    |   File "/app/eggs/PyMySQL-0.10.0-py3.8.egg/pymysql/cursors.py", line 163, in execute
focusbmdb-rdf    |     result = self._query(query)
focusbmdb-rdf    |   File "/app/eggs/PyMySQL-0.10.0-py3.8.egg/pymysql/cursors.py", line 321, in _query
focusbmdb-rdf    |     conn.query(q)
focusbmdb-rdf    |   File "/app/eggs/PyMySQL-0.10.0-py3.8.egg/pymysql/connections.py", line 504, in query
focusbmdb-rdf    |     self._execute_command(COMMAND.COM_QUERY, sql)
focusbmdb-rdf    |   File "/app/eggs/PyMySQL-0.10.0-py3.8.egg/pymysql/connections.py", line 742, in _execute_command
focusbmdb-rdf    |     raise err.InterfaceError(0, '')
focusbmdb-rdf    | pymysql.err.InterfaceError: (0, '')

This discussion suggests that having a universal connection object is the culprit. We need to create one per thread.

Python 2 → 3

This package is still using Python 2.7, which reached end of life on 2020-01-01.

Python 3 has been out 12 years. It's time to leave Python 2 behind.

Change phase literal values

Currently phases are of the form

http://edrn.nci.nih.gov/rdf/rdfs/bmdb-1.0.0#Phase = One

or

http://edrn.nci.nih.gov/rdf/rdfs/bmdb-1.0.0#Phase = Three

which is dumb for sorting purposes. But this is how ahart did it back in the day. We need to use actual numbers so we can sort properly, i.e.:

http://edrn.nci.nih.gov/rdf/rdfs/bmdb-1.0.0#Phase = 1

or

http://edrn.nci.nih.gov/rdf/rdfs/bmdb-1.0.0#Phase = 3

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.