edgeapp / airbitz-android-gui Goto Github PK

Firstly, apologies if this isn't the correct repo to file issues against (sidenote: an architecture overview would go a long way here).

Airbitz on android just burned through my available cellular data while in the background. The settings tell me it's used 90MB. I've only sent a handful of transactions (on wifi usually) so I'm assuming this is just updating the business directory info. If this is the case, I'd appreciate a way to disable these updates if on cellular connection if not entirely. Unfortunately his is a deal-breaker for me personally for a bitcoin wallet, which is sad because I've spent much time recommending it to others over the last year.

Many thanks.

I use

OS

Kubuntu 16.04 (64-bit)

Java

java version "1.8.0_121"
Java(TM) SE Runtime Environment (build 1.8.0_121-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.121-b13, mixed mode)

Android SDK Packages

# list Android SDK packages
$ANDROID_HOME/tools/bin/sdkmanager --list > ~/tmp/airbitz/android-sdk-packages.txt

see android-sdk-packages.txt

Preparatory steps

# make sure that everything is from scratch
rm -rf ~/.gradle
rm -rf ~/tmp/airbitz
mkdir -p ~/tmp/airbitz

cd ~/tmp/airbitz/

# clone Airbitz/airbitz-android-gui
git clone [email protected]:Airbitz/airbitz-android-gui.git
cd airbitz-android-gui/
cd Airbitz/

Compile branch master

# compile branch "master"
./gradlew installDevelopDebug > ~/tmp/airbitz/build-master-developdebug.log 2>&1

the compilation is failed due

com.android.jack.api.v01.CompilationException: Failed to compile
  at com.android.jack.api.v01.impl.Api01ConfigImpl$Api01CompilationTaskImpl.run(Api01ConfigImpl.java:144)
  ...

also

grep -nr ERROR: ~/tmp/airbitz/build-master-developdebug.log
/home/kostik/tmp/airbitz/airbitz-android-gui/Airbitz/airbitz/src/main/java/com/airbitz/api/CoreWrapper.java:69.31: The type new Account.Callbacks(){} must implement the inherited abstract method Account.Callbacks.loginMessages(String)

see build-master-developdebug.log.txt

Compile branch develop

git checkout -b develop origin/develop
./gradlew installDevelopDebug > ~/tmp/airbitz/build-develop-developdebug.log 2>&1

the compilation is failed due

com.android.jack.api.v01.CompilationException: Failed to compile
  at com.android.jack.api.v01.impl.Api01ConfigImpl$Api01CompilationTaskImpl.run(Api01ConfigImpl.java:144)
  ...

also

grep -nr ERROR: ~/tmp/airbitz/build-develop-developdebug.log 
241:ERROR: /home/kostik/tmp/airbitz/airbitz-android-gui/Airbitz/airbitz/src/main/java/com/airbitz/api/CoreWrapper.java:69.31: The type new Account.Callbacks(){} must implement the inherited abstract method Account.Callbacks.loginMessages(String)
379:ERROR: /home/kostik/tmp/airbitz/airbitz-android-gui/Airbitz/airbitz/src/main/java/com/airbitz/plugins/PluginFramework.java:131.92: bitrefill_api_key cannot be resolved or is not a field

see attached build-develop-developdebug.log.txt

The same occurs when I run ./gradlew installNettestDebug and ./gradlew installProdDebug

Note that the given BTC address is invalid (missing last two characters, ok)

18Y4qwziefoZZyhA8yU2LjRsWh1c6J5E
http://i.imgur.com/qBVeABA.png

Steps to create crash on Android Airbitz wallet:

1. Open App
2. Log in with pin
3. Press Send
4. Point at QR Code above
5. Wallet crashes.

Restart, Login, Repeat, Crash.

Add missing characters. Regenerate the QR Code. Go through steps above, and all is good.

18Y4qwziefoZZyhA8yU2LjRsWh1c6J5Eok
http://i.imgur.com/GBw1Aud.png

Receive -> Import

It succesfully grabs the private key and displays it in WIF format, but after a few seconds of trying to import or sweep, it always reads "Import failed. Try Again."

Nice that you open source everything 👍
Guess this is now the place to give feedback?

I have the regular (released) wallet installed on my phone and not the github-master-version, so some things might be outdated.

Would be cool if I can define the maximum spending limits in fiat (USD etc.) and not only in Bitcoins, as the Bitcoin price is still fluctuating a bit ;)

At the time of writing this article, we were unable to verify the apk on GooglePlay and we would hope to see this wallet - although obsoleted by its successor - to raise to our "verifiable" category soon with your cooperation.

Just wondering if there's any chance at getting push notifications implemented for receiving BTC?

Odd bug as I was playing with the app.

I was testing the send function. I scanned in a QR code for the receiving address, and tried to select a small value to send, something like 0.001 mBTC. The app rejected it and said I had to send at least $0.01. I selected the fiat amount field, and changed the dollar amount to $0.01. The app rejected this as well -- it was not quite as much as it expected due to a rounding error, and the app specified exactly how many mBTC had to be sent that was also equivalent to $0.01. After selecting the mBTC field, I changed it to that value, and sent.

The app took the full amount that I sent and committed that as a mining fee, and sent nothing to the original address I scanned in.

I expected it to send the small amount to my intended recipient address, and then also deduct from the account an appropriate mining fee.

For additional details, please email me with a PGP public key.

Check out this comment on the "Bitcoin Pay" wallet. It looks like a clear scam.

Maybe you also want to poke Google to get the de-listed.

This is with the Android wallet downloaded yesterday from Google Play.

The problem is presumably triggered by the session expiring during the setting of recovery questions.

I was creating my recovery questions for the first time in a brand new wallet, and didn't comlete them for some time, having been interrupted I left the wallet open at that page. Over an hour later I returned to complete the page, and it was rejecting my password, saying it wasn't correct when in fact it was (though it had me worried!). This would be much more concerning for someone who had stored value in the wallet of course.

When I came out of the wallet and logged in again, I then went to create my recovery questions, and it of course accepted my password.

So you just need to detect the session has expired and make sure people are not left in an area where they'll be told their password is incorrect, when in fact it is correct.