Code Monkey home page Code Monkey logo

notify-teams's People

Contributors

dependabot[bot] avatar dtip avatar dvuckovic avatar

Stargazers

 avatar

Watchers

 avatar

Forkers

jameshawkes

notify-teams's Issues

Detection of the previous workflow conclusion does not consider recent failures

When a list of workflows is requested via Github REST API, workflow runs in status in_progress are also considered. This results in an erroneous fallback conclusion of unknown, since currently running workflows do not have this field calculated yet. In return this leads to break of the contract for the fixed notification event, since previous failure will not be checked.

Consider filtering out all workflow runs which do not have status field as completed, as per the official REST documentation. This should fix the issue and make sure recent failures are at the top of the array.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.