JIT crash for java/lang/StringConcatHelper.stringOf(Ljava/lang/Object;)Ljava/lang/String; about openj9 HOT 6 OPEN

fyi @r30shah

from openj9.

@beikov Looking at the segmentation fault, I see that the failure is happening while executing a JIT compiled method. From the output, it seems like it has generated diagnostic files (core dump, javacore, jitdump, etc). If the test has archived core dump or it is still available, would it be possible for us to checkout that ? It would help us with diagnosing problem. NVM, saw that it failed with producing core-dump

from openj9.

Pls give the 17.0.10 Milestone 2 build a try to see if the problem still occurs.

https://github.com/ibmruntimes/semeru17-binaries/releases/tag/jdk-17.0.11%2B7_openj9-0.44.0-m2

from openj9.

No more JIT error with that milestone, but now we have a stackoverflow that makes no sense. The JIT seems to produce wrong code: https://ci.hibernate.org/job/hibernate-orm-pipeline/job/wip%2F7.0/21/testReport/junit/org.hibernate.orm.test.bootstrap.jpa/PersistenceUnitOverridesTests/Build___s390x_h2___Test___testCfgXmlBaseline/

It reports this SO which makes no sense:

	at java.base/java.lang.StringConcatHelper.stringOf(StringConcatHelper.java:453)
	at org.hibernate.boot.model.naming.Identifier.render(Identifier.java:222)
	at org.hibernate.boot.model.naming.Identifier.toString(Identifier.java:232)
	at java.base/java.lang.StringConcatHelper.stringOf(StringConcatHelper.java:453)
	at org.hibernate.boot.model.naming.Identifier.render(Identifier.java:222)
	at org.hibernate.boot.model.naming.Identifier.toString(Identifier.java:232)
	at java.base/java.lang.String.valueOf(String.java:4988)
	at java.base/java.lang.StringBuilder.append(StringBuilder.java:173)
	at org.hibernate.boot.model.relational.QualifiedNameParser$NameParts.<init>(QualifiedNameParser.java:50)

The methods in Identifier do not call this.toString(). The same thing works fine on x86 with the Hotspot JVM.

	public String render() {
		return isQuoted
				? '`' + getText() + '`'
				: getText();
	}

	@Override
	public String toString() {
		return render();
	}

from openj9.

It may be the same issue so upgrading the build did not work. Looking at the method StringConcatHelper.toString, I see that it will call Object.toString() method, that is what Identifier.toString() call is.
Given that you have a fair success in getting this to fail, I will try to reproduce this and see if I can get the core-dump.

from openj9.

I can reproduce this on my personal VM and now I do have a core-dump to analyze.

Following is the failing stack,

{java/lang/StringConcatHelper.stringOf} JIT
{java/lang/invoke/LambdaForm$DMH/0x00000000841cc320.invokeStatic} JIT 
{java/lang/invoke/LambdaForm$MH/0x00000000c00b4410.invoke} JIT
{java/lang/invoke/LambdaForm$MH/0x000000008479d7e0.linkToTargetMethod} JIT 
{org/hibernate/persister/entity/AbstractEntityPersister.internalInitSubclassPropertyAliasesMap} INT
{org/hibernate/persister/entity/AbstractEntityPersister.internalInitSubclassPropertyAliasesMap} JIT

Looking at the disassembly of StringConcatHelper.stringOf, we end up in this method with corrupted object (Instead of the Object, it points to an address of another JIT compiled method. Chasing down the parameter, something messed up in the last / second last method as core-dump complained about corrupt stack and I can not get proper object values to check. Looking at the code for internalInitSubclassPropertyAliasesMap , it seems to be failing while calling a code for String concatenation at [1]. I will see if this only appears to be seen on Z or I can reproduce it on X as well. Will post update on this issue.

[1]. https://github.com/hibernate/hibernate-orm/blob/2dddf6c3e24c1c9d480fadf8e055f4cac5f26766/hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java#L6796C1-L6796C2

from openj9.