Code Monkey home page Code Monkey logo

Comments (6)

keithc-ca avatar keithc-ca commented on June 16, 2024 1

I think it's more important to be consistent than the exact format. Is that the format you're proposing?

/*
 * Copyright IBM Corp. and others 2007
 *

from openj9.

pshipton avatar pshipton commented on June 16, 2024

ibmruntimes/openj9-openjdk-jdk@47457a1...a195036

8303689: javac -Xlint could/should report on "dangling" doc comments

https://bugs.openjdk.org/browse/JDK-8303689
https://bugs.openjdk.org/browse/JDK-8330177

from openj9.

pshipton avatar pshipton commented on June 16, 2024

Seems we'll have to change the format of most copyright/license comments in OpenJ9 Java code.

@keithc-ca fyi

from openj9.

keithc-ca avatar keithc-ca commented on June 16, 2024

I noticed some upstream changes where they just changed the second * to a space, like changing

/*******************************************************************************

to

/* *****************************************************************************

I've seen warnings about that before, but they've never been fatal. I guess it's time to clean up.

from openj9.

pshipton avatar pshipton commented on June 16, 2024

I don't think we need a line of *, they could just be removed. I notice the following class doesn't have them.
https://github.com/eclipse-openj9/openj9/blob/master/jcl/src/java.base/share/classes/java/lang/Access.java

from openj9.

pshipton avatar pshipton commented on June 16, 2024

Yes.

from openj9.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.