Code Monkey home page Code Monkey logo

Comments (4)

TCreutzenberg avatar TCreutzenberg commented on July 28, 2024

Also, it is not possible to instantiate a ShapeDrawer without textureRegion or textureRegion = null.
This is related to the same problem.

from shapedrawer.

earlygrey avatar earlygrey commented on July 28, 2024

OK that's a fair enough use case, you might also want to use different Texture Regions from different textures to optimise flushes.

You can make a PR if you like, otherwise I'll do it this week. It should also throw an exception (IllegalStateException?) when trying to use it without a Texture Region. I guess the setter would then just become

    public TextureRegion setTextureRegion(TextureRegion region) {
        TextureRegion oldRegion = this.r;
        this.r = region;
        if (r != null) {
            float u = 0.5f * (r.getU() + r.getU2());
            float v = 0.5f * (r.getV() + r.getV2());
            for (int i = 0; i < verts.length; i += VERTEX_SIZE) {
                verts[i + SpriteBatch.U1] = u;
                verts[i + SpriteBatch.V1] = v;
            }
        }
        return oldRegion;
    }

and you could add a getter and a constructor which takes only a Batch.

from shapedrawer.

TCreutzenberg avatar TCreutzenberg commented on July 28, 2024

@earlygrey Hey, I'll create a PR soon.

from shapedrawer.

TCreutzenberg avatar TCreutzenberg commented on July 28, 2024

Closed with #34

from shapedrawer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.