portfolio assignment for 301
LINK TO DEPLOYED HEROKU portfolio https://davezalkportfolio.herokuapp.com/
portfolio assignment for 301
License: MIT License
portfolio assignment for 301
LINK TO DEPLOYED HEROKU portfolio https://davezalkportfolio.herokuapp.com/
Good stuff. I didn't find any issues, but you might consider breaking out your styles into multiple stylesheets to follow SMACSS guidelines (base, layout, modules, etc.).
Overall, looks great! Just a few small things...
Line 49: It looks like there is an unclosed header tag here. Is this area being reserved for something?
Line 51: This closing article tag looks like its indentation doesn't match its opener above.
Lines 54-74: Check the indentation in this area. I think there are some inconsistent indentations here.
tag named footer, it is not a footer. change this in index.html and code for read on button
switch to real projects soon, no more dummies. create a json file with all the information keys and values that I decide to use for the projects that you select.remember to link it to index and also change the info in the fetchall function to the new file.
Dave -
A few thoughts:
First of all, love the design and all the Calvin & Hobbes stuff! I also like the use of aside tags for your information section; it's good semantics. However, I notice that you included a div class="footer" at the bottom of the page. What about using a footer instead?
I notice you included a script link to version 1.12 of jQuery. I don't know that it makes a huge difference, but you might consider including version 2.2.
On line 42, I noticed a missing = in the data-category assignment.
I noticed that when I shrink the browser window, and the nav bar collapses down into the small vertical list, there is a vertical line that appears to the right of the menu. I think this is the hr that is added on line 46, but I couldn't tell if this was a formatting glitch or an intentional design element.
Overall, looks good!
Just some indentation/white space issues here. Keeping all the array entries formatted the same way will improve readability of the code.
Lines 4 & 11: Why did you choose to select by ".navbar .tab: first" and ".navbar .tab: last"? You assigned data-content attributes to these elements, so if you query by data-content, you don't have to worry about this function breaking if you ever change the order of those items in the nav bar.
lint all JS
no longer works since running with live-server. try and fix this. for some reason the event.prevent default is not applying when the readon button is clicked. sort through this again and try to figure out why, if not, ask for help
remove all old commented code that is not explaining anything. Literally delete it. Any explanation comments can remain.
Lines 6-13: Consider refactoring this as demonstrated in the last class (with an Object.keys method and .forEach loop) so that you don’t have to manually set each of the object attributes.
Lines 60-65: It's nitpicky, but check indentation here.
Lines 27-33: I really like all the commenting and console logging here. I’m not sure all the logs need to be in the final version of this, but it’s nice for being able to see how this function works step-by-step.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.