dzious / enchantcontrol Goto Github PK

When enchanting an item though enchanting table, the enchants sometimes changes between end of and onEnchantmentPreparation beginning onEnchantItem in EnchantmentTableListener

Describe the bug

A clear and concise description of what the bug is.
https://discordapp.com/channels/775955884874268683/776287618332622848/830199569601658940

How to reproduce the bug ?

What is your EnchantControl version?

1.24

What is your spigot/craftbukkit version?

Purpur-1053

Logs / Files

Please use Pastebin.com to share the following files

These files are essential to understand and resolve the bugs. If you do not provide us these files, your issue ticket will most likely be deleted and you will be asked to submit an other one.

1. Your full server startup from the logs\latest.log :
2. Your EnchantControl config.yml :
3. Your log's error :

Describe the bug

How to reproduce the bug ?

I have no idea the truth, the user does not remember

What is your EnchantControl version?

1.2.4

What is your spigot/craftbukkit version?

PaperMC 1.16.4 346

1. Your full server startup from the logs\latest.log : NONE
2. Your EnchantControl config.yml : https://pastebin.com/u6f9dSR2
3. Your log's error : https://pastebin.com/F4iN0M3h

Add listener that would allow server owner to add EnchantControl during the server lifecycle by removing unwanted enchants

Describe the bug

Anvil does not offer enchant levels beyond vanilla for Efficiency

How to reproduce the bug ?

1. Add two Diamond pickaxes to your inventory
2. Enchant both with Efficiency 5 using /enchant
3. Combine in an Anvil

Expected behaviour: Anvil offers Efficiency 6

Observed behaviour: Anvil offers efficiency 5, with the following debug output:

[13:33:31 INFO]: [EnchantControl_Reforged][Debug] : Item type : DIAMOND_PICKAXE
[13:33:31 INFO]: [EnchantControl_Reforged][Debug] : Enchantments (Start) : {Enchantment[minecraft:efficiency, DIG_SPEED]=5}
[13:33:31 INFO]: [EnchantControl_Reforged][Debug] : Enchantments (End) : {Enchantment[minecraft:efficiency, DIG_SPEED]=5}
[13:33:31 INFO]: [EnchantControl_Reforged][Debug] : Enchantment (Loop) : {Enchantment[minecraft:efficiency, DIG_SPEED]=5}
[13:33:31 INFO]: [EnchantControl_Reforged][Debug] : Enchantments (Meta) : {Enchantment[minecraft:efficiency, DIG_SPEED]=5}

[13:33:16 INFO]: [EnchantControl_Reforged][Debug] : Currently processing : Enchantment[minecraft:efficiency, DIG_SPEED]. It's level is 8

What is your EnchantControl version?

v1.2.4 36c2faa

What is your spigot/craftbukkit version?

1.16.4

Logs / Files

1. Your full server startup from the logs\latest.log : http://cdn.smpmc.org/files/ephemeral/ec/latest.log
2. Your EnchantControl config.yml :

debug:
    enable: true
    player: [removed]
update_inventory: false
mending_repair: true
bypass_levels: false
enchantments:
    minecraft:
        efficiency: 8

3. Your log's error : N/A

Add ability to anvil to fuse enchanted item with levels that exceed vanilla minecraft

Describe the feature you would like to have as best as you can
Transform enchantments level such as Sharpness enchantment.level.100 into Sharpness C

Describe the bug

A clear and concise description of what the bug is.

How to reproduce the bug ?

1.1.19.2 Paper
2.Enchanting Control 1.25
3.use a max enchanting table and look at the options. for example a pair of leggings has a small chance to get swift sneak or a pair of boots soul speed.

What is your EnchantControl version?

1.2.5

What is your spigot/craftbukkit version?

Paper 1.19.3

Logs / Files

There is no error in the log but here is the log https://pastebin.pl/view/1ea0f293

1. Your full server startup from the logs\latest.log :
2. Your Enchant Control config.yml :https://pastebin.pl/view/c42ed1f9
3. Your log's error : None

The only things i can think of that might conflict is the Old combat mechanics tho I don't think it messes with enchanting and the less overpowered villager trading witch removes some villager trades like mending making it only obtainable through fishing and looting

[13:41:23] [Server thread/ERROR]: Could not pass event VillagerAcquireTradeEvent to EnchantControl v1.0_Pre-Release
java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to [Lorg.bukkit.enchantments.Enchantment;
at com.dzious.bukkit.enchantcontrol.plugin.EnchantmentManager.rerollEnchantment(EnchantmentManager.java:138) ~[?:?]
at com.dzious.bukkit.enchantcontrol.listener.VillagerTradeListener.onVillagerAcquireTrade(VillagerTradeListener.java:61) ~[?:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor11.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[mc.jar:git-Paper-204]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[mc.jar:git-Paper-204]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[mc.jar:git-Paper-204]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:607) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.EntityVillagerAbstract.a(EntityVillagerAbstract.java:237) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.EntityVillager.eW(EntityVillager.java:827) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.EntityVillagerAbstract.getOffers(EntityVillagerAbstract.java:92) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.EntityVillager.fm(EntityVillager.java:315) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.EntityVillager.fc(EntityVillager.java:353) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.BehaviorWork.a(SourceFile:58) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.BehaviorWork.a(SourceFile:18) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.Behavior.e(SourceFile:49) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.BehaviorGate$Execution$1.lambda$a$1(BehaviorGate.java:85) ~[mc.jar:git-Paper-204]
at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174) ~[?:1.8.0_265]
at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) ~[?:1.8.0_265]
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) ~[?:1.8.0_265]
at java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1361) ~[?:1.8.0_265]
at java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:126) ~[?:1.8.0_265]
at java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:499) ~[?:1.8.0_265]
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:486) ~[?:1.8.0_265]
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) ~[?:1.8.0_265]
at java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:152) ~[?:1.8.0_265]
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:1.8.0_265]
at java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:531) ~[?:1.8.0_265]
at net.minecraft.server.v1_16_R2.BehaviorGate$Execution$1.a(BehaviorGate.java:86) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.BehaviorGate.a(BehaviorGate.java:44) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.Behavior.e(SourceFile:49) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.BehaviorController.d(SourceFile:506) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.BehaviorController.a(SourceFile:465) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.EntityVillager.mobTick(EntityVillager.java:169) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.EntityVillager.mobTick(EntityVillager.java:166) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.EntityVillager.inactiveTick(EntityVillager.java:153) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.WorldServer.entityJoinedWorld(WorldServer.java:843) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.World.a(World.java:884) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.WorldServer.doTick(WorldServer.java:526) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.MinecraftServer.b(MinecraftServer.java:1358) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.DedicatedServer.b(DedicatedServer.java:371) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.MinecraftServer.a(MinecraftServer.java:1211) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.MinecraftServer.w(MinecraftServer.java:999) ~[mc.jar:git-Paper-204]
at net.minecraft.server.v1_16_R2.MinecraftServer.lambda$a$0(MinecraftServer.java:177) ~[mc.jar:git-Paper-204]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_265]

this error pops up when spawning a villager with mending when in confing mending is 0

allow you to use levels from 0-32k

Describe the bug

A clear and concise description of what the bug is.

So I have my settings for the bow on the following:
infinity: 0
power: 0
unbreaking: 0
flame: 0
punch: 0

Most of the times it work but at some time it doesn't and then I get for example flame 1 on my bow. but most of the time curse of vanishing.

Also whenever update_inventory: true it doesn't update.

How to reproduce the bug ?

1. Get around 7 bows.
2. Enchant them level 30, u see most of them are only curse of vanishing.
3. U see that it is not 100% accurate

What is your EnchantControl version?

1.2.4

What is your spigot/craftbukkit version?

Spigot_v1_16_R3

Logs / Files

Please use Pastebin.com to share the following files

These files are essential to understand and resolve the bugs. If you do not provide us these files, your issue ticket will most likely be deleted and you will be asked to submit an other one.

1. Your full server startup from the logs\latest.log : https://pastebin.com/0SHekyvJ
2. Your EnchantControl config.yml : https://pastebin.com/BexN4xYH
3. Your log's error : There is no error?

Describe the bug

Console error
https://pastebin.com/54cHfTqs

How to reproduce the bug ?

Not sure what is causing it

What is your EnchantControl version?

EnchantControl_Reforged v1.2.5

What is your spigot/craftbukkit version?

This server is running Purpur version git-Purpur-1632 (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT) (Git: dc4a29b on HEAD)

Logs / Files

Please use [Pastebin.com] to share the following files

https://pastebin.com/WXtmxgbu
https://pastebin.com/54cHfTqs

Hello, thank you so much for this plugin!

A feature idea that I think would be cool is the ability to have incompatible enchantments on the same item (like Smite + Sharpness on the same Diamond Sword). Thank you so much!

Add ability to manage enchant that aren't from vanilla minecraft (PluginName:EnchantmentName or ModName:EnchantmentName)

Plugin/Mod dev would need to hook themselves in order to add their enchants

Describe the bug

A clear and concise description of what the bug is.

How to reproduce the bug ?

1. setup in config file is:
   enchantments:
   minecraft:
   silk_touch: 0

What is your EnchantControl version?

1.2.4

What is your spigot/craftbukkit version?

Paper 1.16.5

Logs / Files

Please use Pastebin.com to share the following files

These files are essential to understand and resolve the bugs. If you do not provide us these files, your issue ticket will most likely be deleted and you will be asked to submit an other one.

1. Your full server startup from the logs\latest.log : https://pastebin.com/PgWWZ2gN
2. Your EnchantControl config.yml : https://pastebin.com/f2qphejC
3. Your log's error : https://pastebin.com/Ttu8QsBZ

Describe the bug

A clear and concise description of what the bug is.

Apparently, it happens with all combat items in Minecraft (Armor, Weapons, Tools included)

How to reproduce the bug ?

1. Gather 2 items in the anvil with levels 6 or 8
2. Enchant them (Works)
3. Look at the console

What is your EnchantControl version?

Sadly, I will say, the latest downloadable version of spigot

What is your spigot/craftbukkit version?

Minecraft Purpur 1.16.5 1163

Logs / Files

https://pastebin.com/9Tyhh3uN

1. Your full server startup from the logs\latest.log :
   latest.log

2. Your EnchantControl config.yml : https://pastebin.com/wRfJPxaZ

3. Your log's error : https://pastebin.com/9Tyhh3uN

I've entirely banned some enchants via this plugin, but players still can get those from killing mobs which randomly spawn with enchanted weapons or armor (for example, sharpness is banned, but zombies still spawn with swords on sharpness 3 and they can drop these swords after death). Could you make feature which removes banned enchants from mobs? Thanks for working on this plugin though.

Currently, the plugin GENERALIZES the configuration for ALL USERS, I would like to add a part to the configuration, which allows the same, but with 1 special permission, and enchantments per group.

For example: common users, can use enchantments up to level 8.
but payments users, can use stakes up to level 10, basically

                  Perm : enchantcontrolreforged.enchantlimit.8 (common users)
                  Perm : enchantcontrolreforged.enchantlimit.10 (payments users)