[RFE] print patched functions through sysfs about kpatch HOT 5 CLOSED

I think this would be very useful.

• It should probably go in the patch module code in kmod/patch/kpatch-patch-hook.c.
• You'd probably have to use an exported kallsyms function, maybe sprint_symbol_no_offset.

Thanks!

from kpatch.

Yes, I had implemented a draft, and why have to use sprint_symbol_no_offset ? I used lookup_symbol_name, and it also works.

I also have a question: sysfs only give show() function a PAGE_SIZE buffer. Do we need to use seq_file to store the function names?

from kpatch.

Ah, did you call lookup_symbol_name from the patch module? If so, kpatch-build probably hard-coded its address. It's not exported, which means it's not supposed to be used by modules, so its interface could change at any time. I think it would be cleaner and more future-proof to use a properly exported function.

To make sure that we never overrun the PAGE_SIZE buffer, maybe give each function its own sysfs file?

from kpatch.

Thanks for your advices I will implement them tomorrow. :)

from kpatch.

Closing since this will soon be merged with #180.

from kpatch.