dynastic / place Goto Github PK

username.toLowerCase() pls kthxbai

The server doesn't seem to like the 0 index.

It should really just fail silently

i don't know if it's only me, but i can't place white pixels at all, doesn't matter in zoomed in or out mode

plz fix

Please have it so if I right-click on the canvas, it won't bring up the right-click menu, and especially won't place the tile I have in my hand. Also right now, right-clicking zooms in, but won't zoom back out. All of these features were in reddit's place.

I'm not sure that captcha is the issue, but I think it is.

TypeError: Cannot read property 'verify' of undefined
    at /home/s/place/routes/public.js:28:22
    at Layer.handle [as handle_request] (/home/s/place/node_modules/express/lib/router/layer.js:95:5)
    at next (/home/s/place/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/home/s/place/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/home/s/place/node_modules/express/lib/router/layer.js:95:5)
    at /home/s/place/node_modules/express/lib/router/index.js:281:22
    at Function.process_params (/home/s/place/node_modules/express/lib/router/index.js:335:12)
    at next (/home/s/place/node_modules/express/lib/router/index.js:275:10)
    at /home/s/place/routes/public.js:16:73
    at Layer.handle [as handle_request] (/home/s/place/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/home/s/place/node_modules/express/lib/router/index.js:317:13)
    at /home/s/place/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/home/s/place/node_modules/express/lib/router/index.js:335:12)
    at next (/home/s/place/node_modules/express/lib/router/index.js:275:10)
    at Function.handle (/home/s/place/node_modules/express/lib/router/index.js:174:3)
    at router (/home/s/place/node_modules/express/lib/router/index.js:47:12)
    at Layer.handle [as handle_request] (/home/s/place/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/home/s/place/node_modules/express/lib/router/index.js:317:13)
    at /home/s/place/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/home/s/place/node_modules/express/lib/router/index.js:335:12)
    at next (/home/s/place/node_modules/express/lib/router/index.js:275:10)
    at User.findById.then.user (/home/s/place/util/HTTPServer.js:57:17)

Authentication method was GitHub.

I have quite a bit of experience maintaining projects and repos, and have a few notes:

1. Code style

Please follow the coding styles throughout the project

isn't going to do when you have multiple people contributing. You need to decide on a linting tool/style framework and enforce it as part of the build or test process (I use StandardJS).

2. Yarn

Use it. Much faster and more reliable than npm

3. Dependency Management

Dependencies can get out of hand quickly. It's always best to introduce a new dependency only when you need to. Obviously frameworks, etc. are inevitable, but try to be frugal with adding new dependencies; and always remove dependencies if they're not used anymore

4. CI

Travis checks and / or tests?

I'm willing to PR with some/all of these updates, but they should be agreed on beforehand

Zooming in and out works, but trying to move instead zooms in.

The following calls are deprecated in jQuery and have been removed as of jQuery 3.0:

• $.success
• $.error
• $.complete

Instead, the following should be used:

• $.done
• $.fail
• $.always

Below is the official deprecation notice

Deprecation Notice:

The jqXHR.success(), jqXHR.error(), and jqXHR.complete() callbacks will be deprecated in jQuery 1.8. To prepare your code for their eventual removal, use jqXHR.done(), jqXHR.fail(), and jqXHR.always() instead.

I'll fix this

Hey,

Would it be possible to add Steemconnect authentication?

https://steemconnect.com/
https://steemit.com/tutorial/@krnel/tutorial-how-to-add-steemit-login-to-your-site-with-steemconnect

I'm very interested in running my own place instance.

Thanks for the great work 👍

When sorting ascending/descending the account created column in mod tools, the results do not correspond and are in a seemingly random order.

The timer stops at 0:01 and I have to reload the page to place again.

it would be nice, so that way we can link stuff on twitter and other sites to get our logo to recognize the site

Hoverover should show more shit for admins

If you select a Pixel while zoomed out and then click the pixel is placed.

I suggest makeing it like in the original that the click when zoomed out with a pixel in your hand you will zoom in to the area you clicked on.

For example, in /r/place you could click a pixel and copy the url that popped up, like this: https://www.reddit.com/r/place#x=104&y=14 (it wont work now that place is done).

You can pan as far as you want outside the canvas into the grey area.

This bug was introduced with #73, by @EricRabil.

Due to the new behaviour, whilst a user is on cooldown, they can no longer view tile information. I'd consider this a huge lack of functionality, and I would want to address this as soon as I can.

However, particularly for mobile users, this could be challenging to implement, so we'll need to hold a discussion regarding this at some point today.

Relevant reddit thread https://www.reddit.com/r/place20/comments/676rfd/annoying_bug_any_workaround/

Just played around with 2 users:

POST /api/place 200 7.950 ms - 54
POST /api/place 200 5.879 ms - 54
POST /api/place 200 10.919 ms - 54
POST /api/place 200 10.752 ms - 54
events.js:163
      throw er; // Unhandled 'error' event
      ^

Error: Batch is already running
    at /Users/gw/dev/place/node_modules/pajk-lwip/lib/BatchPrototypeInit.js:53:39
    at Object.exec (/Users/gw/dev/place/node_modules/decree/dist/cjs/decree.js:69:29)
    at Batch.exec (/Users/gw/dev/place/node_modules/pajk-lwip/lib/BatchPrototypeInit.js:52:16)
    at user.addPixel (/Users/gw/dev/place/util/PaintingHandler.js:109:57)
    at /Users/gw/dev/place/models/user.js:156:20
    at /Users/gw/dev/place/node_modules/mongoose/lib/model.js:3720:16
    at /Users/gw/dev/place/node_modules/mongoose/lib/services/model/applyHooks.js:146:20
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

Using node 7.8.0 on macOS 10.10

so you can have specific themes to build/destroy

First finger is still recognized as panning while gesture takes place

Is there any possibility for a CI? e.g. Wercker, Travis CI, Circle CI...

like one from r/france, one from r/linux, r/placestart and so on

Would it be possible to allow users to sign in using a reddit account, as /r/place was originally a subreddit?

when you pick a color to choose to place but you took another color instead, be able to right click to cancel the placement of the pixel

I'm working on something and I feel it would be useful for people to have, along with the coordinates like the original place did :)

Fixed this problem by switching to pajk-lwip.

However, this problem deserves a issue anyways. lwip has old libs, which cause it to fail the build. The new package seems to output a bunch of warnings but it's at least working.

Found the new package from here: EyalAr/lwip#258 (comment)

1.- Place a pixel zoomed in.
2.- Wait for the cooldown (still zoomed in).
3.- Try to place another pixel when the cooldown goes off.

Expected result: Place the pixel
Actual result: No pixel placement.

How to place after that?

1.- Zoom out
2.- Place the pixel while zoomed out (Loss of precision)

Tried placing it after zooming out and in again but no success.

It would be awesome if we could have separate Artboards so that subreddits/groups can work on their own art pieces without any outside disturbances. And having Discord like invite system for each Artboard would be awesome.

I know this would detract from the idea of everyone working on a single art piece. But having a default Art board which everyone would see - like how it works right now, and then users being able to create separate artboards would be great. You would be able to monetize it by restricting the options too - if you want.

I'd love to help build this particular feature, let me know if y'all are interested.

i can host the archives if you want

it would be nice to know how many people are on the site, beside cloudfare complaining that shit's going out

Feature request; hover over a pixel and see the author.
It'd be cool if the pixel was highlighted with an outline to make it clearer which pixel that author is for.