dynamods / dynamodictionarylegacy Goto Github PK

Hello Dynos,

Thank you the dictionary is very good and usefull for better understanding!

Can I here download all .dyn and .zip files as "dictionary" ? ideal would be sorted by topic (builtin, Revit, Geometrie,...)

KR

Andreas

When creating a PR, clicking anywhere outside the small white window will close that window again. I don’t think that should happen. You’re offering a way for closing the window with that X in the top right corner – that should be sufficient.

I have some issues uploading a picture in the dynamo dictionary for Curve.ParameterAtSegmentLength. I can add the picture with the plus button at the bottom (scanned hand sketch) and I have added an empty dyn file. But after clicking top right on submit, it takes forever and nothing expect the waiting gif is displyed. It looks not professional, but I think it will help to understand the node =)

empty.zip

Last sentence on landing page:

If you have any issues, please don't hesitate to log theme here.

theme should be them.

This is just an example...

Advise: Even if the library tree is not sorted in the order of Dynamo 2.X you should use atm 1.X

After submitting a PR through the site, I updated another node and wanted to create a new PR but in the top right corner there was still the "View PR on GitHub" link.
Steps to reproduce:

• Make changes to the site
• Create a PR
• Make some more changes
• Notice how the site displays the "View PR on GitHub" link instead of the "Create Pull Request" link

Workaround obviously is to close the browser and submit new material in a new session.

The following nodes are missing description or image/example files

· CountTrue
· Rank
· DayOfWeek
· TrimLeadingWhitespace

For contributors, it would be extremely helpful to filter nodes by their documentation status. I had to browse for quite a while before I found an undocumented node. Please make it easier for users actively seeking to contribute stuff to actually be able to do that.

If there's a node with the exact same name as my search term, this should be the first result of a search operation.
Steps to reproduce:

• Search for "not"
• Notice how the Not node is the last result

In the following case, I simply wanted to make a 1:1 paring.

You are presented instead with a list:

and scrolling to the node gives:

This is confusing.

There should probably be only one entry for code block nodes.

There is no package.json in the root directory of master and I couldn't find it on any of the other branches -- build instructions in README don't work without a package.json file.

The following nodes are missing documentation completely:

• String from Array
• String from Object

I think this might be an error and not one an instance of the ~24 nodes that are lacking documentation

Dynamo Primer.pdf

http://dictionary.dynamobim.com/#/Core/Units/Action/Unit Types

So my auto-complete made this faux pas, but it still shouldn't cause a crash!

Please refer to attached image.

This is just a hunch on my part, but it looks like the PRs may be longer than they need to be (which would make reviewing them a bit of a tedious exercise. When I look at the test PR that @kronz committed while demo’ing the new site to me (DynamoDS/DynamoDictionary@07ae830), it seems like it should have only included the very last part (for Arc.ByStartPointEndPointStartTangent). Everything else looks like it was just our browsing history.

Hey Everyone, I was wondering if it is possible to get the Revit nodes added to the library? All I need is the names and formatting generated and I'd be willing to get going on generating descriptions, images and samples.

-John

In some cases where nodes are located on several levels of the category hierarchy (File category is a good example with two nodes in the top category and everything else in subcategories), the nodes don’t show up in the navigation. That is something that I think needs fixing asap.

Please refer to the attached image:

Because it works with string keys:

Any time there is a method name that is the same but has different parameters.

-MinValue(()) and MinValue(year, month, day)
-FromPixels(colors,width,height) and FromPixels(colors)

For instance, clicking on either FromPixels returns the same page and clicking on one when the other is selected toggles the page on/off

just to name a couple. It is a global problem and not isolated cases.

I think it would be valuable to add a comment section below each node description and maybe somehow connected with the Dynamo Forum for node specific questions

As discussed with @kronz and @Racel on Friday, I think it would be nice for version 2 if we could submit the PRs using our own GitHub accounts as it would facilitate tracking what happens with our submissions. This would also help in case there is the need for updating the submitted content.

I did not get a link to the PR after submitting - I am sure I saw that this should happen when @kronz demo'ed it to me on Friday. Looks like the PR didn’t go through. The ReachBot did however create a new branch (https://github.com/DynamoDS/DynamoDictionary/tree/AndreastestSubmission_2016-10-17-8-57-22), but I couldn’t locate my PR there. Perhaps because I had closed and opened the PR window on the dictionary site several times before that? This kind of behaviour is going to confuse users. (Also, the Submit PR button in the top right corner didn’t disappear after submitting but clicking on it wouldn’t open the submission window again either.

In pull request, https://github.com/DynamoDS/DynamoDictionary/pull/135 , I edited several entries with added images.

When navigating back and forth through the entries, I noticed the images broke on the first entry. It seems they may have not came through on the pull request either.

(I have an example below, don't worry I didn't submit these ones 😄)