dylan-lang / vscode-dylan Goto Github PK

The current textmate grammar has clauses to parse the 'header' part of a source file (the collection of Key: Value lines) but it is too keen and also picks up lines in the code that have a colon in them. Example:

The ':' in the string makes the grammar think it's parsing a header line, which also swallows the closing double quote and makes the string extend over the last few lines (orange color)
This is made tricky because AFAICS textmate grammars don't allow you to split a file into different regions with different rules.

I noticed if the code contains a colon (e.g. a keyword), the highlighting stops working afterwards. This persists, I think, until the next line that doesn't start with white-space. In the example below, highlighting stops after size: and starts again at end method.
This may be due to the rules for the header part of the file (Module: .... etc.) matching other parts. When I use "Developer: Inspect TM scopes" in VSCode it says those parts are 'meta.header.mail'

Using VSCode 1.27.2 vscode-dylan 0.2.0

By inspection of the regular expressions I see that we don't match may-inline, default-inline, or not-inline.

When using npm i to install dependencies it warns of a critical vulnerability in Mocha (the test framework). We're using an old version 2.5.3, current is 5.2.0. It doesn't matter a great deal as the extension doesn't seem to have much in the way of tests.

$ npm audit
=== npm audit security report ===
# Run  npm install --save-dev [email protected]  to resolve 3 vulnerabilities
SEMVER WARNING: Recommended action is a potentially breaking change
  Low             Regular Expression Denial of Service
  Package         debug
  Dependency of   mocha [dev]
  Path            mocha > debug
  More info       https://nodesecurity.io/advisories/534

  High            Regular Expression Denial of Service
  Package         minimatch
  Dependency of   mocha [dev]
  Path            mocha > glob > minimatch
  More info       https://nodesecurity.io/advisories/118

  Critical        Command Injection
  Package         growl
  Dependency of   mocha [dev]
  Path            mocha > growl
  More info       https://nodesecurity.io/advisories/146

found 3 vulnerabilities (1 low, 1 high, 1 critical) in 902 scanned packages
  3 vulnerabilities require semver-major dependency updates.

Can be fixed with the suggested command line npm install --save-dev [email protected]

I can confirm this major version change doesn't break the current test setup.