Angular 1.3 about angular-modal-service HOT 6 CLOSED

Hi @jlambert121 thanks for the info, it's good to know that so far there'll be no breaking changes. Once AngularJS 1.3 lands officially I'll make the change

from angular-modal-service.

1.3 released, update package, please.

from angular-modal-service.

It looks like there is an error with angular 1.3, but it doesn't seem to impact the usage (for how we use it anyway). I tried looking at it, but my knowledge of ngAnimate ends about with the name and wasn't able to figure this out. Here's the error though (happens when you close the modal):

TypeError: Cannot read property 'classes' of undefined
    at resolveElementClasses (http://localhost:8000/bower_components/angular-animate/angular-animate.js:549:22)
    at http://localhost:8000/bower_components/angular-animate/angular-animate.js:1188:27
    at http://localhost:8000/bower_components/angular-animate/angular-animate.js:514:22
    at Scope.$digest (http://localhost:8000/bower_components/angular/angular.js:14015:36)
    at Scope.$apply (http://localhost:8000/bower_components/angular/angular.js:14227:24)
    at http://localhost:8000/bower_components/angular/angular.js:15948:36
    at completeOutstandingRequest (http://localhost:8000/bower_components/angular/angular.js:4877:10)
    at http://localhost:8000/bower_components/angular/angular.js:5250:7 

from angular-modal-service.

Odd @jlambert121 this library doesn't depend on angular-animate? +1 to update this as it's blocking my current project (restangular is using 1.3.3 whereas this is stuck on 1.2.0)

from angular-modal-service.

It doesn't depend on angular-animate, but we use angular-animate in some other pages so it's loaded.

from angular-modal-service.

Hi Guys,

I've released v0.5.0, targeting the latest version of AngularJS. If you are still experiencing issues with angular-animate, let's raise a separate task and track it there - I can always add angular-animate to one of the samples to see if I can reproduce it too.

from angular-modal-service.