Comments (4)
Same issue here. "close" promise doesn't remove DOM. Not sure why.
I do see it works well in demo page (http://dwmkerr.github.io/angular-modal-service/)...
from angular-modal-service.
Probably you've attached some kind of $on on $rootScope
and listener isn't destroyed - in my case it was socket.on
of socket.io. See answer in this question: https://stackoverflow.com/questions/26487365/angularjs-ui-bootstrap-scope-not-disposed-after-modal-dismiss
from angular-modal-service.
Clicking the background is a dismissal of the modal and so it needs to resolve the close promise.
You will need to add a bootstrap modal hidden listener to the modals controller where the close promise is injected.
app.controller('SomeController', ['$scope', '$element', 'close', function ($scope, $element, close) {
var myDismissedModalResult = {}; //prepare a result for when the modal is dismissed via the background click.
//listen for when the modal is dismissed and resolve the ModalService Close promise
$element.on('hidden.bs.modal', function (e) {
close(myDismissedModalResult, 200); // close, but give 200ms for bootstrap to animate
});
}]);
from angular-modal-service.
Thanks to @decherneyge this is now in the bootstrap sample, so closing this issue now. Please re-open if needed!
from angular-modal-service.
Related Issues (20)
- ModalService.closeModals() - Dont close other modals HOT 2
- Memory leak HOT 2
- modal is not showing up but code js is ok
- Modal not getting closed HOT 3
- Modal service not working with bootstrap 4 beta (popper.js issue)
- Request: Upgrade to Angular 2 (and higher) HOT 2
- Browser support for angular-modal-service HOT 2
- doing operations on modal close HOT 1
- An in-range update of karma is breaking the build 🚨 HOT 15
- Close callback being called multiple times when location changes
- null is not an object (evaluating 'r.resolve')
- request: make it compatible with AngularJS 1.7 HOT 1
- Jquery datepicker not open issue in modal HOT 1
- An in-range update of webpack is breaking the build 🚨 HOT 21
- Latest version capture any angular error through the modal service
- Component bindings are bound too late HOT 3
- Can't overlay modals HOT 1
- An in-range update of uglify-js is breaking the build 🚨 HOT 22
- Close in a single controller?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-modal-service.